test: remove google-closure-compiler from tests (#49559)

google-closure-compiler does not support ES2022

(cherry picked from commit 54365418bb8388ffa9b6388ae438e4d6ac4e081d)

PR Close #49559
This commit is contained in:
Alan Agius
2023-03-09 09:36:20 +00:00
committed by Andrew Scott
parent 0f2937ef83
commit 6762f79b3d
31 changed files with 1 additions and 472 deletions
@@ -1,11 +0,0 @@
load("//integration:index.bzl", "ng_integration_test")
ng_integration_test(
name = "test",
# TODO: Re-enable size-tracking:
# We should define ngDevMode to false in Closure, but --define only works in the global scope.
# With ngDevMode not being set to false, this size tracking test provides little value but a lot of
# headache to continue updating the size.
# track_payload_size = "hello_world_closure",
setup_chromium = True,
)
@@ -1,20 +0,0 @@
--compilation_level=SIMPLE
--language_in=ECMASCRIPT_2020
--language_out=ECMASCRIPT_2020
--js_output_file=dist/bundle.js
--output_manifest=dist/manifest.MF
--variable_renaming_report=dist/variable_renaming_report
--property_renaming_report=dist/property_renaming_report
--create_source_map=%outname%.map
--warning_level=QUIET
--dependency_mode=PRUNE
--rewrite_polyfills=false
--module_resolution=node
--package_json_entry_names es2020,module
node_modules/zone.js/zone_externs.js
--js built/bundle.js
--entry_point=built/bundle.js
@@ -1,11 +0,0 @@
import { browser, element, by } from 'protractor';
describe('Hello world E2E Tests', function () {
it('should display: Hello world!', function () {
browser.get('');
const div = element(by.css('div'));
expect(div.getText()).toEqual('Hello world!');
element(by.css('input')).sendKeys('!');
expect(div.getText()).toEqual('Hello world!!');
});
});
@@ -1,15 +0,0 @@
{
"open": false,
"logLevel": "silent",
"port": 4202,
"server": {
"baseDir": "src",
"routes": {
"/dist": "dist",
"/node_modules": "node_modules"
},
"middleware": {
"0": null
}
}
}
@@ -1,21 +0,0 @@
// Protractor configuration file, see link for more information
// https://github.com/angular/protractor/blob/master/lib/config.ts
exports.config = {
specs: [
'../built/e2e/*.e2e-spec.js'
],
chromeDriver: process.env.CHROMEDRIVER_BIN,
capabilities: {
browserName: 'chrome',
chromeOptions: {
binary: process.env.CHROME_BIN,
// See /integration/README.md#browser-tests for more info on these args
args: ['--no-sandbox', '--headless', '--disable-gpu', '--disable-dev-shm-usage', '--hide-scrollbars', '--mute-audio']
}
},
directConnect: true,
// Port comes from lite-server config `/e2e/browser.config.json` `"port": 4202`
baseUrl: 'http://localhost:4202/',
framework: 'jasmine',
useAllAngular2AppRoots: true
};
@@ -1,6 +0,0 @@
{
"compilerOptions": {
"outDir": "../built/e2e",
"types": ["jasmine", "jasminewd2"],
}
}
@@ -1,38 +0,0 @@
{
"name": "angular-integration",
"version": "0.0.0",
"license": "MIT",
"dependencies": {
"@angular/common": "file:../../dist/packages-dist/common",
"@angular/compiler": "file:../../dist/packages-dist/compiler",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/core": "file:../../dist/packages-dist/core",
"@angular/elements": "file:../../dist/packages-dist/elements",
"@angular/platform-browser": "file:../../dist/packages-dist/platform-browser",
"rxjs": "file:../../node_modules/rxjs",
"typescript": "file:../../node_modules/typescript",
"tslib": "file:../../node_modules/tslib",
"zone.js": "file:../../dist/zone.js-dist/archive/zone.js.tgz"
},
"devDependencies": {
"@babel/core": "file:../../node_modules/@babel/core",
"@rollup/plugin-babel": "file:../../node_modules/@rollup/plugin-babel",
"@rollup/plugin-node-resolve": "file:../../node_modules/@rollup/plugin-node-resolve",
"@types/jasmine": "file:../../node_modules/@types/jasmine",
"@types/jasminewd2": "file:../../node_modules/@types/jasminewd2",
"concurrently": "3.4.0",
"google-closure-compiler": "file:../../node_modules/google-closure-compiler",
"lite-server": "2.2.2",
"protractor": "file:../../node_modules/protractor",
"rollup": "file:../../node_modules/rollup",
"tsickle": "file:../../node_modules/tsickle"
},
"scripts": {
"closure": "google-closure-compiler --flagfile closure.conf",
"build": "yarn ngc && yarn rollup -c rollup.config.mjs && yarn closure",
"test": "yarn build && concurrently \"yarn run serve\" \"yarn run protractor\" --kill-others --success first",
"serve": "lite-server -c e2e/browser.config.json",
"preprotractor": "tsc -p e2e",
"protractor": "protractor e2e/protractor.config.js"
}
}
@@ -1,27 +0,0 @@
import {nodeResolve} from '@rollup/plugin-node-resolve';
import {babel} from '@rollup/plugin-babel';
import {ConsoleLogger, NodeJSFileSystem, LogLevel} from '@angular/compiler-cli';
import {createEs2015LinkerPlugin} from '@angular/compiler-cli/linker/babel';
/** File system used by the Angular linker plugin. */
const fileSystem = new NodeJSFileSystem();
/** Logger used by the Angular linker plugin. */
const logger = new ConsoleLogger(LogLevel.info);
/** Linker babel plugin. */
const linkerPlugin = createEs2015LinkerPlugin({
fileSystem,
logger,
linkerJitMode: false,
});
export default {
input: './built/src/main.js',
output: {
file: './built/bundle.js',
format: 'iife'
},
plugins: [
nodeResolve(),
babel({plugins: [linkerPlugin]}),
]
}
@@ -1,11 +0,0 @@
import {HelloWorldComponent} from './hello-world.component';
import {NgModule} from '@angular/core';
import {BrowserModule} from '@angular/platform-browser';
@NgModule({
declarations: [HelloWorldComponent],
bootstrap: [HelloWorldComponent],
imports: [BrowserModule],
})
export class AppModule {}
@@ -1,12 +0,0 @@
import {Component} from '@angular/core';
@Component({
selector: 'hello-world-app',
template: `
<div>Hello {{ name }}!</div>
<input type="text" [value]="name" (input)="name = $event.target.value"/>
`,
})
export class HelloWorldComponent {
name: string = 'world';
}
@@ -1,18 +0,0 @@
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>Hello World</title>
<base href="/">
</head>
<body>
<hello-world-app>Loading...</hello-world-app>
<script src="node_modules/zone.js/bundles/zone.umd.min.js"></script>
<script src="dist/bundle.js"></script>
</body>
</html>
@@ -1,4 +0,0 @@
import {platformBrowser} from '@angular/platform-browser';
import {AppModule} from './app';
platformBrowser().bootstrapModule(AppModule);
@@ -1,25 +0,0 @@
{
"angularCompilerOptions": {
"annotationsAs": "static fields",
"annotateForClosureCompiler": true,
},
"compilerOptions": {
"module": "es2015",
"moduleResolution": "node",
"target": "es6",
"noImplicitAny": false,
"sourceMap": false,
"experimentalDecorators": true,
"outDir": "built",
"rootDir": ".",
"declaration": true,
"types": []
},
"exclude": [
"vendor",
"node_modules",
"built",
"dist",
"e2e"
]
}
-6
View File
@@ -1,6 +0,0 @@
load("//integration:index.bzl", "ng_integration_test")
ng_integration_test(
name = "test",
setup_chromium = True,
)
-20
View File
@@ -1,20 +0,0 @@
--compilation_level=SIMPLE
--language_in=ECMASCRIPT_2020
--language_out=ECMASCRIPT_2020
--js_output_file=dist/bundle.js
--output_manifest=dist/manifest.MF
--variable_renaming_report=dist/variable_renaming_report
--property_renaming_report=dist/property_renaming_report
--create_source_map=%outname%.map
--warning_level=QUIET
--dependency_mode=PRUNE
--rewrite_polyfills=false
--module_resolution=node
--package_json_entry_names es2020,module
node_modules/zone.js/zone_externs.js
--js built/bundle.js
--entry_point=built/bundle.js
-10
View File
@@ -1,10 +0,0 @@
import { browser, element, by } from 'protractor';
describe('i18n E2E Tests', function () {
it('remove i18n attributes', function () {
browser.get('');
const div = element(by.css('div'));
expect(div.getAttribute('title')).not.toBe(null);
expect(div.getAttribute('i18n')).toBe(null);
});
});
-15
View File
@@ -1,15 +0,0 @@
{
"open": false,
"logLevel": "silent",
"port": 4204,
"server": {
"baseDir": "src",
"routes": {
"/dist": "dist",
"/node_modules": "node_modules"
},
"middleware": {
"0": null
}
}
}
-21
View File
@@ -1,21 +0,0 @@
// Protractor configuration file, see link for more information
// https://github.com/angular/protractor/blob/master/lib/config.ts
exports.config = {
specs: [
'../built/e2e/*.e2e-spec.js'
],
chromeDriver: process.env.CHROMEDRIVER_BIN,
capabilities: {
browserName: 'chrome',
chromeOptions: {
binary: process.env.CHROME_BIN,
// See /integration/README.md#browser-tests for more info on these args
args: ['--no-sandbox', '--headless', '--disable-gpu', '--disable-dev-shm-usage', '--hide-scrollbars', '--mute-audio']
}
},
directConnect: true,
// Port comes from lite-server config `/e2e/browser.config.json` `"port": 4204`
baseUrl: 'http://localhost:4204/',
framework: 'jasmine',
useAllAngular2AppRoots: true
};
-6
View File
@@ -1,6 +0,0 @@
{
"compilerOptions": {
"outDir": "../built/e2e",
"types": ["jasmine", "jasminewd2"],
}
}
-39
View File
@@ -1,39 +0,0 @@
{
"name": "angular-integration",
"version": "0.0.0",
"license": "MIT",
"dependencies": {
"@angular/common": "file:../../dist/packages-dist/common",
"@angular/compiler": "file:../../dist/packages-dist/compiler",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/core": "file:../../dist/packages-dist/core",
"@angular/localize": "file:../../dist/packages-dist/localize",
"@angular/platform-browser": "file:../../dist/packages-dist/platform-browser",
"rxjs": "file:../../node_modules/rxjs",
"tslib": "file:../../node_modules/tslib",
"typescript": "file:../../node_modules/typescript",
"zone.js": "file:../../dist/zone.js-dist/archive/zone.js.tgz"
},
"devDependencies": {
"@babel/core": "file:../../node_modules/@babel/core",
"@rollup/plugin-babel": "file:../../node_modules/@rollup/plugin-babel",
"@rollup/plugin-node-resolve": "file:../../node_modules/@rollup/plugin-node-resolve",
"@types/jasmine": "file:../../node_modules/@types/jasmine",
"@types/jasminewd2": "file:../../node_modules/@types/jasminewd2",
"concurrently": "3.4.0",
"google-closure-compiler": "file:../../node_modules/google-closure-compiler",
"lite-server": "2.2.2",
"protractor": "file:../../node_modules/protractor",
"rollup": "file:../../node_modules/rollup",
"tsickle": "file:../../node_modules/tsickle"
},
"scripts": {
"build": "yarn ngc && yarn rollup -c rollup.config.mjs && yarn closure",
"closure": "google-closure-compiler --flagfile closure.conf",
"test": "yarn build && concurrently \"yarn run serve\" \"yarn run protractor\" --kill-others --success first && yarn test-locale-folder",
"test-locale-folder": "node test-locale-folder.js",
"serve": "lite-server -c e2e/browser.config.json",
"preprotractor": "tsc -p e2e",
"protractor": "protractor e2e/protractor.config.js"
}
}
-27
View File
@@ -1,27 +0,0 @@
import {nodeResolve} from '@rollup/plugin-node-resolve';
import {babel} from '@rollup/plugin-babel';
import {ConsoleLogger, NodeJSFileSystem, LogLevel} from '@angular/compiler-cli';
import {createEs2015LinkerPlugin} from '@angular/compiler-cli/linker/babel';
/** File system used by the Angular linker plugin. */
const fileSystem = new NodeJSFileSystem();
/** Logger used by the Angular linker plugin. */
const logger = new ConsoleLogger(LogLevel.info);
/** Linker babel plugin. */
const linkerPlugin = createEs2015LinkerPlugin({
fileSystem,
logger,
linkerJitMode: false,
});
export default {
input: './built/src/main.js',
output: {
file: './built/bundle.js',
format: 'iife'
},
plugins: [
nodeResolve(),
babel({plugins: [linkerPlugin]}),
]
}
-11
View File
@@ -1,11 +0,0 @@
import {HelloWorldComponent} from './hello-world.component';
import {NgModule} from '@angular/core';
import {BrowserModule} from '@angular/platform-browser';
@NgModule({
declarations: [HelloWorldComponent],
bootstrap: [HelloWorldComponent],
imports: [BrowserModule],
})
export class AppModule {}
@@ -1,9 +0,0 @@
import {Component} from '@angular/core';
@Component({
selector: 'hello-world-app',
template: `<div i18n="desc|meaning" title="i18n attribute should be removed">Hello {{ name }}!</div>`,
})
export class HelloWorldComponent {
name: string = 'world';
}
-18
View File
@@ -1,18 +0,0 @@
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>Hello World</title>
<base href="/">
</head>
<body>
<hello-world-app>Loading...</hello-world-app>
<script src="node_modules/zone.js/bundles/zone.umd.min.js"></script>
<script src="dist/bundle.js"></script>
</body>
</html>
-6
View File
@@ -1,6 +0,0 @@
import '@angular/localize/init'
import {platformBrowser} from '@angular/platform-browser';
import {AppModule} from './app';
platformBrowser().bootstrapModule(AppModule);
-14
View File
@@ -1,14 +0,0 @@
const fs = require('fs');
const path = require('path');
const packageJson = require('@angular/common/package.json');
const localesFolder = packageJson['locales'];
if (!localesFolder) {
throw new Error(`@angular/common/package.json does not contain 'locales' entry.`)
}
const enLocalePath = `@angular/common/${localesFolder}/en`;
try {
require.resolve(enLocalePath);
} catch (err) {
throw new Error(`@angular/common does not contain 'en' locale in ${enLocalePath}.`)
}
-26
View File
@@ -1,26 +0,0 @@
{
"angularCompilerOptions": {
"annotationsAs": "static fields",
"annotateForClosureCompiler": true,
},
"compilerOptions": {
"module": "es2020",
"moduleResolution": "node",
"target": "es2020",
"noImplicitAny": false,
"sourceMap": false,
"experimentalDecorators": true,
"outDir": "built",
"rootDir": ".",
"declaration": true,
"types": []
},
"exclude": [
"vendor",
"node_modules",
"built",
"dist",
"e2e"
]
}
-20
View File
@@ -1,20 +0,0 @@
--compilation_level=SIMPLE
--language_in=ECMASCRIPT_2020
--language_out=ECMASCRIPT_2020
--js_output_file=dist/bundle.js
--output_manifest=dist/manifest.MF
--variable_renaming_report=dist/variable_renaming_report
--property_renaming_report=dist/property_renaming_report
--create_source_map=%outname%.map
--warning_level=QUIET
--dependency_mode=PRUNE
--rewrite_polyfills=false
--module_resolution=node
--package_json_entry_names es2020,module
node_modules/zone.js/zone_externs.js
--js built/bundle.js
--entry_point=built/bundle.js
+1 -3
View File
@@ -21,15 +21,13 @@
"@types/jasmine": "file:../../node_modules/@types/jasmine",
"@types/jasminewd2": "file:../../node_modules/@types/jasminewd2",
"concurrently": "3.4.0",
"google-closure-compiler": "file:../../node_modules/google-closure-compiler",
"lite-server": "2.2.2",
"protractor": "file:../../node_modules/protractor",
"rollup": "file:../../node_modules/rollup",
"tsickle": "file:../../node_modules/tsickle"
},
"scripts": {
"closure": "google-closure-compiler --flagfile closure.conf",
"build": "yarn ngc && yarn rollup -c rollup.config.mjs && yarn closure",
"build": "yarn ngc && yarn rollup -c rollup.config.mjs",
"test": "yarn build && concurrently \"yarn run serve\" \"yarn run protractor\" --kill-others --success first",
"serve": "lite-server -c e2e/browser.config.json",
"preprotractor": "tsc -p e2e",
-1
View File
@@ -6,7 +6,6 @@ NPM_PACKAGE_ARCHIVES = [
"@rollup/plugin-node-resolve",
"@rollup/plugin-commonjs",
"check-side-effects",
"google-closure-compiler",
"jasmine",
"typescript",
"rxjs",
-1
View File
@@ -117,7 +117,6 @@
"diff": "^5.0.0",
"document-register-element": "^1.7.2",
"domino": "https://github.com/angular/domino.git#4280d0380df839d97b81e7680877ad5b55500e77",
"google-closure-compiler": "20230206.0.0",
"graceful-fs": "4.2.10",
"hammerjs": "~2.0.8",
"http-server": "^14.0.0",