mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
refactor(button, chips): use toString method for aria-disabled (#5278)
For buttons and chips the value of the aria-disabled host binding is resolved from a extra method on the class instance. As already done in other components, the button and chips should just use `boolean.toString()` which is less payload and also makes the code more readable.
This commit is contained in:
committed by
Jeremy Elbourn
parent
5c9391df74
commit
5a38a9f9cc
@@ -193,7 +193,7 @@ export class MdButton extends _MdButtonMixinBase implements OnDestroy, CanDisabl
|
||||
a[mat-button], a[mat-raised-button], a[mat-icon-button], a[mat-fab], a[mat-mini-fab]`,
|
||||
host: {
|
||||
'[attr.disabled]': 'disabled || null',
|
||||
'[attr.aria-disabled]': '_isAriaDisabled',
|
||||
'[attr.aria-disabled]': 'disabled.toString()',
|
||||
'(click)': '_haltDisabledEvents($event)',
|
||||
},
|
||||
inputs: ['disabled', 'color'],
|
||||
@@ -216,10 +216,6 @@ export class MdAnchor extends MdButton {
|
||||
return this.disabled ? -1 : 0;
|
||||
}
|
||||
|
||||
get _isAriaDisabled(): string {
|
||||
return this.disabled ? 'true' : 'false';
|
||||
}
|
||||
|
||||
_haltDisabledEvents(event: Event) {
|
||||
// A disabled button shouldn't apply any actions
|
||||
if (this.disabled) {
|
||||
|
||||
@@ -55,7 +55,7 @@ export class MdBasicChip { }
|
||||
'role': 'option',
|
||||
'[class.mat-chip-selected]': 'selected',
|
||||
'[attr.disabled]': 'disabled || null',
|
||||
'[attr.aria-disabled]': '_isAriaDisabled()',
|
||||
'[attr.aria-disabled]': 'disabled.toString()',
|
||||
'(click)': '_handleClick($event)',
|
||||
'(focus)': '_hasFocus = true',
|
||||
'(blur)': '_hasFocus = false',
|
||||
@@ -109,11 +109,6 @@ export class MdChip extends _MdChipMixinBase implements Focusable, OnDestroy, Ca
|
||||
this.onFocus.emit({chip: this});
|
||||
}
|
||||
|
||||
/** The aria-disabled state for the chip */
|
||||
_isAriaDisabled(): string {
|
||||
return String(this.disabled);
|
||||
}
|
||||
|
||||
/** Ensures events fire properly upon click. */
|
||||
_handleClick(event: Event) {
|
||||
// Check disabled
|
||||
|
||||
Reference in New Issue
Block a user