skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): throw an Cyclic Dependency Error in prod mode (#60118)

Browse Source 
Prior to this change, cyclic injection didn't trigger any error in prod mode, resulting into injecting the `CIRCULAR` object.
This could lead to strange errors where no method would be found on the token.

fixes #60074

PR Close #60118
This commit is contained in:
Matthieu Riegler
2025-02-26 17:33:34 +01:00
committed by Miles Malerba
parent b4feeb5a7d
commit 4aeec9fa7d
12 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/di/r3_injector.ts
+1 -1
View File
@@ -473,7 +473,7 @@ export class R3Injector extends EnvironmentInjector {
private hydrate<T>(token: ProviderToken<T>, record: Record<T>): T {
const prevConsumer = setActiveConsumer(null);
try {
if (ngDevMode && record.value === CIRCULAR) {
if (record.value === CIRCULAR) {
throwCyclicDependencyError(stringify(token));
} else if (record.value === NOT_YET) {
record.value = CIRCULAR;
packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
+1
View File
@@ -478,6 +478,7 @@
"stringify",
"stringifyCSSSelector",
"style",
"throwCyclicDependencyError",
"throwProviderNotFoundError",
"timeoutProvider",
"transition",
packages/core/test/bundling/animations/bundle.golden_symbols.json
+1
View File
@@ -504,6 +504,7 @@
"stringify",
"stringifyCSSSelector",
"style",
"throwCyclicDependencyError",
"throwProviderNotFoundError",
"timeoutProvider",
"transition",
packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
+1
View File
@@ -410,6 +410,7 @@
"storeLViewOnDestroy",
"stringify",
"stringifyCSSSelector",
"throwCyclicDependencyError",
"throwProviderNotFoundError",
"timeoutProvider",
"uniqueIdCounter",
packages/core/test/bundling/defer/bundle.golden_symbols.json
+1
View File
@@ -881,6 +881,7 @@
"storeLViewOnDestroy",
"stringify",
"stringifyCSSSelector",
"throwCyclicDependencyError",
"throwProviderNotFoundError",
"timeoutProvider",
"trackMovedView",
packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
+1
View File
@@ -613,6 +613,7 @@
"storeLViewOnDestroy",
"stringify",
"stringifyCSSSelector",
"throwCyclicDependencyError",
"throwInvalidWriteToSignalError",
"throwInvalidWriteToSignalErrorFn",
"throwProviderNotFoundError",
packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
+1
View File
@@ -606,6 +606,7 @@
"storeLViewOnDestroy",
"stringify",
"stringifyCSSSelector",
"throwCyclicDependencyError",
"throwInvalidWriteToSignalError",
"throwInvalidWriteToSignalErrorFn",
"throwProviderNotFoundError",
packages/core/test/bundling/hello_world/bundle.golden_symbols.json
+1
View File
@@ -332,6 +332,7 @@
"storeLViewOnDestroy",
"stringify",
"stringifyCSSSelector",
"throwCyclicDependencyError",
"throwProviderNotFoundError",
"timeoutProvider",
"uniqueIdCounter",
packages/core/test/bundling/hydration/bundle.golden_symbols.json
+1
View File
@@ -442,6 +442,7 @@
"stringify",
"stringifyCSSSelector",
"subscribeOn",
"throwCyclicDependencyError",
"throwProviderNotFoundError",
"timeoutProvider",
"transferCacheInterceptorFn",
packages/core/test/bundling/router/bundle.golden_symbols.json
+1
View File
@@ -703,6 +703,7 @@
"take",
"takeLast",
"tap",
"throwCyclicDependencyError",
"throwError2",
"throwIfEmpty",
"throwInvalidWriteToSignalErrorFn",
packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
+1
View File
@@ -367,6 +367,7 @@
"storeLViewOnDestroy",
"stringify",
"stringifyCSSSelector",
"throwCyclicDependencyError",
"throwProviderNotFoundError",
"timeoutProvider",
"uniqueIdCounter",
packages/core/test/bundling/todo/bundle.golden_symbols.json
+1
View File
@@ -490,6 +490,7 @@
"storeLViewOnDestroy",
"stringify",
"stringifyCSSSelector",
"throwCyclicDependencyError",
"throwProviderNotFoundError",
"timeoutProvider",
"toTStylingRange",