skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: round payload size for comparison (#7174)

Browse Source 
In some cases the payload is still showing up in the CI even if there was no change to the library. This seems to be because the file sizes are not rounded and can sometimes be not very exact. Resulting in numbers like: `material_fesm_2014": 1004.1319999999998`.

To have a better output in the GitHub statuses, the file size should be rounded
This commit is contained in:
Paul Gschwendtner
2017-09-29 00:51:34 +02:00
committed by Jeremy Elbourn
parent 39c7b8124d
commit 3948381d64
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/gulp/tasks/payload.ts
+7 -2
View File
@@ -93,10 +93,10 @@ async function calculatePayloadDiff(database: firebaseAdmin.database.Database, c
// Calculate the payload diffs by subtracting the previous size of the FESM ES2015 bundles.
const cdkFullSize = currentPayload.cdk_fesm_2015;
const cdkDiff = cdkFullSize - previousPayload.cdk_fesm_2015;
const cdkDiff = roundFileSize(cdkFullSize - previousPayload.cdk_fesm_2015);
const materialFullSize = currentPayload.material_fesm_2015;
const materialDiff = materialFullSize - previousPayload.material_fesm_2015;
const materialDiff = roundFileSize(materialFullSize - previousPayload.material_fesm_2015);
// Set the Github statuses for the packages by sending a HTTP request to the dashboard functions.
await Promise.all([
@@ -174,3 +174,8 @@ function getCommitFromPreviousPayloadUpload(): string {
return spawnSync('git', ['rev-parse', process.env['TRAVIS_BRANCH']]).stdout.toString().trim();
}
}
/** Rounds the specified file size to two decimal places. */
function roundFileSize(fileSize: number) {
return Math.round(fileSize * 100) / 100;
}