skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove outdated golden screenshots (#7628)

Browse Source 
* chore: remove outdated golden screenshots

Currently if a screenshot test changed its name, the old golden reference image won't be deleted. This causes the screenshot diff task to compare against nothing (screenshot diffs now always fail).

With this change, outdated screenshot images will be deleted in master builds.

* Address feedback
This commit is contained in:
Paul Gschwendtner
2017-10-11 01:38:46 +02:00
committed by Andrew Seguin
parent 0d003743b4
commit 2d72ac9f0a
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/gulp/tasks/screenshots.ts
+13 -2
View File
@@ -188,15 +188,26 @@ function compareScreenshotFile(fileName: string, database: Database, prNumber: s
}
/** Uploads golden screenshots to the Google Cloud Storage bucket for the screenshots. */
function uploadGoldenScreenshots() {
async function uploadGoldenScreenshots() {
const bucket = openScreenshotsBucket();
const localScreenshots = getLocalScreenshotFiles(SCREENSHOT_DIR);
const storageGoldenFiles = (await bucket.getFiles({prefix: FIREBASE_STORAGE_GOLDENS}))[0];
return Promise.all(getLocalScreenshotFiles(SCREENSHOT_DIR).map(fileName => {
// Only delete golden images that are outdated to avoid collisions with other screenshot diffs.
// Deleting every golden screenshot may also work, but will likely cause flakiness if multiple
// screenshot tasks run.
const deleteOutdatedGoldenFiles = Promise.all(storageGoldenFiles
.filter((file: any) => !localScreenshots.includes(path.basename(file.name)))
.map((file: any) => file.delete()));
const uploadNewGoldenImages = Promise.all(localScreenshots.map(fileName => {
const filePath = path.join(SCREENSHOT_DIR, fileName);
const storageDestination = `${FIREBASE_STORAGE_GOLDENS}/${fileName}`;
return bucket.upload(filePath, { destination: storageDestination });
}));
await Promise.all([deleteOutdatedGoldenFiles, uploadNewGoldenImages]);
}
/**