skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: resolve benchmark compare ref from upstream if rev-parse fails

Browse Source 
`rev-parse` returns the original ref name in stdout, even if it wasn't
able to resolve the reference. This was preventing the upstream
resolution from never happening- causing `main` to be never resolved
to the actual SHA.
This commit is contained in:
Paul Gschwendtner
2023-06-19 13:17:41 +00:00
parent 619c318dcb
commit 254023a03c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/benchmarks/index.mts
+3 -2
View File
@@ -97,8 +97,9 @@ async function prepareForGitHubAction(commentBody: string): Promise<void> {
// Attempt to find the compare SHA. The commit may be either part of the
// pull request, or might be a commit unrelated to the PR- but part of the
// upstream repository. We attempt to fetch/resolve the SHA in both remotes.
let compareRefSha = git.runGraceful(['rev-parse', compareRefRaw]).stdout.trim();
if (compareRefSha === '') {
const compareRefResolve = git.runGraceful(['rev-parse', compareRefRaw]);
let compareRefSha = compareRefResolve.stdout.trim();
if (compareRefSha === '' || compareRefResolve.status !== 0) {
git.run(['fetch', '--depth=1', git.getRepoGitUrl(), compareRefRaw]);
compareRefSha = git.run(['rev-parse', 'FETCH_HEAD']).stdout.trim();
}