skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(localize): add support for unit-test builder in ng-add schematic

Browse Source 
This commit updates the @angular/localize ng-add schematic to support
the @angular/build:unit-test builder. It ensures that @angular/localize
is added to the types array in the TypeScript configuration file
associated with the unit-test target. If no tsConfig is specified in
the target options, it defaults to tsconfig.spec.json in the project root.
This commit is contained in:
Charles Lyding
2026-01-28 16:57:29 -05:00
committed by Leon Senft
parent 458bc4a2c8
commit 1c3b1cf18d
2 changed files with 75 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/localize/schematics/ng-add/index.ts
+14 -1
View File
@@ -79,13 +79,26 @@ function addTypeScriptConfigTypes(projectName: string): Rule {
case AngularBuilder.BrowserEsbuild:
case AngularBuilder.Browser:
case AngularBuilder.Application:
case AngularBuilder.BuildApplication:
case AngularBuilder.BuildKarma:
case AngularBuilder.BuildApplication: {
const value = target.options?.['tsConfig'];
if (typeof value === 'string') {
tsConfigFiles.add(value);
}
break;
}
case AngularBuilder.BuildUnitTest: {
const value = target.options?.['tsConfig'];
if (typeof value === 'string') {
tsConfigFiles.add(value);
} else {
// Defaults to tsconfig in project root
tsConfigFiles.add((project.root || '.') + '/tsconfig.spec.json');
}
break;
}
}
if (
packages/localize/schematics/ng-add/index_spec.ts
+61 -3
View File
@@ -73,17 +73,27 @@ describe('ng-add schematic', () => {
test: {
builder: '@angular-devkit/build-angular:karma',
options: {
tsConfig: './tsconfig.spec.json',
tsConfig: './tsconfig.spec-k1.json',
polyfills: 'zone.js',
},
},
testKarmaBuild: {
builder: '@angular/build:karma',
options: {
tsConfig: './tsconfig.spec.json',
tsConfig: './tsconfig.spec-k2.json',
polyfills: 'zone.js',
},
},
testBuildUnitTestA: {
builder: '@angular/build:unit-test',
options: {
tsConfig: './tsconfig.spec-a.json',
},
},
testBuildUnitTestB: {
builder: '@angular/build:unit-test',
options: {},
},
server: {
builder: '@angular-devkit/build-angular:server',
options: {
@@ -194,7 +204,55 @@ describe('ng-add schematic', () => {
expect(polyfills).toEqual(['@angular/localize/init']);
});
it(`should add '@angular/localize' in 'types' tsconfigs referenced in karma builder`, async () => {
it(`should add '@angular/localize' in 'types' tsconfigs referenced in devkit karma builder`, async () => {
const tsConfig = JSON.stringify({
compilerOptions: {
types: ['node'],
},
});
host.create('tsconfig.spec-k1.json', tsConfig);
host = await schematicRunner.runSchematic('ng-add', defaultOptions, host);
const {compilerOptions} = host.readJson('tsconfig.spec-k1.json') as TsConfig;
const types = compilerOptions?.types;
expect(types).toContain('@angular/localize');
expect(types).toHaveSize(2);
});
it(`should add '@angular/localize' in 'types' tsconfigs referenced in build karma builder`, async () => {
const tsConfig = JSON.stringify({
compilerOptions: {
types: ['node'],
},
});
host.create('tsconfig.spec-k2.json', tsConfig);
host = await schematicRunner.runSchematic('ng-add', defaultOptions, host);
const {compilerOptions} = host.readJson('tsconfig.spec-k2.json') as TsConfig;
const types = compilerOptions?.types;
expect(types).toContain('@angular/localize');
expect(types).toHaveSize(2);
});
it(`should add '@angular/localize' in 'types' tsconfigs referenced in unit-test builder`, async () => {
const tsConfig = JSON.stringify({
compilerOptions: {
types: ['node'],
},
});
host.create('tsconfig.spec-a.json', tsConfig);
host = await schematicRunner.runSchematic('ng-add', defaultOptions, host);
const {compilerOptions} = host.readJson('tsconfig.spec-a.json') as TsConfig;
const types = compilerOptions?.types;
expect(types).toContain('@angular/localize');
expect(types).toHaveSize(2);
});
it(`should add '@angular/localize' in 'types' tsconfigs default for unit-test builder`, async () => {
const tsConfig = JSON.stringify({
compilerOptions: {
types: ['node'],