skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: example list outputting quoted components (#13955)

Browse Source 
In c64503e0bf the logic that outputs the list of components was reworked to use `JSON.stringify`. As a result, the data that is generated has the `component` inside quotes, rather than a reference to the component class itself. This breaks the demo app. The following changes add some extra logic to remove the quotes around the `component`.
This commit is contained in:
Kristiyan Kostadinov
2018-11-10 00:09:56 +00:00
committed by vivian-hu
parent ae5b10f9d8
commit 06fb4087bc
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/example-module/generate-example-module.ts
+15 -15
View File
@@ -23,30 +23,30 @@ function buildImportsTemplate(data: ExampleMetadata): string {
/** Inlines the example module template with the specified parsed data. */
function inlineExampleModuleTemplate(parsedData: ExampleMetadata[]): string {
const exampleImports = parsedData.map(m => buildImportsTemplate(m)).join('\n');
const quotePlaceholder = '◬';
const exampleList = parsedData.reduce((result, data) => {
return result.concat(data.component).concat(data.additionalComponents);
}, [] as string[]).join(',');
const exampleComponents = parsedData.map((metaData) => {
const fields = [
`title: '${metaData.title.trim()}'`,
`component: ${metaData.component}`,
];
const exampleComponents = parsedData.reduce((result, data) => {
result[data.id] = {
title: data.title,
// Since we use JSON.stringify to output the data below, the `component` will be wrapped
// in quotes, whereas we want a reference to the class. Add placeholder characters next to
// where the quotes will be so that we can strip them away afterwards.
component: `${quotePlaceholder}${data.component}${quotePlaceholder}`,
additionalFiles: data.additionalFiles,
selectorName: data.selectorName.join(', '),
};
if (metaData.additionalFiles.length) {
fields.push(`additionalFiles: ${JSON.stringify(metaData.additionalFiles)}`);
}
if (metaData.selectorName.length) {
fields.push(`selectorName: '${metaData.selectorName.join(', ')}'`);
}
const data = '\n' + fields.map(field => ' ' + field).join(',\n');
return `'${metaData.id}': {${data}\n }`;
return result;
}, {} as any);
return fs.readFileSync(require.resolve('./example-module.template'), 'utf8')
.replace('${exampleImports}', exampleImports)
.replace('${exampleComponents}', `{\n ${exampleComponents.join(',\n ')}}`)
.replace('${exampleList}', `[${exampleList}]`);
.replace('${exampleComponents}', JSON.stringify(exampleComponents))
.replace('${exampleList}', `[${exampleList}]`)
.replace(new RegExp(`"${quotePlaceholder}|${quotePlaceholder}"`, 'g'), '');
}
/** Converts a given camel-cased string to a dash-cased string. */