skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unnecessary information in code_reviews (#10762)

Browse Source
This commit is contained in:
Rafael Santana
2018-04-26 02:05:11 -03:00
committed by Andrew Seguin
parent 5172ca51df
commit 05207e1201
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CODE_REVIEWS.md
+2 -3
View File
@@ -3,12 +3,11 @@
* Before any coding begins on new, large, or breaking work, a design discussion should take place.
* All code changes require a review and approval.
* All behaviors should be covered by unit tests in the same PR.
* Large changes should be accompanied by corresponding e2e tests in the same PR.
* Large changes should be accompanied by corresponding e2e tests in the same PR.
* Authors should attempt to keep PRs to 200 - 300 line changes.
## Workflow
1. The code author sends a PR for review. This request should include:
* A mention of the intended reviewer(s) (e.g., `@jelbourn`)
* A high-level description of the change being made.
* Links to any relevant issues.
* Screenshots (for visual changes or new additions)