skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: prevent alpha/beta/rc publishing to latest tag (#9711)

Browse Source 
* No longer allows publishing versions that include "beta" / "alpha" / "rc" to the "latest" tag on NPM. This safeguard can be still removed temporarily, if there is a real need to publish a beta in the latest tag.

Closes #9699.
This commit is contained in:
Paul Gschwendtner
2018-02-03 01:06:28 +01:00
committed by tinayuangao
parent 95ffe371b1
commit 01f35ab1da
1 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/gulp/tasks/publish.ts
+18 -10
View File
@@ -42,22 +42,30 @@ task(':publish:whoami', execTask('npm', ['whoami'], {
task(':publish:logout', execTask('npm', ['logout']));
task(':publish', async () => {
const label = argv['tag'];
const tag = argv['tag'];
const version = buildConfig.projectVersion;
const currentDir = process.cwd();
console.log('');
if (!label) {
console.log(grey('> You can use a label with --tag=labelName.\n'));
console.log(green(`Publishing version "${version}" using the latest tag...`));
if (!tag) {
console.log(grey('> You can specify the tag by passing --tag=labelName.\n'));
console.log(green(`Publishing version "${version}" to the latest tag...`));
} else {
console.log(yellow(`Publishing version "${version}" using the ${label} tag...`));
console.log(yellow(`Publishing version "${version}" to the ${tag} tag...`));
}
console.log('');
if (version.match(/(alpha|beta|rc)/) && (!tag || tag === 'latest')) {
console.log(red(`Publishing ${version} to the "latest" tag is not allowed.`));
console.log(red(`Alpha, Beta or RC versions shouldn't be published to "latest".`));
console.log();
return;
}
if (releasePackages.length > 1) {
console.warn(red('Warning: Multiple packages will be released if proceeding.'));
console.warn(red('Warning: Packages to be released: ', releasePackages.join(', ')));
console.warn(red('Warning: Packages to be released:', releasePackages.join(', ')));
console.log();
}
@@ -67,13 +75,13 @@ task(':publish', async () => {
// Iterate over every declared release package and publish it on NPM.
for (const packageName of releasePackages) {
await _execNpmPublish(label, packageName);
await _execNpmPublish(tag, packageName);
}
process.chdir(currentDir);
});
function _execNpmPublish(label: string, packageName: string): Promise<{}> | undefined {
function _execNpmPublish(tag: string, packageName: string): Promise<{}> | undefined {
const packageDir = join(buildConfig.outputDir, 'releases', packageName);
if (!statSync(packageDir).isDirectory()) {
@@ -94,8 +102,8 @@ function _execNpmPublish(label: string, packageName: string): Promise<{}> | unde
const command = 'npm';
const args = ['publish', '--access', 'public'];
if (label) {
args.push('--tag', label);
if (tag) {
args.push('--tag', tag);
}
return new Promise((resolve, reject) => {