zlei6/openserp
1
0
Fork 0
mirror of https://github.com/karust/openserp.git synced 2026-08-05 16:53:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add URL builder edge-case tests and server endpoint coverage

Browse Source
This commit is contained in:
Rustem Kamalov
2026-04-15 02:50:52 +03:00
parent 3af8612ce5
commit e5e0c96303
5 changed files with 845 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

192
bing/bing_test.go
View File

@@ -2,69 +2,183 @@ package bing
import (
"net/url"
"strings"
"testing"
"github.com/karust/openserp/core"
)
func TestBuildImageURL(t *testing.T) {
func TestBuildURL(t *testing.T) {
tests := []struct {
name string
query core.Query
wantErr bool
wantCont string
name string
query core.Query
wantErr bool
check func(*testing.T, url.Values, string)
}{
{
name: "basic image query",
query: core.Query{Text: "test"},
wantErr: false,
wantCont: "q=test",
name: "combined params with unicode and start zero",
query: core.Query{
Text: "golang тест",
Site: "example.com",
Filetype: "pdf",
DateInterval: "20240101..20240131",
LangCode: "RU",
Limit: 30,
Start: 0,
},
check: func(t *testing.T, params url.Values, host string) {
t.Helper()
if host != "www.bing.com" {
t.Fatalf("unexpected host: %s", host)
}
if got := params.Get("q"); got != "golang тест site:example.com filetype:pdf after:2024-01-01 before:2024-01-31" {
t.Fatalf("unexpected q value: %q", got)
}
if got := params.Get("pq"); got != params.Get("q") {
t.Fatalf("pq should match q, got %q vs %q", got, params.Get("q"))
}
if got := params.Get("setlang"); got != "ru" {
t.Fatalf("unexpected setlang value: %q", got)
}
if got := params.Get("count"); got != "30" {
t.Fatalf("unexpected count value: %q", got)
}
if got := params.Get("first"); got != "" {
t.Fatalf("first should be omitted when Start=0, got %q", got)
}
if got := params.Get("form"); got != "QBLH" {
t.Fatalf("unexpected form value: %q", got)
}
if got := params.Get("qs"); got != "HS" {
t.Fatalf("unexpected qs value: %q", got)
}
if got := params.Get("sp"); got != "-1" {
t.Fatalf("unexpected sp value: %q", got)
}
},
},
{
name: "image query with site",
query: core.Query{Text: "cats", Site: "example.com"},
wantErr: false,
wantCont: "q=cats+site%3Aexample.com",
name: "very large start",
query: core.Query{
Text: "golang",
Start: 2147483647,
Limit: 20,
},
check: func(t *testing.T, params url.Values, _ string) {
t.Helper()
if got := params.Get("first"); got != "2147483648" {
t.Fatalf("unexpected first value: %q", got)
}
if got := params.Get("count"); got != "" {
t.Fatalf("count should be omitted when first is used, got %q", got)
}
},
},
{
name: "image query with filetype",
query: core.Query{Text: "dogs", Filetype: "png"},
wantErr: false,
wantCont: "q=dogs",
name: "negative start returns error",
query: core.Query{
Text: "golang",
Start: -1,
},
wantErr: true,
},
{
name: "empty query",
query: core.Query{Text: ""},
wantErr: true,
wantCont: "",
name: "empty fields return error",
query: core.Query{},
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := BuildURL(tt.query)
if (err != nil) != tt.wantErr {
t.Fatalf("BuildURL() error = %v, wantErr %v", err, tt.wantErr)
}
if tt.wantErr {
return
}
parsed, err := url.Parse(got)
if err != nil {
t.Fatalf("BuildURL() returned invalid URL: %v", err)
}
if tt.check != nil {
tt.check(t, parsed.Query(), parsed.Host)
}
})
}
}
func TestBuildImageURL(t *testing.T) {
tests := []struct {
name string
query core.Query
wantErr bool
check func(*testing.T, url.Values, string)
}{
{
name: "basic image query",
query: core.Query{Text: "test"},
check: func(t *testing.T, params url.Values, host string) {
t.Helper()
if host != "www.bing.com" {
t.Fatalf("unexpected host: %s", host)
}
if got := params.Get("q"); got != "test" {
t.Fatalf("unexpected q value: %q", got)
}
},
},
{
name: "combined params with unicode",
query: core.Query{
Text: "коты",
Site: "example.com",
Filetype: "png",
LangCode: "EN",
},
check: func(t *testing.T, params url.Values, _ string) {
t.Helper()
if got := params.Get("q"); got != "коты site:example.com" {
t.Fatalf("unexpected q value: %q", got)
}
if got := params.Get("setlang"); got != "en" {
t.Fatalf("unexpected setlang value: %q", got)
}
if got := params.Get("form"); got != "HDRSC2" {
t.Fatalf("unexpected form value: %q", got)
}
if got := params.Get("first"); got != "1" {
t.Fatalf("unexpected first value: %q", got)
}
if got := params.Get("scenario"); got != "ImageBasicHover" {
t.Fatalf("unexpected scenario value: %q", got)
}
},
},
{
name: "empty fields return error",
query: core.Query{},
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := BuildImageURL(tt.query)
if (err != nil) != tt.wantErr {
t.Errorf("BuildImageURL() error = %v, wantErr %v", err, tt.wantErr)
t.Fatalf("BuildImageURL() error = %v, wantErr %v", err, tt.wantErr)
}
if tt.wantErr {
return
}
if !tt.wantErr && got != "" {
if !strings.Contains(got, tt.wantCont) {
t.Errorf("BuildImageURL() = %v, should contain %v", got, tt.wantCont)
}
// Test that URL is valid
_, err := url.Parse(got)
if err != nil {
t.Errorf("BuildImageURL() returned invalid URL: %v", err)
}
// Should be a Bing images URL
if !strings.Contains(got, "bing.com/images/search") {
t.Errorf("BuildImageURL() should return Bing images URL, got: %v", got)
}
parsed, err := url.Parse(got)
if err != nil {
t.Fatalf("BuildImageURL() returned invalid URL: %v", err)
}
if tt.check != nil {
tt.check(t, parsed.Query(), parsed.Host)
}
})
}