zlei6/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2026-05-11 00:40:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(zrpc): fix slow threshold priority in stat interceptor (#5310)

Browse Source 
Co-authored-by: qiuwenhao <qiushaotest@qq.com>
This commit is contained in:
Qiu shao
2025-12-23 22:45:33 +08:00
committed by GitHub
parent 35ba024103
commit f29c8612e8
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zrpc/internal/serverinterceptors/statinterceptor.go
View File

@@ -63,8 +63,12 @@ func UnaryStatInterceptor(metrics *stat.Metrics, conf StatConf) grpc.UnaryServer
} }
func isSlow(duration, durationThreshold time.Duration) bool { func isSlow(duration, durationThreshold time.Duration) bool {
return duration > slowThreshold.Load() || // Prioritize explicit config over global setting
(durationThreshold > 0 && duration > durationThreshold) if durationThreshold > 0 {
return duration > durationThreshold
}
return duration > slowThreshold.Load()
} }
func logDuration(ctx context.Context, method string, req any, duration time.Duration, func logDuration(ctx context.Context, method string, req any, duration time.Duration,

9
zrpc/internal/serverinterceptors/statinterceptor_test.go
View File

@@ -252,6 +252,15 @@ func Test_isSlow(t *testing.T) {
SetSlowThreshold(time.Millisecond * 100) SetSlowThreshold(time.Millisecond * 100)
}, },
}, },
{
"config_priority_fix",
args{
duration: time.Millisecond * 600,
staticSlowThreshold: time.Millisecond * 1000,
},
false,
nil,
},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {