From f0a3d213dcbebaaccaeaaf0664e5123521071c49 Mon Sep 17 00:00:00 2001 From: me-cs <49519858+me-cs@users.noreply.github.com> Date: Thu, 14 Aug 2025 23:33:25 +0800 Subject: [PATCH] update:simplify slice lookup by using slices.Contains() (#5084) Co-authored-by: Kevin Wan Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- core/mapping/marshaler.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/core/mapping/marshaler.go b/core/mapping/marshaler.go index 797cbdf26..b2c89b7bf 100644 --- a/core/mapping/marshaler.go +++ b/core/mapping/marshaler.go @@ -3,6 +3,7 @@ package mapping import ( "fmt" "reflect" + "slices" "strings" ) @@ -152,18 +153,10 @@ func validateOptional(field reflect.StructField, value reflect.Value) error { } func validateOptions(value reflect.Value, opt *fieldOptions) error { - var found bool val := fmt.Sprint(value.Interface()) - for i := range opt.Options { - if opt.Options[i] == val { - found = true - break - } - } - if !found { + if !slices.Contains(opt.Options, val) { return fmt.Errorf("field %q not in options", val) } - return nil }