fix:issue-5110 (#5113)

This commit is contained in:
guonaihong
2025-08-31 17:17:34 +08:00
committed by GitHub
parent de42f27e03
commit 870e8352c1
2 changed files with 109 additions and 14 deletions

View File

@@ -40,8 +40,8 @@ func TestEventHandler_OnReceiveTrailers(t *testing.T) {
},
expectedStatus: codes.OK,
expectedHeader: map[string][]string{
"X-Custom-Header": {"value1", "value2"},
"X-Another-Header": {"single-value"},
"Grpc-Trailer-X-Custom-Header": {"value1", "value2"},
"Grpc-Trailer-X-Another-Header": {"single-value"},
},
},
{
@@ -100,9 +100,9 @@ func TestEventHandler_OnReceiveHeaders(t *testing.T) {
"x-another-header": []string{"single-value"},
},
expectedHeader: map[string][]string{
"Content-Type": {"application/json"},
"X-Custom-Header": {"value1", "value2"},
"X-Another-Header": {"single-value"},
"Grpc-Metadata-Content-Type": {"application/json"},
"Grpc-Metadata-X-Custom-Header": {"value1", "value2"},
"Grpc-Metadata-X-Another-Header": {"single-value"},
},
},
{
@@ -158,7 +158,81 @@ func TestEventHandler_OnReceiveHeaders_MultipleValues(t *testing.T) {
"x-header-2": []string{"value3"},
})
// Check that headers are accumulated (not overwritten)
assert.Equal(t, []string{"value1", "value2"}, recorder.Header()["X-Header-1"])
assert.Equal(t, []string{"value3"}, recorder.Header()["X-Header-2"])
// Check that headers are accumulated (not overwritten) with proper prefix
assert.Equal(t, []string{"value1", "value2"}, recorder.Header()["Grpc-Metadata-X-Header-1"])
assert.Equal(t, []string{"value3"}, recorder.Header()["Grpc-Metadata-X-Header-2"])
}
func TestEventHandler_OnReceiveHeaders_MetadataPrefix(t *testing.T) {
tests := []struct {
name string
metadata metadata.MD
expectedHeader map[string][]string
}{
{
name: "all metadata headers should be prefixed with Grpc-Metadata-",
metadata: metadata.MD{
"content-type": []string{"application/grpc"},
"x-custom-header": []string{"value1"},
"authorization": []string{"Bearer token"},
},
expectedHeader: map[string][]string{
"Grpc-Metadata-Content-Type": {"application/grpc"},
"Grpc-Metadata-X-Custom-Header": {"value1"},
"Grpc-Metadata-Authorization": {"Bearer token"},
},
},
{
name: "mixed case headers should be prefixed",
metadata: metadata.MD{
"Content-Type": []string{"APPLICATION/JSON"},
"X-Custom-Header": []string{"value1"},
},
expectedHeader: map[string][]string{
"Grpc-Metadata-Content-Type": {"APPLICATION/JSON"},
"Grpc-Metadata-X-Custom-Header": {"value1"},
},
},
{
name: "multiple values for same header",
metadata: metadata.MD{
"x-multi-header": []string{"value1", "value2", "value3"},
},
expectedHeader: map[string][]string{
"Grpc-Metadata-X-Multi-Header": {"value1", "value2", "value3"},
},
},
{
name: "empty metadata",
metadata: metadata.MD{},
expectedHeader: map[string][]string{},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
recorder := httptest.NewRecorder()
h := NewEventHandler(recorder, nil)
h.OnReceiveHeaders(tt.metadata)
// Check that headers are set correctly
for key, expectedValues := range tt.expectedHeader {
actualValues := recorder.Header()[key]
assert.Equal(t, expectedValues, actualValues, "Header %s should match", key)
}
// Ensure no unexpected headers are set
for actualKey := range recorder.Header() {
found := false
for expectedKey := range tt.expectedHeader {
if actualKey == expectedKey {
found = true
break
}
}
assert.True(t, found, "Unexpected header found: %s", actualKey)
}
})
}
}