zlei6/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2026-05-14 18:30:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: refactor unit tests (#5041)

Browse Source
This commit is contained in:
Kevin Wan
2025-07-31 20:10:45 +08:00
committed by GitHub
parent 93c11a7eb7
commit 82a937d517
2 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rest/httpx/responses.go
View File

@@ -177,8 +177,8 @@ func doMarshalJson(v any) ([]byte, error) {
// why not use json.Marshal? https://github.com/golang/go/issues/28453 // why not use json.Marshal? https://github.com/golang/go/issues/28453
// it change the behavior of json.Marshal, like & -> \u0026, < -> \u003c, > -> \u003e // it change the behavior of json.Marshal, like & -> \u0026, < -> \u003c, > -> \u003e
// which is not what we want in logic response // which is not what we want in logic response
buf := &bytes.Buffer{} var buf bytes.Buffer
enc := json.NewEncoder(buf) enc := json.NewEncoder(&buf)
enc.SetEscapeHTML(false) enc.SetEscapeHTML(false)
if err := enc.Encode(v); err != nil { if err := enc.Encode(v); err != nil {
return nil, err return nil, err

23
rest/httpx/responses_test.go
View File

@@ -12,10 +12,9 @@ import (
"testing" "testing"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/zeromicro/go-zero/core/logx"
"google.golang.org/grpc/codes" "google.golang.org/grpc/codes"
"google.golang.org/grpc/status" "google.golang.org/grpc/status"
"github.com/zeromicro/go-zero/core/logx"
) )
type message struct { type message struct {
@@ -449,6 +448,7 @@ func Test_doMarshalJson(t *testing.T) {
type args struct { type args struct {
v any v any
} }
tests := []struct { tests := []struct {
name string name string
args args args args
@@ -532,15 +532,16 @@ func Test_doMarshalJson(t *testing.T) {
wantErr: assert.NoError, wantErr: assert.NoError,
}, },
} }
for _, tt := range tests { for _, tt := range tests {
t.Run( tt := tt
tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
got, err := doMarshalJson(tt.args.v) got, err := doMarshalJson(tt.args.v)
if !tt.wantErr(t, err, fmt.Sprintf("doMarshalJson(%v)", tt.args.v)) { if !tt.wantErr(t, err, fmt.Sprintf("doMarshalJson(%v)", tt.args.v)) {
return return
} }
assert.Equalf(t, string(tt.want), string(got), "doMarshalJson(%v)", tt.args.v)
}, assert.Equalf(t, string(tt.want), string(got), "doMarshalJson(%v)", tt.args.v)
) })
} }
} }