zlei6/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2026-05-07 15:10:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unused code (#5238)

Browse Source
This commit is contained in:
Kevin Wan
2025-10-12 11:55:57 +08:00
committed by GitHub
parent bea9d150a1
commit 80c320b46e
2 changed files with 18 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/goctl/util/string.go
View File

@@ -2,7 +2,6 @@ package util
import ( import (
"slices" "slices"
"strconv"
"strings" "strings"
"github.com/zeromicro/go-zero/tools/goctl/util/console" "github.com/zeromicro/go-zero/tools/goctl/util/console"
@@ -130,14 +129,3 @@ func FieldsAndTrimSpace(s string, f func(r rune) bool) []string {
} }
return resp return resp
} }
//Deprecated: This function implementation is incomplete and does not properly handle exceptional input cases.
//We strongly recommend using the standard library's strconv.Unquote function instead,
//which provides robust error handling and comprehensive support for various input formats.
func Unquote(s string) string {
ns, err := strconv.Unquote(s)
if err != nil {
return ""
}
return ns
}

53
tools/goctl/util/string_test.go
View File

@@ -76,40 +76,40 @@ func TestEscapeGoKeyword(t *testing.T) {
func TestFieldsAndTrimSpace(t *testing.T) { func TestFieldsAndTrimSpace(t *testing.T) {
testCases := []struct { testCases := []struct {
name string name string
input string input string
delimiter func(r rune) bool delimiter func(r rune) bool
expected []string expected []string
}{ }{
{ {
name: "Comma-separated values", name: "Comma-separated values",
input: "a, b, c", input: "a, b, c",
delimiter: func(r rune) bool { return r == ',' }, delimiter: func(r rune) bool { return r == ',' },
expected: []string{"a", " b", " c"}, expected: []string{"a", " b", " c"},
}, },
{ {
name: "Space-separated values", name: "Space-separated values",
input: "a b c", input: "a b c",
delimiter: unicode.IsSpace, delimiter: unicode.IsSpace,
expected: []string{"a", "b", "c"}, expected: []string{"a", "b", "c"},
}, },
{ {
name: "Mixed whitespace", name: "Mixed whitespace",
input: "a\tb\nc", input: "a\tb\nc",
delimiter: unicode.IsSpace, delimiter: unicode.IsSpace,
expected: []string{"a", "b", "c"}, expected: []string{"a", "b", "c"},
}, },
{ {
name: "Empty input", name: "Empty input",
input: "", input: "",
delimiter: unicode.IsSpace, delimiter: unicode.IsSpace,
expected: []string(nil), expected: []string(nil),
}, },
{ {
name: "Trailing and leading spaces", name: "Trailing and leading spaces",
input: " a , b , c ", input: " a , b , c ",
delimiter: func(r rune) bool { return r == ',' }, delimiter: func(r rune) bool { return r == ',' },
expected: []string{" a ", " b ", " c "}, expected: []string{" a ", " b ", " c "},
}, },
} }
@@ -120,20 +120,3 @@ func TestFieldsAndTrimSpace(t *testing.T) {
}) })
} }
} }
func TestUnquote(t *testing.T) {
testCases := []struct {
input string
expected string
}{
{input: `"hello"`, expected: `hello`},
{input: "`world`", expected: `world`},
{input: `"foo'bar"`, expected: `foo'bar`},
{input: "", expected: ""},
}
for _, tc := range testCases {
result := Unquote(tc.input)
assert.Equal(t, tc.expected, result)
}
}