zlei6/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2026-05-13 18:00:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: should not ignore slowThreshold (#4655)

Browse Source
This commit is contained in:
Kevin Wan
2025-02-14 23:14:57 +08:00
committed by GitHub
parent 6a0672b801
commit 790302b486
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
zrpc/internal/serverinterceptors/statinterceptor.go
View File

@@ -25,7 +25,7 @@ var (
// StatConf defines the static configuration for stat interceptor. // StatConf defines the static configuration for stat interceptor.
type StatConf struct { type StatConf struct {
SlowThreshold time.Duration `json:",optional"` SlowThreshold time.Duration `json:",default=500ms"`
IgnoreContentMethods []string `json:",optional"` IgnoreContentMethods []string `json:",optional"`
} }
@@ -63,7 +63,8 @@ func UnaryStatInterceptor(metrics *stat.Metrics, conf StatConf) grpc.UnaryServer
} }
func isSlow(duration, durationThreshold time.Duration) bool { func isSlow(duration, durationThreshold time.Duration) bool {
return durationThreshold > 0 && duration > durationThreshold return duration > slowThreshold.Load() ||
(durationThreshold > 0 && duration > durationThreshold)
} }
func logDuration(ctx context.Context, method string, req any, duration time.Duration, func logDuration(ctx context.Context, method string, req any, duration time.Duration,

5
zrpc/internal/serverinterceptors/statinterceptor_test.go
View File

@@ -229,7 +229,7 @@ func Test_isSlow(t *testing.T) {
args{ args{
duration: time.Millisecond * 501, duration: time.Millisecond * 501,
}, },
false, true,
nil, nil,
}, },
{ {
@@ -251,7 +251,8 @@ func Test_isSlow(t *testing.T) {
t.Cleanup(func() { t.Cleanup(func() {
slowThreshold = syncx.ForAtomicDuration(defaultSlowThreshold) slowThreshold = syncx.ForAtomicDuration(defaultSlowThreshold)
}) })
assert.Equalf(t, tt.want, isSlow(tt.args.duration, tt.args.staticSlowThreshold), "isSlow(%v, %v)", tt.args.duration, tt.args.staticSlowThreshold) assert.Equalf(t, tt.want, isSlow(tt.args.duration, tt.args.staticSlowThreshold),
"isSlow(%v, %v)", tt.args.duration, tt.args.staticSlowThreshold)
}) })
} }
} }