zlei6/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2026-05-13 18:00:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: SlowThreshold configuration not taking effect (#4654)

Browse Source
This commit is contained in:
Nanosk07
2025-02-14 22:56:25 +08:00
committed by GitHub
parent 560c61612c
commit 6a0672b801
2 changed files with 26 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
zrpc/internal/serverinterceptors/statinterceptor.go
View File

@@ -25,7 +25,7 @@ var (
// StatConf defines the static configuration for stat interceptor.
type StatConf struct {
SlowThreshold time.Duration `json:",default=500ms"`
SlowThreshold time.Duration `json:",optional"`
IgnoreContentMethods []string `json:",optional"`
}
@@ -63,8 +63,7 @@ func UnaryStatInterceptor(metrics *stat.Metrics, conf StatConf) grpc.UnaryServer
}
func isSlow(duration, durationThreshold time.Duration) bool {
return duration > slowThreshold.Load() ||
(durationThreshold > 0 && duration > durationThreshold)
return durationThreshold > 0 && duration > durationThreshold
}
func logDuration(ctx context.Context, method string, req any, duration time.Duration,
@@ -84,7 +83,7 @@ func logDuration(ctx context.Context, method string, req any, duration time.Dura
content, err := json.Marshal(req)
if err != nil {
logx.WithContext(ctx).Errorf("%s - %s", addr, err.Error())
} else if duration > slowThreshold.Load() {
} else if isSlow(duration, durationThreshold) {
logger.Slowf("[RPC] slowcall - %s - %s - %s", addr, method, string(content))
} else {
logger.Infof("%s - %s - %s", addr, method, string(content))