zlei6/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2026-05-14 18:30:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: coding style (#4037)

Browse Source
This commit is contained in:
Kevin Wan
2024-04-03 22:55:52 +08:00
committed by GitHub
parent 968727412d
commit 08563482e5
3 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/devserver/config.go
View File

@@ -9,5 +9,5 @@ type Config struct {
HealthPath string `json:",default=/healthz"` HealthPath string `json:",default=/healthz"`
EnableMetrics bool `json:",default=true"` EnableMetrics bool `json:",default=true"`
EnablePprof bool `json:",default=true"` EnablePprof bool `json:",default=true"`
HealthRespInfo string `json:",default=OK"` HealthResponse string `json:",default=OK"`
} }

8
internal/devserver/server.go
View File

@@ -16,8 +16,8 @@ import (
var once sync.Once var once sync.Once
// Server is inner http server, expose some useful observability information of app. // Server is an inner http server, expose some useful observability information of app.
// For example health check, metrics and pprof. // For example, health check, metrics and pprof.
type Server struct { type Server struct {
config Config config Config
server *http.ServeMux server *http.ServeMux
@@ -37,8 +37,9 @@ func (s *Server) addRoutes(c Config) {
s.handleFunc("/", func(w http.ResponseWriter, _ *http.Request) { s.handleFunc("/", func(w http.ResponseWriter, _ *http.Request) {
_ = json.NewEncoder(w).Encode(s.routes) _ = json.NewEncoder(w).Encode(s.routes)
}) })
// health // health
s.handleFunc(s.config.HealthPath, health.CreateHttpHandler(c.HealthRespInfo)) s.handleFunc(s.config.HealthPath, health.CreateHttpHandler(c.HealthResponse))
// metrics // metrics
if s.config.EnableMetrics { if s.config.EnableMetrics {
@@ -46,6 +47,7 @@ func (s *Server) addRoutes(c Config) {
prometheus.Enable() prometheus.Enable()
s.handleFunc(s.config.MetricsPath, promhttp.Handler().ServeHTTP) s.handleFunc(s.config.MetricsPath, promhttp.Handler().ServeHTTP)
} }
// pprof // pprof
if s.config.EnablePprof { if s.config.EnablePprof {
s.handleFunc("/debug/pprof/", pprof.Index) s.handleFunc("/debug/pprof/", pprof.Index)

6
internal/health/health.go
View File

@@ -13,7 +13,7 @@ import (
var defaultHealthManager = newComboHealthManager() var defaultHealthManager = newComboHealthManager()
type ( type (
// Probe represents readiness status of given component. // Probe represents readiness status of a given component.
Probe interface { Probe interface {
// MarkReady sets a ready state for the endpoint handlers. // MarkReady sets a ready state for the endpoint handlers.
MarkReady() MarkReady()
@@ -44,10 +44,10 @@ func AddProbe(probe Probe) {
} }
// CreateHttpHandler create health http handler base on given probe. // CreateHttpHandler create health http handler base on given probe.
func CreateHttpHandler(healthRespInfo string) http.HandlerFunc { func CreateHttpHandler(healthResponse string) http.HandlerFunc {
return func(w http.ResponseWriter, _ *http.Request) { return func(w http.ResponseWriter, _ *http.Request) {
if defaultHealthManager.IsReady() { if defaultHealthManager.IsReady() {
_, _ = w.Write([]byte(healthRespInfo)) _, _ = w.Write([]byte(healthResponse))
} else { } else {
http.Error(w, "Service Unavailable\n"+defaultHealthManager.verboseInfo(), http.Error(w, "Service Unavailable\n"+defaultHealthManager.verboseInfo(),
http.StatusServiceUnavailable) http.StatusServiceUnavailable)