fix: recover bounded defects from PR backlog

tests/lib/test_checkpoint_prerequisites.py

@@ -0,0 +1,152 @@
+import json
+
+import pytest
+from tests.contracts.test_phase0_contracts import sample_artifact
+
+from lib.checkpoint import (
+    CheckpointValidationError,
+    init_project,
+    write_checkpoint,
+)
+
+
+def _script_artifact() -> dict:
+    return {
+        "version": "1.0",
+        "title": "Smoke",
+        "total_duration_seconds": 1,
+        "sections": [
+            {
+                "id": "s1",
+                "text": "One second.",
+                "start_seconds": 0,
+                "end_seconds": 1,
+            }
+        ],
+    }
+
+
+def test_later_stage_cannot_skip_a_missing_predecessor(tmp_path) -> None:
+    init_project(
+        "run",
+        title="Run",
+        pipeline_type="framework-smoke",
+        pipeline_dir=tmp_path,
+    )
+
+    with pytest.raises(CheckpointValidationError, match="PREREQUISITE VIOLATION"):
+        write_checkpoint(
+            tmp_path,
+            "run",
+            "script",
+            "completed",
+            {"script": _script_artifact()},
+            pipeline_type="framework-smoke",
+            human_approved=True,
+        )
+
+
+def test_later_stage_rejects_unapproved_gated_predecessor(tmp_path) -> None:
+    project_dir = init_project(
+        "run",
+        title="Run",
+        pipeline_type="framework-smoke",
+        pipeline_dir=tmp_path,
+    )
+    predecessor_path = write_checkpoint(
+        tmp_path,
+        "run",
+        "research",
+        "awaiting_human",
+        {"research_brief": sample_artifact("research_brief")},
+        pipeline_type="framework-smoke",
+    )
+    predecessor = json.loads(predecessor_path.read_text(encoding="utf-8"))
+    predecessor["status"] = "completed"
+    predecessor["human_approved"] = False
+    predecessor_path.write_text(json.dumps(predecessor), encoding="utf-8")
+
+    with pytest.raises(CheckpointValidationError, match="completed without required approval"):
+        write_checkpoint(
+            tmp_path,
+            "run",
+            "script",
+            "completed",
+            {"script": _script_artifact()},
+            pipeline_type="framework-smoke",
+            human_approved=True,
+        )
+
+
+def test_malformed_predecessor_cannot_forge_completion(tmp_path) -> None:
+    project_dir = init_project(
+        "run",
+        title="Run",
+        pipeline_type="framework-smoke",
+        pipeline_dir=tmp_path,
+    )
+    (project_dir / "checkpoint_research.json").write_text(
+        json.dumps({"status": "completed", "human_approved": True}),
+        encoding="utf-8",
+    )
+
+    with pytest.raises(CheckpointValidationError, match="incomplete or missing"):
+        write_checkpoint(
+            tmp_path,
+            "run",
+            "script",
+            "completed",
+            {"script": _script_artifact()},
+            pipeline_type="framework-smoke",
+            human_approved=True,
+        )
+
+
+def test_in_progress_heartbeat_is_not_blocked_by_prerequisites(tmp_path) -> None:
+    init_project(
+        "run",
+        title="Run",
+        pipeline_type="framework-smoke",
+        pipeline_dir=tmp_path,
+    )
+
+    path = write_checkpoint(
+        tmp_path,
+        "run",
+        "script",
+        "in_progress",
+        {},
+        pipeline_type="framework-smoke",
+    )
+
+    assert path.exists()
+
+
+def test_unknown_style_playbook_fails_before_project_creation(tmp_path) -> None:
+    with pytest.raises(CheckpointValidationError, match="style_playbook"):
+        init_project(
+            "run",
+            title="Run",
+            pipeline_type="framework-smoke",
+            pipeline_dir=tmp_path,
+            style_playbook="does-not-exist",
+        )
+
+    assert not (tmp_path / "run").exists()
+
+
+def test_marker_derived_unknown_playbook_blocks_later_writes(tmp_path) -> None:
+    project_dir = tmp_path / "run"
+    project_dir.mkdir()
+    (project_dir / "project.json").write_text(
+        json.dumps({
+            "version": "1.0",
+            "project_id": "run",
+            "pipeline_type": "framework-smoke",
+            "style_playbook": "does-not-exist",
+        }),
+        encoding="utf-8",
+    )
+
+    with pytest.raises(CheckpointValidationError, match="style_playbook"):
+        write_checkpoint(tmp_path, "run", "research", "in_progress", {})

tests/lib/test_clip_embedder_compat.py

@@ -0,0 +1,26 @@
+from lib.clip_embedder import _as_feature_tensor
+
+
+class _Tensor:
+    pass
+
+
+class _ModelOutput:
+    def __init__(self, pooler_output):
+        self.pooler_output = pooler_output
+        self.last_hidden_state = object()
+
+
+def test_transformers_4_tensor_passes_through() -> None:
+    tensor = _Tensor()
+    assert _as_feature_tensor(tensor) is tensor
+
+
+def test_transformers_5_output_unwraps_projected_pooler_output() -> None:
+    tensor = _Tensor()
+    assert _as_feature_tensor(_ModelOutput(tensor)) is tensor
+
+
+def test_missing_pooler_output_does_not_replace_features_with_none() -> None:
+    output = _ModelOutput(None)
+    assert _as_feature_tensor(output) is output