mirror of
https://github.com/vercel/workflow.git
synced 2026-09-14 19:59:43 +08:00
chore(changeset): trim the route-groups changeset to one line (#4143)
The changeset body is copied verbatim into the changelog, where the rationale paragraphs from #4070 are noise. Keep the line that says what changed and where it matters; the reasoning is already in the commit, the PR and issue #3991. This was reviewed on #4070 and fixed on #4140, a CI mirror of that PR. #4070 is the one that merged and #4140 was closed, so the fix never landed. The changeset is still unconsumed on `main`, so correcting the file is enough — the open release PR regenerates from it and no CHANGELOG.md has been written yet. Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> Co-authored-by: Pranay Prakash <1797812+pranaygp@users.noreply.github.com>
This commit is contained in:
@@ -2,15 +2,4 @@
|
|||||||
"@workflow/core": patch
|
"@workflow/core": patch
|
||||||
---
|
---
|
||||||
|
|
||||||
Allow parentheses and square brackets in workflow names
|
Allow parentheses and square brackets in workflow names, so workflows can live in Next.js route groups (`app/(dashboard)/…`) and dynamic segments (`app/[teamId]/…`).
|
||||||
|
|
||||||
A workflow name is derived from the module path it is defined in, so Next.js App
|
|
||||||
Router conventions end up in the name verbatim. `SAFE_WORKFLOW_NAME_PATTERN` did
|
|
||||||
not permit `(`, `)`, `[` or `]`, so any workflow inside a route group
|
|
||||||
(`app/(dashboard)/…`) or a dynamic segment (`app/[teamId]/…`, `app/[...slug]/…`)
|
|
||||||
threw `Invalid workflow name` before it could be enqueued, with no way to
|
|
||||||
override the generated name.
|
|
||||||
|
|
||||||
These characters are inert in the queue name the pattern guards: `ValidQueueName`
|
|
||||||
already accepts any suffix after its prefix, and the name is never interpolated
|
|
||||||
into a URL or a SQL identifier.
|
|
||||||
|
|||||||
Reference in New Issue
Block a user