skills/trailofbits__skills - trailofbits__skills - GetSkill.work

skills/trailofbits__skills

mirror of https://github.com/trailofbits/skills.git synced 2026-09-14 14:28:48 +08:00

Files

T

1 line

6 B

Plaintext

Raw Permalink Normal View History

use PATH shim override technique instead of hooking every pre tool usage (#89) * use PATH shim override technique instead of hooking every pre tool usage * remove unecessary check * fix: resolve code review findings for PR #89 P1 fixes: - setup-shims.sh: Add CLAUDE_ENV_FILE guard to prevent opaque 'unbound variable' crash when env var is unset (matches gh-cli plugin pattern) P2 fixes: - setup-shims.sh: Guard shims_dir resolution failure to prevent empty PATH prefix on partial installs - shims/uv: Fix shfmt formatting (here-string spacing) - shims/uv: Resolve PATH entries before comparison to prevent exec loop with symlinked/unnormalized paths - shims/uv: Use ${PATH:-} to handle unset PATH defensively - setup-shims.bats: Add test for unset CLAUDE_ENV_FILE - uv-shim.bats: Add test for 'real uv not found' error path P3 dismissed: - CI linting gap for extensionless shim scripts: accepted as-is since shims must masquerade as real binaries (no .sh extension); manual review covers these files - Unset PATH in uv shim: addressed by ${PATH:-} fix above All 27 bats tests pass. shellcheck and shfmt clean. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Dan Guido <dan@trailofbits.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

2026-02-12 22:16:40 -05:00

python