skills/playableintelligence__game-creator
1
0
Fork 0
mirror of https://github.com/PlayableIntelligence/game-creator.git synced 2026-09-19 07:34:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: address CodeRabbit PR #7 feedback

Browse Source 
- Menu.js: fix redundant ternary — properly convert hex constant to CSS color
- EventBus.js: spread-copy listener array before iterating to prevent
  mutation issues when listeners call off() during emit
- gigachad.meta.json: remove expired Meshy AI signed URLs, keep task IDs
  for re-generation
- qa-game SKILL.md: remove "accessibility" from description since no
  axe tests are generated

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
rshtirmer
2026-03-10 13:59:13 -04:00
parent 134c3b0e55
commit 1bd5b21d83
4 changed files with 4 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/gigachad-sim/public/assets/models/gigachad.meta.json
+1 -20
View File
@@ -5,26 +5,7 @@
"inputTaskId": "019cafda-de4e-7e3d-a713-c552e085d4e5",
"rigTaskId": "019cafdd-e64e-728c-a6c1-87a65fd9ac8d",
"heightMeters": 1.7,
"result": {
"rigged_character_fbx_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Character_output.fbx?Expires=1772736429&Signature=BcbWNo1dTEvOssG9W7lOAno9P-JHcWKZ~wq4KwB7GBiLAyelxMtX9OkUCF9iRaUgTWDQFozXimyCoulxSR7OvXTjRIdWa1iSpdzFccTH06f~o~gyN5nCCgoucuaDpwuFADuv6PFUKW1ce0PepGezYIIN1nJZGivG7DPbeMs0XXavy8r9Wgk70GxQJFIq4kVW6JtGXKJGOr-9GLdzyInRx5OGyE66Etmq1VZEW6ZVHIfXo-YSeMA8QsbuDR3ndcVirjKOBZJ3HpjyAW-gbjy0rRGkT6OWU7Lk1nTl6IG1fAF71V~0MtBIKTGPLLaIMI39Acf1UqK7mMZQ36icZMWgfQ__&Key-Pair-Id=KL5I0C8H7HX83",
"rigged_character_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Character_output.glb?Expires=1772736429&Signature=CeiiRVvirEt8YweCKZWkKHjSaRfKzXWr1InpFhOKDrnpV4Ocpp1Ib~~JCsr4t2wn6GO-dphrX5lkfrrQvOJdDA5m8K08cFIDiJQZXviLQSwZv8k5rj6Aqugsdf8dxfAKXlR34tQ8W7iZMWBE89zWjAD0IO7Ab82K7fJzBatFCPcAEQTE2JZqJRHjh-yT5zskhOrU-tYGz9FrgxG5gn0O8eBWNrcuM35i~sEKYeGzP6t9TqjL5vKyOUBIXZs2OvbRs5fFEUOCjJIUJ~pFKFxV71HYAFdqZ1M3GDWLJlIi5ttF8TZ5csC2UFUDfbdufBfkm23VjWA3x7rRCRmje3Rrtw__&Key-Pair-Id=KL5I0C8H7HX83",
"basic_animations": {
"walking_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Walking_withSkin.glb?Expires=1772736429&Signature=Y1OviCerveVsCOF7yBtspcwEF4CvQw3pC8SKKa9dn1WxODZ7OQkcjJUGxl1aLYYQ0OXzp8cd545S-N2s62eW7Zj5Xb3OYkFYI8HIK8Yk-AFPV5dg7565ECcKuyeqQ1KYI2LgqE2nZetgezYuQLYGyys6pZrc64RIkx3SqgR0OFs9B5C9c4-gtyFYN7mJ21qviRG3TEDiIlxYvMsAV~gRuUQR2IXGNhdI3toDamHektrAd9MvfdH5aozEVfrgJqoWt0xUldnUyTkXmBSd-2KuxZRAdzLelx1rgL~yj4J-Np3BxvoL4En2ZCIi7EZCvTLJtxlWlC7~koSB49hEojx-fQ__&Key-Pair-Id=KL5I0C8H7HX83",
"walking_fbx_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Walking_withSkin.fbx?Expires=1772736429&Signature=efMeUNUlLcBUome6p0rKynwseSdp84dHtLvruNuSym7~I3rLM9WPBSTcJjC1dRRS5Un~4KheaLn632awqBEFvbjcG6FnRXAdrgyxYMcgpKAAxoE3bl5ExBwEQVLfuWBsXJf~eK4pPt~hTVGZZ4mD41z6pJJnCT44RdbI9SE-6Am4WMtXKc-WNXDNZTao4BV~Y-cSCqWvFpckvHJGWKdvefxlJcWCC0aFfe-vWL9EJnc~TrlPQ9JIcQjv2haBEbPDKDcfU3h5-Lx2mDlxA0WmJhx6wl8b26Ec8P3Nf6ObcfikRbL51-zqja7LpFgFTZosMqjbP4q9DW5hm7CqW3x7Pw__&Key-Pair-Id=KL5I0C8H7HX83",
"walking_armature_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Walking_withSkin_armature.glb?Expires=1772736429&Signature=c9BTC1NYGYMnAGBq4xmSF9JZ9ng2sM8-4NtJn9g83SrUL-jw9Bh3Drdw5iOVNW50VnvhAZV8nF7dF8a6AgOm53aGqhCpOYxtbZ5SkWk~4otztm5eh-etUHzUmxBKbOmM6DtC1e4BkN5-apPmt2PoKshxKM1BLxGU2qWXXBxPWqxqJZgCoTnhYJXBpSQZzqe~~UyObY6slitRYOgl9L~XT1ClgsLkYEA79aFPR0KFsnPFKA6if7msIJ3W3JXqY~p-K~DHViLumMy1glU3TFzbNKln3R3WiGvAprkstgEA9Dn9fp-opqv46TRBCq3dgmCuKcSLxfrZtEoNyhzu~VCHlA__&Key-Pair-Id=KL5I0C8H7HX83",
"running_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Running_withSkin.glb?Expires=1772736429&Signature=LFfspnLk509Ich9CqZ4BKO4V0AwK6kgYj7XZbILY1P~5zkA1HhdUMdL9t6xvr8wYYsNbc92Xqiy0djc~-SzF3MjdWyH7uT6~OdS1vxra82L4P6NoIV2AznMDSuKwcE5RPv3GQ-z6HS2P76VyAZmLd4wMfhnwEksex~m4cBDl03WZp7vHx387JP3PD4WkMOFBEc89vu1HTRuEEkBoBWyIuoKE3814JXIn-ReLj8H56KEUraQoVEK9cSKvwuCJVjYef2thyhw~Mbj7Nh4D0WeTK5bSQALKnnFN9DtMqPzOsSBlDPIvYMmqgVjpHC~3sNK3udSAj~mydrNivZ~DlgazCQ__&Key-Pair-Id=KL5I0C8H7HX83",
"running_fbx_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Running_withSkin.fbx?Expires=1772736429&Signature=r6cUuIj6Xcit9nU0Q1SqnuHRppgU6UkVWIuLifQJYsa~DFU-sJR9UH7GPkhxdqZAtfz74QEAI7~hINRHycpc6ftbFuv787LVBH5KocmRxig4WexmQUpdorCra18DCiWksBsW~vTiU~Wo3ddHKVw~kc1dtrkB-71Ho8IHqZTMoLHT2jIJyChstkGSpgTy4uDIfNEg5l7~RRXJKH05WbtmBuGDtBRDnmjRlPFv3elVlLEUI~gxPdP-dI4CqGzZBfbtabMVBmkTTsbpO-5yIbVIGiA5ToV97SeuhT-EfNCaDTkxGwlKvUjU4xcLWYz6Mwe8TVDNweRMCwP3m0sqYuQmUw__&Key-Pair-Id=KL5I0C8H7HX83",
"running_armature_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Running_withSkin_armature.glb?Expires=1772736429&Signature=YENZiJwk2JtCgkT3QIn89flwebb1NK38oZ7fOX2XItBvNSqzVe5QCqXCuyVfju50hE7PQWYyebMG6~hYBTwX4bj5gmd~JBHmS~YIFR0Q-d1zwk2UaFn6A14GKSxWIUB-KZt3q4TZMnfFXJFhQ3L1IzAiV1O8qcTz6gt7Lr0t0~W3lrDS3Dgu7OKs~kY1V633VHzB9F2pQKmJj1YhuGxnrAa~3OPsuxm49LAENeozHaiEeYLjCQpJVkIP0e~JFauNAfITKhrMzU9d8kJLiMP3-uo4gg-LOKbjZJtf3WpCx9amvH5L~~pDH5zfXEq04dNxGDMY5yxR0RlaFYU2MUPjhw__&Key-Pair-Id=KL5I0C8H7HX83"
}
},
"basicAnimations": {
"walking_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Walking_withSkin.glb?Expires=1772736429&Signature=Y1OviCerveVsCOF7yBtspcwEF4CvQw3pC8SKKa9dn1WxODZ7OQkcjJUGxl1aLYYQ0OXzp8cd545S-N2s62eW7Zj5Xb3OYkFYI8HIK8Yk-AFPV5dg7565ECcKuyeqQ1KYI2LgqE2nZetgezYuQLYGyys6pZrc64RIkx3SqgR0OFs9B5C9c4-gtyFYN7mJ21qviRG3TEDiIlxYvMsAV~gRuUQR2IXGNhdI3toDamHektrAd9MvfdH5aozEVfrgJqoWt0xUldnUyTkXmBSd-2KuxZRAdzLelx1rgL~yj4J-Np3BxvoL4En2ZCIi7EZCvTLJtxlWlC7~koSB49hEojx-fQ__&Key-Pair-Id=KL5I0C8H7HX83",
"walking_fbx_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Walking_withSkin.fbx?Expires=1772736429&Signature=efMeUNUlLcBUome6p0rKynwseSdp84dHtLvruNuSym7~I3rLM9WPBSTcJjC1dRRS5Un~4KheaLn632awqBEFvbjcG6FnRXAdrgyxYMcgpKAAxoE3bl5ExBwEQVLfuWBsXJf~eK4pPt~hTVGZZ4mD41z6pJJnCT44RdbI9SE-6Am4WMtXKc-WNXDNZTao4BV~Y-cSCqWvFpckvHJGWKdvefxlJcWCC0aFfe-vWL9EJnc~TrlPQ9JIcQjv2haBEbPDKDcfU3h5-Lx2mDlxA0WmJhx6wl8b26Ec8P3Nf6ObcfikRbL51-zqja7LpFgFTZosMqjbP4q9DW5hm7CqW3x7Pw__&Key-Pair-Id=KL5I0C8H7HX83",
"walking_armature_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Walking_withSkin_armature.glb?Expires=1772736429&Signature=c9BTC1NYGYMnAGBq4xmSF9JZ9ng2sM8-4NtJn9g83SrUL-jw9Bh3Drdw5iOVNW50VnvhAZV8nF7dF8a6AgOm53aGqhCpOYxtbZ5SkWk~4otztm5eh-etUHzUmxBKbOmM6DtC1e4BkN5-apPmt2PoKshxKM1BLxGU2qWXXBxPWqxqJZgCoTnhYJXBpSQZzqe~~UyObY6slitRYOgl9L~XT1ClgsLkYEA79aFPR0KFsnPFKA6if7msIJ3W3JXqY~p-K~DHViLumMy1glU3TFzbNKln3R3WiGvAprkstgEA9Dn9fp-opqv46TRBCq3dgmCuKcSLxfrZtEoNyhzu~VCHlA__&Key-Pair-Id=KL5I0C8H7HX83",
"running_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Running_withSkin.glb?Expires=1772736429&Signature=LFfspnLk509Ich9CqZ4BKO4V0AwK6kgYj7XZbILY1P~5zkA1HhdUMdL9t6xvr8wYYsNbc92Xqiy0djc~-SzF3MjdWyH7uT6~OdS1vxra82L4P6NoIV2AznMDSuKwcE5RPv3GQ-z6HS2P76VyAZmLd4wMfhnwEksex~m4cBDl03WZp7vHx387JP3PD4WkMOFBEc89vu1HTRuEEkBoBWyIuoKE3814JXIn-ReLj8H56KEUraQoVEK9cSKvwuCJVjYef2thyhw~Mbj7Nh4D0WeTK5bSQALKnnFN9DtMqPzOsSBlDPIvYMmqgVjpHC~3sNK3udSAj~mydrNivZ~DlgazCQ__&Key-Pair-Id=KL5I0C8H7HX83",
"running_fbx_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Running_withSkin.fbx?Expires=1772736429&Signature=r6cUuIj6Xcit9nU0Q1SqnuHRppgU6UkVWIuLifQJYsa~DFU-sJR9UH7GPkhxdqZAtfz74QEAI7~hINRHycpc6ftbFuv787LVBH5KocmRxig4WexmQUpdorCra18DCiWksBsW~vTiU~Wo3ddHKVw~kc1dtrkB-71Ho8IHqZTMoLHT2jIJyChstkGSpgTy4uDIfNEg5l7~RRXJKH05WbtmBuGDtBRDnmjRlPFv3elVlLEUI~gxPdP-dI4CqGzZBfbtabMVBmkTTsbpO-5yIbVIGiA5ToV97SeuhT-EfNCaDTkxGwlKvUjU4xcLWYz6Mwe8TVDNweRMCwP3m0sqYuQmUw__&Key-Pair-Id=KL5I0C8H7HX83",
"running_armature_glb_url": "https://assets.meshy.ai/2ed7287c-25fb-43dc-92e9-ce4c99c1c264/tasks/019cafdd-e64e-728c-a6c1-87a65fd9ac8d/output/Animation_Running_withSkin_armature.glb?Expires=1772736429&Signature=YENZiJwk2JtCgkT3QIn89flwebb1NK38oZ7fOX2XItBvNSqzVe5QCqXCuyVfju50hE7PQWYyebMG6~hYBTwX4bj5gmd~JBHmS~YIFR0Q-d1zwk2UaFn6A14GKSxWIUB-KZt3q4TZMnfFXJFhQ3L1IzAiV1O8qcTz6gt7Lr0t0~W3lrDS3Dgu7OKs~kY1V633VHzB9F2pQKmJj1YhuGxnrAa~3OPsuxm49LAENeozHaiEeYLjCQpJVkIP0e~JFauNAfITKhrMzU9d8kJLiMP3-uo4gg-LOKbjZJtf3WpCx9amvH5L~~pDH5zfXEq04dNxGDMY5yxR0RlaFYU2MUPjhw__&Key-Pair-Id=KL5I0C8H7HX83"
},
"note": "Signed URLs removed — they were temporary Meshy AI download links that have since expired. Use task IDs above to re-generate if needed.",
"downloadedAnimations": {
"walk": "gigachad-walk.glb",
"run": "gigachad-run.glb"
examples/gigachad-sim/src/core/EventBus.js
+1 -1
View File
@@ -64,7 +64,7 @@ class EventBus {
emit(event, data) {
if (!this.listeners[event]) return this;
this.listeners[event].forEach(callback => {
[...this.listeners[event]].forEach(callback => {
try {
callback(data);
} catch (err) {
examples/gigachad-sim/src/ui/Menu.js
+1 -1
View File
@@ -63,7 +63,7 @@ export class Menu {
width: 24px;
height: 24px;
border-radius: 4px;
background: ${COLORS.LIFE_FULL === 0xff4444 ? '#ff4444' : '#ff4444'};
background: #${COLORS.LIFE_FULL.toString(16).padStart(6, '0')};
transition: background 0.3s, transform 0.3s;
`;
this.livesContainer.appendChild(icon);