The progressive Feishu card (release-prerelease-card.yml) has carried four real prereleases: correct rendering, per-platform refresh, correct changelog, smoke wired through. The one-shot custom-bot webhook card it superseded was kept alongside it on purpose — a gap in release notification is worse than a duplicate — and its own TRANSITIONAL comment named the retirement scope. Deletes notify-release-feishu.yml's `notify` job, leaving that workflow as what its remaining job already is: the push-to-release/** prerelease build entry point. tools/release/src/notifications/feishu.ts stays. notify-daily-feishu.yml renders the beta download card through it and `tools-release notify feishu` exposes it, so only the prerelease call path is removed. The FEISHU_RELEASE_WEBHOOK / FEISHU_RELEASE_SIGN_SECRET secrets stay too — six other workflows post through them, and keeping them leaves a rollback open.
55 KiB
Directory guide
This file is the single source of truth for agents entering this repository. Read this file first; after entering apps/, packages/, tools/, or e2e/, read that layer's AGENTS.md for module-level details. Do not copy module details back into the root file; root stays focused on cross-repository boundaries, workflow, and commands.
Core documentation index
- Product and onboarding:
README.md,docs/i18n/README.zh-CN.md,QUICKSTART.md. - Contribution and environment:
CONTRIBUTING.md,docs/i18n/CONTRIBUTING.zh-CN.md. - Architecture and protocols:
docs/architecture.md,docs/skills-protocol.md,docs/agent-adapters.md,docs/modes.md. - Historical product baseline:
docs/spec.md,docs/roadmap.md(both explicitly archived; do not treat their dated decisions as current behavior). - References and current plans:
docs/references.md,docs/code-review-guidelines.md,specs/current/maintainability-roadmap.md,specs/current/ci.md(CI scope confidence methodology — required before changing planner confidence, routing, or omission policy in.github/config/scopes.jsonand.github/scripts/scopes.py),specs/current/chat-panel-next.md(ChatPanel 重构:基线、任务进度规格、决策记录、踩过的坑 — 改 chat 渲染管线/工具调用展示/执行记录前必读),specs/current/chat-panel-next-plan.md(交付计划与纠偏节点). - Directory-level agent guidance:
.github/AGENTS.md,apps/AGENTS.md,packages/AGENTS.md,tools/AGENTS.md,e2e/AGENTS.md,apps/web/src/components/chat/AGENTS.md(chat 组件分层、--chat-*样式接缝、降级形态与测试规约). - Packaged auto-update architecture and high-confidence local harness: read
tools/pack/AGENTS.mdsection "Packaged auto-update architecture and harness" before touching packaged updater code, release-channel identity, installer behavior, or updater UI. - Packaged build cache contract:
tools/pack/CACHE.md(determinant rules, materialization-time parameters, confidence grading — required before changing any build-cache node key). - Prompt composition has two independent implementations behind a rollout switch:
docs/prompt-composition.md(fork point, variant axes, host runtime contract table, worked examples — required before changing any prompt text, inapps/daemon/src/prompts/,packages/contracts/src/prompts/, or underplugins/_official/scenarios/od-next-strategy/). See "Prompt variants" below.
Workspace directories
- Workspace packages come from
pnpm-workspace.yaml:apps/*,packages/*,shells/*,tools/*, ande2e. - Top-level content directories:
skills/(functional skills the agent invokes mid-task — utilities, briefs, packagers; seeskills/AGENTS.md),design-templates/(rendering catalogue: decks, prototypes, image/video/audio templates; seedesign-templates/AGENTS.mdandspecs/current/skills-and-design-templates.md),design-systems/(brandDESIGN.mdfiles),craft/(universal brand-agnostic craft rules a skill can opt into viaod.craft.requires),mocks/(replay-based mock CLIs foropencode/claude/codex/gemini/cursor-agent/deepseek/qwen/grok, the ACP familydevin/hermes/kilo/kimi/kiro/vibe, and the AMRvelaCLI (login + models + ACP), built from anonymized Langfuse traces — PATH-overlay drop-in for tests and self-validation; seemocks/README.md). apps/webis the Next.js 16 App Router + React 18 web runtime; do not restoreapps/nextjs.apps/daemonis the local privileged daemon andodbin. It owns/api/*, agent spawning, skills, design systems, artifacts, and static serving.apps/desktopis the Electron shell; it consumes web/daemon status through the sidecar client boundary.apps/packagedis the thin packaged Electron runtime entry; it starts packaged sidecars and owns theod://entry glue only.apps/closureowns the independently distributable OpenDesign Closure content. It does not own acquisition, generation state, or shell policy.packages/contractsis the pure TypeScript web/daemon app contract layer.packages/sidecar-protoowns business DTOs and action names;packages/sidecarowns the complete business-agnostic sidecar client boundary and protocol implementation;packages/platformowns generic OS process primitives.packages/standaloneowns the shell-neutral exact metadata, verification, materialization, generation, and launcher contract.shells/terminalowns the official Node carrier and terminal-facing lifecycle commands. Shells consume standalone contracts and must not import Closure app source.tools/devis the local development lifecycle control plane.tools/packis the local packaged build/start/stop/logs control plane, packaged updater harness, installer identity/registry validation surface, and mac beta release artifact preparation surface.tools/serveis the local fixture-service control plane; first service istools-serve start updaterfor deterministic updater metadata and artifacts.tools/releaseowns release metadata, storage publishing, release reports, and notification-facing data contracts; packaged artifact construction and smoke testing remain intools/pack.e2eowns user-level end-to-end smoke tests and Playwright UI automation; reade2e/AGENTS.mdbefore editing its tests or commands.
Inactive or placeholder directories
apps/nextjs,packages/shared, andapps/landing-pagehave been removed; do not recreate or reference them.- Local runtime data,
.tmp/, Playwright reports, and agent scratch directories must stay out of git. For daemon-managed data paths, read and follow Daemon data directory contract below; do not restate or improvise path conventions elsewhere.
Development workflow
Environment baseline
- Runtime target is Node
~24andpnpm@10.33.2; use Corepack so the pnpm version pinned inpackage.jsonis selected. - New project-owned entrypoints, modules, scripts, tests, reporters, and configs should default to TypeScript.
- Residual JavaScript is limited to generated output, vendored dependencies, explicitly documented compatibility build artifacts, and the allowlist in
scripts/guard.ts.
Windows native
- macOS, Linux, and WSL2 are the primary supported paths. Windows native is best-effort — file an issue if it doesn't work.
- Historical Windows-specific friction is documented in closed issues #10, #96, #100, #203, and #315; check the issue tracker for the current state before filing new reports.
- Install Node 24. Either
winget install OpenJS.NodeJS.LTS(currently Node 24.x) or download from https://nodejs.org. After install, verify withnode --version— the WinGet LTS pointer rolls to the next major in October 2026, so re-verify if you re-run the install command later. Do not use Node 22 — see FAQ. corepack enablefails with EPERM on Windows (cannot write shims toProgram Files). Usenpm install -g pnpm@10.33.2instead.better-sqlite3has no prebuilt binary for win32/Node 24;pnpm installwill compile it from source via node-gyp (~2 min). Requires Visual Studio Build Tools 2022 or newer. This is expected — not a sign of version incompatibility.- For
tools-devstart/stop/status usage, see "Local lifecycle" below.
Local lifecycle
- Use
pnpm tools-devas the only local development lifecycle entry point. - Do not add or restore root lifecycle aliases:
pnpm dev,pnpm dev:all,pnpm daemon,pnpm preview, orpnpm start. - Ports are governed by
tools-devflags:--daemon-portand--web-port. tools-devexportsOD_PORTfor the web proxy target andOD_WEB_PORTfor the web listener; do not useNEXT_PORT.
Daemon data directory contract
This section is the only repository-wide source of truth for daemon-managed data paths. Every README, guide, deployment note, and operational handoff that mentions daemon data paths must point here instead of restating the rules.
This boundary is strict. Do not introduce concrete filesystem examples for the daemon data directory, recommended data directory, shared data directory, deployment mount, or example data directory. If existing code exposes a legacy fallback, treat it as implementation detail or a known escape candidate, not as a documentation pattern to copy. If a change needs a data-path rule that is not covered here, request a core-maintainer decision in the PR instead of inventing a new convention.
The daemon has one active data-root truth source:
- On daemon startup,
apps/daemon/src/server.tsresolvesOD_DATA_DIRintoRUNTIME_DATA_DIR. - All daemon-owned data paths must derive from
RUNTIME_DATA_DIRor from a constant derived from it, such asPROJECTS_DIRorARTIFACTS_DIR. PROJECTS_DIRis the managed-project root. Imported-folder projects are the explicit exception: they usemetadata.baseDirfor the user-selected external workspace.ARTIFACTS_DIR, SQLite, app config, memory, MCP config/tokens, automation state, plugin state, connector credentials, generated files, logs owned by sandbox mode, and agent runtime homes are daemon data and must remain under the resolved daemon data root unless this file names a specific exception.- Agent subprocesses receive the resolved daemon data root as
OD_DATA_DIR. They must inherit the daemon's truth source instead of guessing their own data path.
Development propagation:
tools-devconsumes sidecar launch/discovery/lifecycle atomics and owns only developer orchestration policy.tools-dev --namespace <name>does not, by itself, define daemon data isolation.- A development run that needs an isolated daemon data root must pass
OD_DATA_DIRinto the daemon process environment. After that, the daemon resolves it once and all daemon data paths flow fromRUNTIME_DATA_DIR.
Packaged propagation:
tools-pack/apps/packagedown packaged channel and namespace layout.- Packaged code resolves the final namespace-scoped daemon data root before spawning the daemon.
- The packaged daemon receives that final data root as
OD_DATA_DIR; daemon code must not infer packaged data paths from app names, ElectronuserData, ports, channel names, or namespace names.
Sanctioned exceptions:
OD_MEDIA_CONFIG_DIRis a narrow override formedia-config.jsononly. It is not a second daemon data root.OD_LEGACY_DATA_DIRis a migration source for legacy data import only. It is not an active daemon data root.- External tool homes such as
CODEX_HOMEare integration inputs, not daemon data roots. The daemon must not describe them as OpenDesign runtime data. - Agent/project-cwd skill staging aliases are not daemon data roots.
- Manifest metadata keys and CSS identifiers are semantic namespaces, not filesystem path conventions.
Known escape candidates that must not be reused:
- Module-level defaults that point at a cwd-relative legacy data directory.
- Helper defaults such as
defaultRegistryRoots()that recompute a data root fromprocess.env.OD_DATA_DIRor a cwd fallback instead of receivingRUNTIME_DATA_DIR. openDatabase(projectRoot)calls that rely on its fallback instead of passing the resolved data root.- Script help text or examples that suggest concrete legacy data directories.
Do not extend these escape patterns. When a fix is obvious, route the path
through RUNTIME_DATA_DIR or an explicit data-root argument. When it is not
obvious, block the PR and request core-maintainer guidance.
Root command boundary
- Keep root scripts reserved for true repo-level checks and tools control-plane entrypoints:
pnpm guard,pnpm typecheck,pnpm tools-dev,pnpm tools-pack, andpnpm tools-serve. - Do not add root aggregate
pnpm buildorpnpm testaliases. Build/test commands must stay package-scoped (pnpm --filter <package> ...) or tool-scoped (pnpm tools-pack ...). - Do not add root e2e aliases; e2e package commands and ownership rules live in
e2e/AGENTS.md.
GitHub automation boundary
Read .github/AGENTS.md before editing .github/workflows/, .github/scripts/, .github/actions/, PR follow-on automation, workflow_run trusted writes, CI handoff artifacts, or the workflow topology checks that guard those surfaces.
CI-related GitHub automation uses a two-layer architecture:
- Business layer workflows own product or validation decisions.
ci.ymlis the main low-privilege PR, merge-queue, and manual validation workflow. It detects scope, runs checks, and produces typed handoff artifacts. - Atomic capability workflows own reusable trusted operations.
comment.atom.ymlpublishes pure text PR comments,autofix.atom.ymlapplies same-repository patches, andreport.atom.ymlmaterializes advanced comments that need trusted dependencies, secrets, or report generation before upsert.
Do not add a new business-named follow-on workflow such as foo.comment.atom.yml or bar.autofix.atom.yml without first trying to express the flow as a ci.yml producer plus the existing comment, autofix, or report capability. Keep artifact naming, storage layout, and parser behavior centralized in .github/scripts/handoff.py; do not let individual workflows invent parallel handoff conventions.
CI test-set orchestration guidance
Use the following as a recommended convergence model, not a repository-wide conformance gate. Existing workflows and coarse test lanes may remain while their boundaries are understood. Do not block an unrelated change or require it to repay adjacent orchestration debt solely because it touches an existing lane. Apply these recommendations incrementally when the local scope and measured scheduling benefit justify the migration.
Prefer one selection direction: changed paths → source units → test sets →
execution workloads. Because the plan job runs before and governs downstream
jobs, new omission policy should live in the planner rather than rely on a
downstream guard to justify it after scheduling has already occurred.
When a CI area is being reorganized, prefer three named responsibilities:
- Source units name stable ownership or behavior boundaries in production, test, fixture, and control-plane paths. Prefer composing repeated selectors under a named unit instead of copying prefixes into unrelated rules.
- Test sets name independently useful semantic validation groups. Their membership and execution contract should converge on one authoritative declaration instead of accumulating more matrix or file-list copies across planner configuration, workflow YAML, and framework-local registries.
- Routes map source units to the test sets required to validate them. Routes should express impact rather than runner mechanics; runner image, setup, sharding, and job packing can remain execution concerns derived after selection.
Good split candidates have a stable boundary, change work that can actually be omitted, and carry enough runtime cost or diagnostic value to justify another scheduling identity. Directory size, file count, or the ability to write a narrower glob is weak evidence on its own. Prefer a small number of composable semantic units over per-file mappings, exception lists, or negative-rule forests. Treat existing duplicated or implicit declarations as migration surfaces without requiring every nearby change to remove them.
Before promoting a new route from observation to active omission, retain conservative behavior such as:
- unknown, mixed, unresolved, invalid, or below-threshold input selects the conservative full plan;
- editing a test, fixture, or suite manifest selects the test set that consumes it; shared harness, contract, setup, or lockfile changes fan out to every affected set;
- making a selected test-set identifier that the executor cannot run fail visibly instead of being ignored;
- direct planner tests cover representative in-bound, out-of-bound, mixed, and fallback inputs without reimplementing the evaluator in another language.
Keep scope routing and reusable-result convergence conceptually orthogonal:
scope answers which test sets are necessary for a change, while convergence
answers whether an identically declared workload already has a validated,
reusable successful result. New designs should not use result availability to
weaken source-to-test coverage or copy route policy into
.github/config/convergence.json. Prefer productless reusable workloads; when a
workload owns products, declare the complete typed reuse manifest with it.
For work whose purpose is CI orchestration, start by inventorying the current
chain from changed path to match, effect, workload, job command, and concrete
test cases. Prefer naming or removing implicit joins before making them finer.
Changes under .github/ must also follow .github/AGENTS.md and the current
confidence methodology in specs/current/ci.md.
Release channel model
betais the daily R&D/development validation channel. It is optimized for fast development feedback and is not part of the stable promotion gate.prereleaseis the internal validation channel for stable delivery. Stable releases remain gated by validated prerelease artifacts.- Prerelease builds macOS x64 (Intel) on every run.
release-prerelease.ymltakes anenable_mac_x64input that defaults totrue, andnotify-release-feishu.yml(the push-to-release/**entry point) forwardstrueon push. The switch stays because Intel is the pipeline's critical path — it runs on the slowermacos-15-intelfleet, ~33 min against ~21 min for every other platform — so a run that is explicitly not about Intel can buy that time back. Turning it off costs that build its promotion eligibility, so it is not a routine choice. - A prerelease built without
enable_mac_x64cannot be promoted to stable. Stable ships Intel and stable's gate is validated prerelease artifacts, so an Intel-less prerelease has not validated the Intel artifact stable will ship. This is enforced, not merely documented:validateStablePrereleaseMetadataintools/release/src/metadata/prepare-stable.tsrequiresplatforms.macIntel(withenabled: true,arch: "x64",signed: true, and versioned dmg/zip URLs) in the promoted prerelease's metadata, so promoting an Intel-less prerelease fails the stablemetadatajob instead of silently shipping an unvalidated Intel build.platforms.linuxis deliberately not required there. - The
notify-release-feishu.ymlforwarding for a default-on boolean must be${{ github.event_name != 'workflow_dispatch' || inputs.<flag> }}, never${{ inputs.<flag> || true }}.inputsis unset on push, so the second form reads correctly there — but on a dispatch where the operator UNCHECKED the box,false || trueis also true and the switch becomes unturnoffable. (A default-off boolean uses${{ inputs.<flag> || false }}for the mirror-image reason: a bare${{ inputs.<flag> }}forwards''to atype: booleancallee input.) enable_smokeandenable_testsalso default totrue, because neither costs the build anything any more — see "Prerelease validation runs outside the pipeline" below.mac_sign_mode(defaultsign-only) codesigns without the Apple notary round-trip;notarizeis the pre-stable setting, since stable ships notarized.win_x64_smoke_modestill chooses how deep the Windows smoke goes, and applies only whenenable_smokeis on.- Signing is not optional for a prerelease that will be promoted.
validateStablePrereleaseMetadatarequiresplatforms.mac.signed == trueandplatforms.macIntel.signed == true, somac_sign_mode: noproduces a prerelease that cannot become a stable release. Notarization has no metadata field and is therefore not checked — which is exactly why it, and not signing, is what the fast default drops. - Automated tests do not gate prerelease delivery. A prerelease exists so a person can install it and test it by hand; machine CI is a parallel opinion about the same commit rather than a valve on delivery, and a flaky suite must never cost the team a day's package. Do not reintroduce a test job into
build_*orpublish'sneeds/if; if a check must genuinely block delivery, that is a channel-policy decision, not a workflow edit. - Prerelease validation runs outside the pipeline.
release-prerelease.ymlholds one repository-wide concurrency group (open-design-release-prerelease,cancel-in-progress: false), so any job that outlivespublishkeeps that group held and stops the NEXT prerelease from starting. Making the test jobs advisory was therefore not enough — they still blocked the next build. The workflow now contains onlymetadata → build_* → publishplus two fire-and-forget dispatcher jobs, and the validation lives in three dispatched workflows with concurrency groups scoped to the origin run:release-prerelease-tests.yml—functional_e2e,e2e_vitest,daemon_unit_tests,verify, dispatched as soon as the build commit resolves.release-prerelease-smoke.yml— the packaged mac/Windows smoke, dispatched afterpublish. It does not test a local build directory:.github/scripts/release/smoke-artifacts.tsreads the published version metadata, downloads the DMG / setup.exe a user would get, verifies its sha256 sidecar, and writes it to the one pathtools-pack <platform> installreads. Linux keeps its in-job smoke, because the whole Linux lane is opt-in behindvars.ENABLE_STABLE_LINUXand is on nobody's critical path.release-prerelease-card.yml— the progressive Feishu card. All three are dispatched through.github/scripts/release/dispatch-validation.sh, which aimsgh workflow runat the built branch first and the default branch second, so a release branch cut before these lanes existed still gets validated. A dispatch failure is loud and non-blocking: nothing depends on the dispatcher jobs.
- One writer owns the release card. A Feishu
PATCHreplaces the entire card, so build jobs updating "their own" row would each erase the other two's.release-prerelease-card.ymltherefore owns the message alone and learns everything by polling the jobs API of the three runs;tools/release/src/notifications/prerelease-card.tsrenders the card as a total function of that state (unit-tested intools/release/tests/prerelease-card.test.ts) andfeishu-app.tsis the application-bot transport. The card is deliberately withheld until the first platform publishes — a "构建中…" card posted at dispatch time becomes a permanent lie when a build dies — with total build failure as the one exception, where silence would hide an incident. version_metadata_urlis the authoritative "did a package ship?" signal, not the workflow conclusion. The conclusion goes red for anything anywhere in the release run, including work that happens after publication, so keying a notification off it paints the card red while its own download buttons work. The progressive card takes that answer from the published metadata it verifies rather than from a job conclusion, andtools/release/src/notifications/feishu.tskeeps the same rule (VERSION_METADATA_URLoutranksBUILD_STATE, falling back to it only for callers that do not pass a URL) for the daily beta stream.- The prerelease Feishu notification has exactly one source:
release-prerelease-card.yml. The transitional one-shot webhook card that lived innotify-release-feishu.yml'snotifyjob was retired once the progressive card had carried four real releases; that workflow now only builds. Do not add a second prerelease notifier — the card is a PATCH-in-place message with a single writer, and a second poster produces the duplicate the transition existed to end.tools/release/src/notifications/feishu.tsand theFEISHU_RELEASE_WEBHOOK/FEISHU_RELEASE_SIGN_SECRETsecrets stay:notify-daily-feishu.ymlstill renders the beta download card through them, andcut-release,cut-patch-release,backport-automerge,bake-plugin-previews-automerge,main-prerelease-win-smoke, anddsh-upstream-driftall post through the same webhook. previewis an independent early-access channel with stable-like release rigor. It should use preview versions such asX.Y.Z-preview.N, publish to thepreviewR2 channel, publish updater feeds underpreview/latest, and follow stable's platform policy including the existing optional Linux enablement.stableis the formal delivery channel. Do not make stable promotion depend on preview; stable continues to depend on prerelease only.- Public packaged app identity must stay channel-distinct: stable uses
Open Design, beta usesOpen Design Beta, prerelease usesOpen Design Prerelease, and preview usesOpen Design Preview. Do not ship beta, prerelease, or preview mac DMGs whose drag-install app bundle isOpen Design.app. - Windows beta updater validation must use the real beta namespace
release-beta-win; otherwise a local beta-like namespace can create a separate uninstall registry key while looking like the sameOpen Design Betaapp. Seetools/pack/AGENTS.mdfor the architecture map and high-confidence acceptance harness.
Boundary constraints
- Tests under
apps/,packages/, andtools/live in a package/app/tool-leveltests/directory sibling tosrc/; keepsrc/source-only and do not add new*.test.tsor*.test.tsxfiles undersrc/. Playwright UI automation belongs toe2e/ui/, not app packages. - App packages must not import another app's private
src/ortests/implementation as a shared helper. In particular,apps/web/**must not importapps/daemon/src/**; web/daemon integration belongs behind HTTP APIs,packages/contracts, and app-local provider boundaries. - Cross-app, cross-runtime, or repository-resource consistency checks belong in
e2e/tests/when they need to observe more than one app/package boundary; promote reusable logic to a pure package instead of borrowing another app's private source. - Keep shared API DTOs, SSE event unions, error shapes, task shapes, and example payloads in
packages/contracts; update contracts before wiring divergent web/daemon request or response shapes. - Keep
packages/contractspure TypeScript and free of Next.js, Express, Node filesystem/process APIs, browser APIs, SQLite, daemon internals, and sidecar control-plane dependencies. - Keep project-owned entrypoints, modules, scripts, tests, reporters, and configs TypeScript-first; generated
dist/*.jsis runtime output, and source edits belong in.tsfiles. - New
.js,.mjs, or.cjsfiles need an explicit generated/vendor/compatibility reason and must passpnpm guard. - App business logic must not know about sidecar/control-plane concepts. Keep sidecar awareness in
apps/<app>/sidecaror the desktop sidecar entry wrapper. - Shared web/daemon app contracts belong in
packages/contracts; that package must not depend on Next.js, Express, Node filesystem/process APIs, browser APIs, SQLite, daemon internals, or the sidecar control-plane protocol. - Sidecar process stamps must have exactly five fields:
channel,namespace,source,mode, andapp. IPC is private implementation detail and is never a stamp field. - Sidecar identity is argv-only. Do not create identity/state files derived from a stamp.
- Orchestration layers (
tools-dev,tools-pack, packaged launchers) must call@open-design/sidecarclient/atomic primitives; do not expose argv assembly, IPC paths, or process scans. - Packaged runtime paths must be namespace-scoped and independent from daemon/web ports; ports are transient transport details only.
- Default runtime files live under
<project-root>/.tmp/<source>/<namespace>/...; private IPC endpoints are derived by@open-design/sidecarfrom the five-field stamp and the current OS principal. POSIX endpoints use a principal-scoped, hashed directory under the OS temporary directory; callers must treat the concrete path as opaque.
Capability exposure (UI/CLI dual-track)
Every user-facing capability must be reachable through both the web UI and the od CLI (apps/daemon/src/cli.ts). Shipping a feature with only one of the two surfaces is a regression.
- The CLI is the embeddability contract. External agents (hermes-agent, openclaw, custom Slack/Discord bots, packaged runtimes invoked from another shell) drive OpenDesign through
odsubcommands — they do not render the web UI. If a capability is UI-only, it cannot be composed into those external agents. - Both surfaces must call the same
/api/*endpoints; do not let the CLI talk to one shape and the UI to another. The daemon HTTP layer is the single source of truth, withpackages/contractscarrying the shared DTOs. - The CLI form must support
--jsonfor machine-readable output and accept long-form prompts via--prompt-file <path|->, so jobs that pipe throughxargs,jq, and<heredocstay clean. - Adding a new capability is a three-step closure: HTTP endpoint in
apps/daemon/src/*-routes.ts(with a contract type inpackages/contracts/src/api/), UI surface inapps/web/src/, andod <capability>subcommand inapps/daemon/src/cli.tsregistered throughSUBCOMMAND_MAP. Land all three in the same PR; do not stage them across PRs. - The PR template's Surface area checklist must reflect both surfaces. If you ticked UI, tick CLI too — and vice-versa — or explain in the PR body why the missing surface is genuinely not applicable (e.g. an internal-only daemon health probe). "I'll do the CLI later" is not a valid reason.
- Existing reference points:
od automation …mirrors the Automations tab against/api/routines;od plugin …,od ui …,od project …,od media …,od mcp …,od research …follow the same shape. Copy that pattern for new capabilities.
Git commit policy
- Git commits must not include
Co-authored-bytrailers or any other co-author metadata.
Pull request expectations
- Opening a PR uses
.github/pull_request_template.md; fill every section, not just the title. - "Why" must answer both the author's use case (what made you write this PR) and the pain being addressed (user problem, technical debt, prod issue, or unblocker), not just a one-line restatement of the title.
- "What users will see" describes the change from a user's perspective — what they click, what new thing appears, what default behavior changed — not from a code perspective.
- The Surface area checklist must reflect actual surfaces touched; check every box that applies, including extension points (
skills/,design-systems/,design-templates/,craft/), CLI flags, env vars, i18n keys, and new rootpackage.jsondependencies. - If any UI surface is checked, attach screenshots showing the entry point — where users discover the change — not just the feature in isolation; before/after is best for behavior changes.
- For bug-fix PRs, link the red-spec test that reproduces the bug and confirm it went red on
mainand green on the branch, per theBug follow-up workflowsection above. CONTRIBUTING.mdcovers PR scope, title format, dependency policy, and the issue-first rule for non-trivial features;docs/code-review-guidelines.mdis the reviewer-facing complement.
Code review guide
- Use
docs/code-review-guidelines.mdas the repository-wide review standard. That document is the operational guide; thisAGENTS.mdis the source of truth when the two disagree. - Walk reviews top-down through
docs/code-review-guidelines.md: Product relevance test → forbidden surfaces → ownership/scope → matching lane → checklist → comments → approval bar. - Pick the matching review lane: default code/tests, contract and protocol changes, design-system additions, skill additions, or craft additions.
- Before reviewing changes under
apps/,packages/,tools/, ore2e/, read that directory'sAGENTS.mdand apply its local boundaries. - Blocking review feedback should focus on correctness, security/secrets, data integrity, repository boundary violations, contract/migration breakage, missing required validation, or high-risk maintainability issues.
- Only maintainers may close a PR instead of requesting changes, and only when the change is not salvageable on the existing branch (wrong target product, foreign test harness, DOM/API assumptions absent from this repo, or scripts that conflict with lifecycle rules).
PR-duty tooling
This repository no longer ships a maintainer PR-duty control plane. The former
pnpm tools-pr workflow has moved to the standalone PerishCode/duty project
so personal review-lane automation does not become product workspace
maintenance surface. Do not recreate tools/pr, @open-design/tools-pr, or a
root pnpm tools-pr script without a new explicit maintainer decision.
Prompt variants (two implementations, one switch)
A generation run is composed by ONE of two independent prompt implementations. composeSystemPrompt returns early at apps/daemon/src/prompts/system.ts:905 when a run carries an OD Next recipe, so the entire legacy stack below that line is skipped. The API/BYOK mirror at packages/contracts/src/prompts/system.ts:318 forks the same way. The two sides share no composition floor: a rule added to one holds only for the runs that take that side.
- Legacy side:
apps/daemon/src/prompts/(mirrored for API/BYOK inpackages/contracts/src/prompts/). - OD Next side:
plugins/_official/scenarios/od-next-strategy/assets/**(markdown sent to the model verbatim) plus TypeScript inpackages/contracts/src/prompts/od-next-strategy.ts, which is where OD Next carries host runtime contracts such as<question-form>and the deck framework — not in the task profiles. - Switch: Settings → Labs → Design Harness, app-config
odNextStrategyMode, orOD_NEXT_STRATEGY_ROLLOUT. Eligibility is re-evaluated per run byevaluateOdNextRollout(apps/daemon/src/strategies/od-next/rollout.ts:138) and can be latched down mid-session by a runtime signal, so which side a run takes varies on one machine with the switch unchanged. Divergence between the sides therefore surfaces as an intermittent bug.
Before changing any prompt text — in any of those locations — read docs/prompt-composition.md. It carries the variant axes, a host runtime contract table naming which path carries each contract today, the asset roster and package-hash rules for the plugin side, and the known gaps. A host contract should have one source that every path consumes: packages/contracts/src/prompts/deck-framework.ts is the worked example, feeding classic, BYOK, and OD Next from one scaffold. Repository-maintenance notes must never be written into files under that plugin's assets/; they are sent to the model verbatim.
Agent runtime conventions
RuntimeAgentDef.promptInputFormatselects how the daemon writes the prompt to a child's stdin. The default'text'writes the composed prompt and ends stdin immediately.'stream-json'wraps the prompt as one JSONLusermessage and KEEPS stdin open so the daemon can stream further user messages back in mid-turn. Claude (apps/daemon/src/runtimes/defs/claude.ts) ships'stream-json'together with--input-format stream-jsonas generic mid-turn input infrastructure; the daemon closes stdin once the turn terminates cleanly. Every other agent stays on'text'.apps/daemon/src/server.tstracksrun.stdinOpenon the run object.applyClaudeStreamJsonRunBookkeepingcloses stdin (and recordsturnCompletedCleanly) when aturn_end(orusage) event arrives with a nontool_usestop_reason. Thetool_usestop reason means the model paused mid tool (waiting on claude-code's internal runner); closing stdin there would truncate the follow up response.claude-stream.tsreads the turn'sstop_reasonfrom three frames, because Claude Code moved the field and the daemon does not control which build a user has installed. In order of precedence per message: (1)stream_event→message_delta→delta.stop_reason, the only place Claude Code 2.1.259 carries it, available only when--include-partial-messagesis negotiated; (2)assistant→message.stop_reason, the legacy shape, which 2.1.259 leavesnullon every frame but which older CLIs and argv-compatible forks still populate; (3) the terminalresultframe, surfaced asusage, present on every build and flag combination.emitTurnEndOncededupes them by assistant message id so a build that fills both (1) and (2) announces one turn once. There is deliberately no version gate — nothing tells us which release stopped filling the legacy field, and forks version themselves independently.- Whichever source fires,
turn_endis emitted AFTER every tool_use of the message has been emitted, so the daemon never closes stdin before it has seen the turn's tool calls. Only a main-turn frame may fire it: a forwarded Task sub-agent frame carries a non-null top-levelparent_tool_use_idand is refused (#5487). - A
resultframe ends one user turn, not the CLI process: a stream-json session whose stdin stays open emits oneresultper turn and keeps reading. That makes it a valid per-turn reset point forclaude-stream.ts's artifact-echo dedup, and on a build with no in-stream boundary at all it is the only one. - Verbatim CLI recordings backing all of the above live in
apps/daemon/tests/fixtures/claude-cli-recordings/(see itsREADME.md). Assert new turn-boundary behavior against those, not against the older hand-built Claude fixtures elsewhere inapps/daemon/tests/— those putstop_reasonon theassistantwrapper and describe a stream the current CLI no longer produces. - The host asks the user clarifying questions through the
<question-form>artifact (see "Asking the user questions" below), NOT through a stdin-injectedtool_result. There is noAskUserQuestiontool wiring, no/api/runs/:id/tool-resultendpoint, and no host-answer return path. The stream-json input skeleton is generic infrastructure, and its one product consumer isPOST /api/runs/:id/steer(「引导对话」, B11): the USER pushes a further message into a turn that is still running, which is the opposite direction from<question-form>. Admissibility lives inapps/daemon/src/runtimes/run-steering.ts(classifyRunSteering) — do not re-derive it at a call site, and do not extend it into a host-question path.
Starting a physical Run
- Every physical Run is started through
internalRunCreation.start(run, analytics, starter)(apps/daemon/src/services/internal-run-service.ts). Calling the run registry'sstartdirectly bypasses the Run analytics lifecycle, so the Run reports norun_createdand norun_finishedand nothing says so.pnpm guard's "run start choke point" check enforces this; the only allowed caller of.runs.start(is the service itself. - The
analyticsargument is required on purpose. A caller with no identity to attribute the Run to — a scheduled Automation, a background refresh — passesrequestAnalyticsContext: nullexplicitly; the lifecycle then stays silent instead of inventing one. Stating "no identity" is a decision the code has to record, not a step a caller can skip. - A daemon-created Run that continues an existing task inherits its analytics identity and lineage from the Run that caused it, via
inheritedRunLineageHints(apps/daemon/src/services/run-analytics-lifecycle.ts). Resolve lineage through that helper rather than from the source Run'sanalyticsRecovery: the lifecycle re-reads host facts before it captures, so a short Run can hand off before its own recovery record exists.
Asking the user questions
- There is exactly one mechanism for clarifying user intent: the
<question-form>markdown artifact the model emits inline.AssistantMessage.tsxrendersQuestionFormViewdirectly inside the originating assistant message, and answers flow back as the next user message (formatFormAnswersinapps/web/src/artifacts/question-form.ts→POST /api/chat). There is no separate Questions tab or native tool card. <question-form>is valid on ANY turn, not just turn-1 discovery. Use it for turn-1 discovery briefs AND for mid-conversation clarification (e.g. an ambiguous annotation). The system-prompt guidance lives inapps/daemon/src/prompts/system.tsanddiscovery.ts; the API/BYOK-mode wording is mirrored throughpackages/contracts/src/prompts/system.ts.run-artifacts.ts:runAskedUserQuestionpowers therun_finished.asked_user_questionanalytics signal by scanning the run's streamed text for a<question-formmarker (reassembled acrosstext_deltachunks), not by detecting any tool call.
Chat UI conventions
apps/web/src/components/file-viewer-render-mode.tsdecides URL-load vs srcDoc for HTML previews. Bridges (deck, comment/inspect selection, palette, edit, tweaks) can ONLY inject through the srcDoc path. Add a new disqualifier toUrlLoadDecisionwhenever a feature needs a srcDoc-only bridge; pass it fromFileViewer.tsxbased on a source-content heuristic where appropriate (e.g.hasTweaksTemplate). The host keeps both iframes mounted simultaneously and swaps CSS visibility so toggling render mode does not cause an iframe reload flash;iframeRef.currentstays aligned with the active iframe viauseEffect. Receive filters useisOurIframe(ev.source)to accept messages from either iframe but signals that should ONLY come from the active iframe (e.g.od:tweaks-available) re-checkev.source === iframeRef.current?.contentWindow.- TodoWrite has no pinned card above the composer. The task list appears in full exactly once, inside the turn's execution record, as
执行计划 · N 步plus one drawer per step (components/chat/ExecutionShell.tsx, decisions D29 / B17 inspecs/current/chat-panel-next.md). The oldPinnedTodoSlotinChatPane.tsxwas removed when the new execution record landed; do not reintroduce it. - What is pinned above the composer is the Plan pill (
components/chat/PlanPill.tsx, delivered-matrix cell #71): a one-line第 N / M 步capsule, with the whole list in a hover-only popover that opens upward. It is a second view of the same TodoWrite snapshot, not a second copy of the card —Nis which step is running now (not{done}/{total}), and the pill disappears entirely once the run ends or nothing in the list is unfinished. Visibility,N/M, and the per-step mark all live in the pureruntime/chat/plan-pill.ts; the component only draws. The expanded standalone Plan card (cell #70) stays not built (D33 / S9). - Because the pill sits outside the
.chat-logscroll container, it is wired into the same auto-scroll plumbing asQueuedSendStrip: it takes acontainerRef,ChatPane'sResizeObserverobserves that element, and the pane-levelMutationObserverre-attaches the observation whenever it mounts or unmounts. Any future pinned element there needs the same three pieces or new messages stop scrolling into view. The pill renders beforeQueuedSendStripin DOM order so a growing queue pushes it up instead of overlapping it. latestTodoWriteInputFromMessagesis the conversation-level discovery link (used by the pill);unfinishedTodosFromEvents(the daemon's own criterion) is untouched.- One capability travelled on that pinned card and has not been re-homed yet: continuing a turn's remaining tasks (
onContinueRemainingTasks). The delivered design never drew it, so where it goes is an open product decision (T33).AssistantMessagestill accepts the prop; nothing renders it today. - Clarifying questions render through the
<question-form>artifact directly inside the chat — see "Asking the user questions" above. - Tool group rendering uses
dedupeSnapshotToolRetriesto collapseTodoWritesnapshots (only the most recent call survives, since each call is a state replace).SNAPSHOT_TOOL_NAMESlists the snapshot-style tools; non-snapshot tools pass through untouched.
Web CSS ownership
apps/web/src/index.cssis an import-only cascade entrypoint. Do not add selectors or declarations there; add imports only when a truly global stylesheet is needed, and keep import order intentional.- Shared global styles belong in
apps/web/src/styles/: design tokens, base/reset rules, primitives, app-shell layout, and legacy cross-component selectors that cannot safely be scoped yet. Keep domain-level global files grouped by owner (for examplestyles/viewer/andstyles/workspace/) instead of adding more large files directly understyles/. - New component-owned UI styles should default to CSS Modules next to the component (
Component.module.css) instead of expanding global stylesheets. This is preferred for isolated components, panels, menus, drawers, toolbars, cards, and form sections. - When touching an existing component with nearby global styles, prefer migrating that component's local selectors to a CSS Module as part of the change if it is small and testable. Do not mix a large mechanical move with behavior/styling changes in the same patch.
- Keep global class names only for deliberate shared contracts: reusable primitives, theme hooks, third-party/content styling, cross-component layout, or selectors that rely on global cascade/specificity. Document any new global selector group with its owning feature.
- CSS refactors must preserve cascade semantics. For mechanical splits, verify expanded import content/order matches the previous stylesheet; for CSS Module migrations, validate the affected UI path with
pnpm --filter @open-design/web typecheckand a focused build/test or visual check when practical.
Web component reuse
- New
apps/webUI should reuse shared primitives from@open-design/componentswhen one exists instead of styling plain HTML elements directly. For example, useButtonfor app buttons andVisuallyHiddenfor screen-reader-only text/status content. - Do not add new raw primitive classes such as
primary,primary-ghost,ghost,subtle,icon-btn, orsr-onlyfor new UI. Those classes are legacy compatibility surface for existing markup until it is migrated. - If a needed primitive is missing, prefer adding a small focused primitive to
packages/componentswith colocated CSS Modules, then consume it from the app. Keep product-specific layout and workflow styling in the app, not inpackages/components. - Keep semantic plain HTML when it is content markup or a specialized control that the shared package does not model yet; do not force a migration that would hide native behavior or make a custom widget harder to reason about.
apps/webtranspiles@open-design/componentsfrom source during dev, so component and CSS Module edits should work through the normal web dev loop without rebuilding the package.
i18n keys
apps/web/src/i18n/types.tsis the typedDict; every key must be defined in all 19 locale files underapps/web/src/i18n/locales/*.ts(ar,de,en,es-ES,fa,fr,hu,id,it,ja,ko,pl,pt-BR,ru,th,tr,uk,zh-CN,zh-TW). Add the key totypes.tsfirst; missing translations produce a typecheck error.
UI animation philosophy
- Default ease-out for UI transitions:
cubic-bezier(0.23, 1, 0.32, 1). Built-ineaseis too weak;ease-inis forbidden for UI elements because it feels sluggish. - Asymmetric durations: enter around 200ms, exit around 140ms. Exit reads as decisive because the user has already chosen to dismiss.
- Accordion expand and collapse uses
grid-template-rows: 0fr -> 1fr(modern auto height pattern). Pair with opacity fade and the easing above. The shared.accordion-collapsible+.accordion-collapsible-innerclass pair (defined inapps/web/src/index.css) is the canonical implementation; reuse it for new disclosure UI. - Never animate from
transform: scale(0). Start fromscale(0.9)or higher withopacity: 0. - For elements that show conditionally, keep them mounted and toggle a CSS class (e.g.
.chat-jump-btn-active). React unmounts skip the exit transition entirely.
Validation strategy
- Before adding, repairing, or optimizing tests, follow
docs/testing/test-efficiency.zh-CN.mdfor completion signals, virtual-clock usage, isolation, and performance validation. - After package, workspace, or command-entry changes, run
pnpm installso workspace links and generated dist entries stay fresh. - For agent-stream / parser changes (
apps/daemon/src/runtimes/claude-stream.ts,json-event-stream.ts,qoder-stream.ts, etc.), replay a recorded session through the mock CLIs inmocks/to verify event shapes round-trip without burning provider budget. PATH-overlay activation:export PATH="$PWD/mocks/bin:$PATH" OD_MOCKS_TRACE=<8-char-id> OD_MOCKS_NO_DELAY=1. Seemocks/README.mdfor the trace catalog and selection knobs. - Docker image smoke/publish lives only in
.github/workflows/docker-image.ymland is outside the coreci.yml/Validate workspace/ merge queue gate. - Before marking regular work ready, run at least
pnpm guardandpnpm typecheck, plus the package-scoped tests/builds that match the files changed. Do not use or add rootpnpm test/pnpm buildaliases. - For local web runtime loops, prefer
pnpm tools-dev run web --daemon-port <port> --web-port <port>. - For e2e tests that need a tools-dev daemon/web runtime, use the shared tools-dev harness under
e2e/lib/tools-dev/and the framework suite adapters (e2e/lib/playwright/suite.ts,e2e/lib/vitest/suite.ts). Do not hand-spawntools-devfrom test cases or duplicate lifecycle helpers under framework-specific folders. - Playwright UI tests must import
test/expectfrom@/playwright/suite, not directly from@playwright/test; type-only imports from@playwright/testremain fine. The suite owns one isolated tools-dev daemon/web/data root per Playwright worker. Do not add a shared-runtime fallback; set Playwright workers to1when constrained. - Playwright suite code must not own workspace prebuild policy. CI and callers keep the existing prebuild steps;
tools-devdaemon freshness checks are only a fallback guard. - On a GUI-capable machine, validate desktop by running
pnpm tools-dev, thenpnpm tools-dev inspect desktop status. - Stamp/namespace changes must validate two concurrent namespaces and run desktop
inspect evalplusinspect screenshotfor each namespace. - Path/log changes must run
pnpm tools-dev logs --namespace <name> --jsonand confirm log paths are under.tmp/tools-dev/<namespace>/....
Bug follow-up workflow
The following is a working playbook for routine bug follow-ups, distilled from recent practice. Treat it as a default action shape, not a contract — production reality always has edges these bullets can't anticipate, so use judgment when the situation doesn't fit cleanly.
- Lead with a red spec. Default to encoding the bug as a falsifiable test that goes red before any source change, so the fix is anchored in observable behavior rather than source-code intuition. If a red spec can't be written cheaply, that's usually a signal to clarify scope rather than push forward on a guess.
- Try the cheapest layer first. Reach for the lightest test layer that can still see the symptom (e2e Vitest at the daemon HTTP boundary → app-local Vitest → Playwright UI → platform-native harnesses), and drop down only when the cheaper layer can't.
- Hold the spec's scope. Defects discovered outside the bug's described boundary belong in a follow-up — their own red spec, their own PR — not in this fix. List them in the PR body's "Adjacent issues" section with the rationale and move on.
- Let the fix read as an invariant. Prefer a named helper whose docblock describes what must hold over a bolt-on
ifguard with apologetic history-comments. The call site should read as intent. - Diff against the baseline. When neighboring suites have pre-existing failures, stash or check out upstream before claiming "no new failures."
- Link the issue from the PR body. Use
Fixes #N/Closes #N/Resolves #Nso the issue auto-closes on merge and the release-time reverse lookup (gh issue view N --json closedByPullRequestsReferences→git tag --contains <merge sha>) actually has a chain to follow. The repo's PR template prompts for this; deleting the prompt is fine when the PR genuinely closes nothing. - Stage human verification for visible bugs. When the symptom needs an eye to confirm — UI, platform-native behavior, animations, race conditions a unit test can't see — green specs alone aren't acceptance. Stand up a buggy-vs-fix comparison the reviewer can drive themselves (typical shape: two namespaced runtimes, one on
main, one on the fix branch), and seed any required data only through production HTTP APIs; source-level test backdoors invalidate the verification because they prove a fake flow rather than the real one.
For a worked example of one full loop (red e2e spec → fix → green), see e2e/tests/dialog/stop-reconciles-message.test.ts (issue #135).
Common commands
pnpm install
pnpm tools-dev
pnpm tools-serve start updater
pnpm tools-dev start web
pnpm tools-dev run web --daemon-port 17456 --web-port 17573
pnpm tools-dev status --json
pnpm tools-dev logs --json
pnpm tools-dev inspect desktop status --json
pnpm tools-dev inspect desktop screenshot --path /tmp/open-design.png
pnpm tools-dev stop
pnpm tools-dev check
pnpm guard
pnpm typecheck
pnpm --filter @open-design/web typecheck
pnpm --filter @open-design/web test
pnpm --filter @open-design/web build
pnpm --filter @open-design/daemon test
pnpm --filter @open-design/daemon build
pnpm --filter @open-design/desktop build
pnpm --filter @open-design/tools-dev build
pnpm --filter @open-design/tools-pack build
pnpm --filter @open-design/tools-serve build
pnpm tools-pack mac build --to all
pnpm tools-pack mac install
pnpm tools-pack mac cleanup
pnpm tools-pack win build --to nsis
pnpm tools-pack win install
pnpm tools-pack win cleanup
pnpm tools-pack linux build --to appimage
pnpm tools-pack linux install
pnpm tools-pack linux build --containerized
FAQ
Why is there no root pnpm dev / pnpm start?
To avoid starting daemon, web, and desktop through inconsistent env, port, namespace, or log paths. All local lifecycle flows must go through pnpm tools-dev.
Why should apps/nextjs not be restored?
The current web runtime is apps/web. The historical apps/nextjs layout has been removed from the active repo shape; restoring it would reintroduce duplicate app boundaries and stale scripts.
How does desktop discover the web URL?
Desktop queries runtime status through its sidecar client. The web URL comes from client status, not from desktop guessing ports, IPC paths, or reading web internals.
How are sidecar-proto, sidecar, and platform split?
@open-design/sidecar-proto owns OpenDesign business action names and DTO/status shapes. @open-design/sidecar is the unique truth source for five-field argv stamps, private IPC, OS resources, process discovery, launch, invocation, and terminal lifecycle. @open-design/platform provides generic OS process primitives beneath sidecar and must not leak those implementation details into apps or orchestrators.
When is pnpm install required?
Run pnpm install after changing package manifests, workspace layout, command entrypoints, bin/link-related content, or after adding/removing workspace packages.
Can I use Node 22 instead of Node 24?
No. package.json#engines specifies node: "~24", which is the only supported runtime. The current lockfile pins better-sqlite3@11.10.0; on Windows it has no prebuilt binary for Node 24 and is built from source via node-gyp (see the Windows native section). Older Node versions are not tested and may hit lockfile or dependency incompatibilities.