Files
Mohamed Boudra 1c51b52d07 Restore cached conversations before reconnecting (#4421)
* fix(app): restore cached conversations before reconnecting

Give each host one timeline write authority so cache restores, live events and fetched pages publish consistent rows and coverage. Persist a moving 40-entry restart page independently of loaded scrollback, and keep native navigation mounted while startup settings hydrate.

* fix(app): recover cache writes after initialization failures

Keep accepted writes pending and retry initialization without another UI update. Publish the storage index only after loading succeeds, while queued host identity changes still settle in order.

* test(app): wait for sidebar and workspace transitions

Viewport intersection and leaving the creation route can precede completed UI transitions. Wait for the layering hit test and selected agent tab before asserting or navigating again.

* fix(app): restore provider loading on native clients

The native AbortSignal lacks throwIfAborted, so successful provider responses failed before reaching every model selector. Preserve both cancellation boundaries using the supported aborted property and the existing query cancellation error.
2026-09-07 15:52:21 +02:00

6.8 KiB

Mobile panels

Compact layouts have three mutually exclusive destinations:

  • agent-list on the left
  • agent in the center
  • file-explorer on the right

They are one interaction, not two independent drawers. The implementation lives in packages/app/src/mobile-panels/.

Ownership

React/Zustand owns the durable intent:

interface MobilePanelSelection {
  target: "agent-list" | "agent" | "file-explorer";
  revision: number;
}

Every semantic target change increments revision. Repeating the current target is idempotent. Compact panel selection is not persisted; a cold start begins at agent.

The UI worklet owns transient motion:

  • one normalized position (-1 left, 0 center, 1 right)
  • the current motion target
  • the active gesture's starting revision
  • the last settled target

React publishes the active panel only when the canonical target and the UI-thread position agree at the final anchor. Retained content never observes gesture previews, progress, or an unsettled target. The gesture hosts stay mounted; worklets reveal their retained overlays through native styles while React owns pointer events and accessibility. Native panel hosts and their dependent draggable lists also retain identity across appearance hydration and settings changes. Do not wrap those hosts in appearance keys; see Unistyles appearance boundaries.

Why one position

Both transforms and both backdrop opacities are derived from the same normalized position. Window width is only a projection input. Rotation changes the projection, not the panel state.

This makes these invalid states unrepresentable:

  • a panel and its backdrop disagreeing
  • left and right drawers both claiming to be open
  • a width-sync effect resetting an active drag
  • one animation context settling a transition owned by the other

Do not add another panel translate shared value, backdrop shared value, or width synchronization effect.

Ordering and interruption

A gesture captures the current revision when it becomes active. Per-frame updates are accepted only while that revision still owns the gesture.

When a React command arrives during a drag, its newer revision clears gesture ownership and starts motion toward the new target. The older gesture's remaining updates and finish callback are ignored. Canceled gestures return to the latest canonical target. A successful gesture starts its finishing motion immediately; the matching React command adopts that motion instead of restarting it. Position settlement and command acceptance may arrive in either order. Activity changes after both agree on the same target.

Manual gesture arbitration has two phases:

  1. Before activation, determine whether horizontal intent may begin.
  2. After activation, stop running begin checks and let the active revision own updates.

Re-running the begin gate after activation self-cancels the gesture because an active gesture is, by definition, no longer eligible to begin.

Integration rules

  • Callers request semantic targets through panel-store; they never write shared values.
  • Gesture behavior comes from the four explicit hooks in mobile-panels/gestures.ts.
  • A focused interactive surface may block panel-opening gestures through useBlockMobilePanelOpenGestures. Register only while the conflicting interaction is active and unregister when the surface is hidden or unfocused. The blocker never disables gestures that close an already-open panel.
  • Keep SidebarModelProvider outside MobileGestureWrapper. The provider shares sidebar derivation across consumers, while Gesture Handler requires the wrapper's direct child to be a native View so its injected collapsable={false} reaches Android/Fabric.
  • Mobile sidebars render through MobilePanelOverlay; do not duplicate overlay lifecycle or motion styles in sidebar components.
  • The desktop left sidebar is retained too. App chrome owns separate mounted and visible decisions: closing it or yielding its width marks it inactive and applies display: none without conditionally removing the sidebar tree.
  • Animated panel nodes use React Native static styles plus inline theme values. Do not attach Unistyles-generated styles to those nodes; Unistyles and Reanimated patching the same Fabric node has caused native crashes.
  • FORCE_REACT_RENDER_FOR_SETTLED_ANIMATIONS stays off in packages/app/package.json. It is a compile-time flag; changing it needs a native rebuild. With it on, Reanimated 4.3 hands settled animated props back to React through a collector that forgets entries older than two seconds. A JS stall across a panel settle loses the final position, and the next React commit reverts the overlay to its last synced props: a backdrop over the workspace while the store says closed. Upstream fixed the collector in 4.4.3, which needs React Native 0.83.
  • Gesture start and progress must not update React state. The retained overlay is already mounted and offscreen; only the shared position and its derived native styles move during a drag.
  • Hidden tabs and workspaces use RetainedPanel. It owns a non-collapsible native root, visibility, pointer events, and the active signal consumed by useRetainedPanelActive.
  • Panels whose gesture wrapper already owns visibility use RetainedPanelActivity to provide the same active signal without adding another layout root. Persistent animations, timers, polling, and shared clocks must subscribe to that signal and stop when their final visible consumer leaves.
  • Synchronized step animations use one wall-clock-aligned source. Register a local shared value only while its retained panel is active so hidden animated styles remain mounted without receiving clock updates. Do not give every instance its own loop or leave hidden styles subscribed to the source.
  • Retention order and render order are separate concerns. LRU metadata may change on every switch; keyed retained roots must keep a stable sibling order. Moving large retained roots triggered Fabric Differ failures (addViewAt / removeViewAt view reuse) on Android.
  • useIsMobilePanelActive follows the settled target, not the requested target. Position at the canonical target's anchor is the settlement signal; animation duration and completion callbacks do not own activity. Cancellation publishes nothing.
  • Do not suspend retained native subtrees with Suspense/react-freeze. Suspension changes native ownership and can detach descendants. Keep the tree mounted, stabilize its subscriptions/selectors, and use the retained-panel active signal to stop timers, polling, and other genuine background work.

Tests

packages/app/src/mobile-panels/model.test.ts exercises command, drag, cancellation, interruption, rapid-command, position-settlement, and width-projection sequences through the transition model. Add a sequence there whenever ownership or ordering changes.