* test(feat): red — Three TestMains defer TerminateDoltContainer then os.Exit in the same function — teardown is dead code, 101 dolt containers leaked over 6 days and exhausted swap (refs be-5kkk6)
* fix(feat): green — Three TestMains defer TerminateDoltContainer then os.Exit in the same function — teardown is dead code, 101 dolt containers leaked over 6 days and exhausted swap (refs be-5kkk6)
* chore(release-gates): add be-r3ysh gate evaluation (PASS 7/7)
refs be-r3ysh, be-43oyc, be-5kkk6
Priority used the filled circle also mapped to status-blocked, so agents
misread ready work as blocked (GH#4996). Render P-labels only; document
the convention for agents; keep ● for blocked status alone.
Co-authored-by: Steve Yegge <steve.yegge@gmail.com>
* fix(show): expose guarded-write revision in JSON (bd-bwa7n)
Project RowVersion only at the bd show CLI edge so guarded subprocess clients receive the current opaque token without changing generic Issue, JSONL, or HTTP serialization. This preserves main's object-model boundary while restoring the show contract established by PR #4682.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Agent-Signature: codex-unknown-model-unknown-reasoning on behalf of CI Bot
* fix(show): resolve revision CLI/HTTP parity + emit legacy-zero token (bd-bwa7n)
Maintainer adoption fixup for PR #5353 (adopt-pr): pre-review CI normalization
plus the review-loop resolution of the CLI/HTTP parity decision that pre-review
deliberately deferred.
PR #5353 exposes the guarded-write revision (the row_lock optimistic-concurrency
token) in `bd show --json` via the CLI-edge DTO. That token is a per-write random
int64, so several oracles that pin bd's JSON shape needed to learn about it.
Pre-review CI normalization (mechanical volatile-token gaps):
- Contract corpus golden (cmd/bd/protocol): CanonicalizeJSON did not scrub the
new field, so the show blob diffed on the random value and the double-run
determinism check failed. Add a volatileValueKeys scrub for `revision` (pin the
field's presence, replace its value with <REVISION>, same treatment as
timestamps) and regenerate the two show goldens + manifest SHAs.
- Differential regression (tests/regression): the v0.49.6 baseline never emitted
`revision`, and its value is random per write, so it is pure cross-version
noise. Add it to volatileFields so normalizeIssue strips it before the
baseline/candidate diff.
Review-loop resolution (was DEFERRED at pre-review; now decided):
- CLI/HTTP read-parity (major): `bd show --json` emits `revision` but the
apigen-frozen GET /v0/beads/issues/{id} keeps RowVersion json:"-", so the
field-level parity oracle (TestProxiedServerServeReadParity/show) would flag it
as unreviewed drift. Resolve as an accepted CLI-only surface: add a documented
readsParityAllowlist["revision"] entry and rewrite the allowlist narrative.
Exposing the token over the frozen v0 HTTP object is out of scope; the token is
only meaningful to the CLI guarded-write path.
- Legacy-zero token (minor): drop `omitempty` from the show DTO so a legitimate
RowVersion==0 CAS token is emitted instead of being conflated with an absent
field; a guarded client must read the 0 it needs to send on un-mutated legacy
migration-0054 rows.
- Test evidence (minor): add TestProjectShowJSONDetailsEmitsZeroRevision pinning
the legacy-zero wire behavior.
Validated locally: git diff --check; go test ./internal/types (RowVersion),
./cmd/bd (focused show unit tests incl. the new zero-revision case),
./cmd/bd/protocol (corpus goldens unchanged), and the proxied Dolt parity oracle
TestProxiedServerServeReadParity (the show subtest now excuses `revision`).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: CI Bot <ci@beads.test>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Beads had two implementations of most issue verbs: one for the direct route
(the CLI talking to a store it opened itself) and one for the proxied-server
route (the CLI talking through a unit of work over a running Dolt server).
They drifted — different commit messages, different transaction boundaries,
different refusals, occasionally different answers.
Seven role interfaces now live in the leaf package issueops: Lifecycle,
Reader, ReadyClaimer, BatchCloser, DependencyEditor, Commenter and Relations.
Each is reached only through a store accessor, never a constructor, because
the accessor is where the hook and telemetry decorators add their layers.
Three implementations back every role — dolt, embeddeddolt, and the
unit-of-work provider the proxied route uses. Both routes call the same role
for close, dep add/remove/list, comment, ready --claim and update.
A depguard rule (httpapi-domain-boundary) denies internal/storage/domain from
internal/httpapi, so a handler cannot reach uw.IssueUseCase() past the roles
and open a second front door one lint-clean commit at a time.
Behaviour users will notice, all in the CHANGELOG:
- bd close a b c is one Dolt commit, not three, and --claim-next moved
inside that transaction so it fires only when something landed
- the open-children guard moved into the transaction and its hand-rolled
cmd/bd copy is gone, removing a read-then-write window that made
bd close <child> <parent> depend on argument order
- bd dep add --file honours deferred version commit
- embedded bd comment writes the role's message and author
- dep verb commit messages are the role's on the direct route
Wisp-sourced dependency edges are restored. Moving bd dep add onto the role
had pinned an edge's SOURCE to the issues plane, and the two routes did not
even fail alike: direct refused with "issue <id> not found", proxied threw an
fk_dep_issue violation. The comment justifying the pin claimed the issues
plane was "the only one its unit-of-work sibling can reach" — that was false;
domain.DependencyUseCase declared a full set of wisp twins with no production
caller. All three implementations now route per edge by the edge's own
source. A mixed request stays one transaction: parent-child-first ordering
and the whole-graph cycle gate span both planes, and a refusal rolls back
both. Behind the role, three bulk add verbs collapsed into one source-routed
AddDependencies, so no plane-pinned variant is left to reach for by mistake.
Six Provenance fields with no production caller were deleted rather than
wired — CloseRequest, CloseBatchRequest, ClaimNextRequest, AddCommentRequest,
AddDependenciesRequest, RemoveDependencyRequest. Each role already composes an
id-bearing message, so a caller could only restate the default and make it
unreachable from production. Two are not caller-settable even in principle:
CloseBatchCommitMessage names what LANDED and ClaimNextCommitMessage names the
id the claim WON. UpdateRequest and ReopenRequest keep theirs; commit messages
users see are unchanged.
Verified: build, vet and gofmt clean; golangci-lint 0 issues; protocol corpus
byte-identical under BEADS_PROTOCOL_REQUIRE_DOLT=1; all twelve
DependencyEditor conformance wirings green (four contract functions against
each implementation); TestEmbeddedDepAddWispSource runs bd dep add <wisp-id>
at the front door and was demonstrated RED against the pinned routing first.
Three internal/storage/dolt failures reproduce on pristine origin/main.
Known gaps are enumerated in the PR description rather than left to be found:
comment listing is on no role, bd dep tree and bd dep cycles have no role,
bd create and bd reopen are on Lifecycle only on the direct route, per-edge
line attribution is lost in bd dep add --file, multi-store bd close
--claim-next rides only the first store's batch, and the is_blocked staging gap
(bd-2y9ke, predates this change). Seven of the eight role interfaces now have a
shared conformance contract in backend/conformance, run at all three
implementations; main's Claimer, added in parallel by #5334, is the eighth and
has none yet.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* feat(storage): be-c5p AD-01 isProductionPort + DB-name firewall
Generalize the BEADS_TEST_MODE production-port guard so deployments
on non-3307 ports (BEADS_PRODUCTION_PORT env, BeadsDir/dolt-server.port
file) are also caught, and add a defense-in-depth database-name
firewall that refuses test-named DBs on any server unless the operator
opts into the dedicated test-server lane via BEADS_TEST_SERVER=1.
Both defenses honor BEADS_TEST_SERVER=1 as the single opt-in for
test-server connections, so each test harness flips one env var rather
than each layer reasoning about test/prod independently. Adds benchdb_
to testDatabasePrefixes (per-bench scratch DBs from cmd/bd/dolt.go)
and updates the doc-block to call out the two sibling prefix lists
that need to converge under be-avn.
Test harnesses across cmd/bd, internal/storage/dolt, internal/molecules,
internal/tracker, internal/utils, doctor, doctor/fix, protocol,
regression, and the root suite now set BEADS_TEST_SERVER=1 alongside
BEADS_TEST_MODE=1 in TestMain. The cross-rig integration test that
filters BEADS_* env on subprocess Cmd.Env adds it back explicitly.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: release gate PASS for be-c5p-firewall (be-m1u/47dcc380)
* fix(test): adapt store_unit_test.go for BEADS_DOLT_SERVER_PORT (rebase compat)
Tests that exercise applyConfigDefaults now clear BEADS_DOLT_SERVER_PORT (added
to main after this branch was cut) so the legacy BEADS_DOLT_PORT path runs as
intended. Without this, a GC-city environment with BEADS_DOLT_SERVER_PORT set
causes the tests to resolve an unexpected port.
* fix(dolt): stop BEADS_TEST_SERVER=1 from suppressing DefaultSQLPort detection
Restructure productionPortReasons so Rule 1 (cfg.ServerPort ==
DefaultSQLPort) is evaluated unconditionally; BEADS_TEST_SERVER=1 now only
suppresses the BEADS_PRODUCTION_PORT and dolt-server.port heuristics (Rules
2 and 3). isProductionPort loses its independent whole-function bypass and
becomes a thin wrapper. Update doc comments on both functions and the
buildTestModeProductionPortPanic fix list (which no longer lists
BEADS_TEST_SERVER=1 as a fix when port 3307 is the matched reason) to match.
Add TestApplyConfigDefaults_TestModeBlocksProdPort_EvenWithTestServerOptIn
asserting port 3307 is still refused with the opt-in set.
Also: drop a redundant explicit db.Close() in openServerConnection's
firewall-refusal path (already covered by the connReady defer), and fix two
comments that referenced a non-existent uniqueBenchDBName, pointing them at
the real generator (cmd/bd/template_test.go newTemplateBenchmarkStore) with
the correct benchdb_ name format.
Agent-Signature: claude-sonnet-medium on behalf of matt wilkie
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: matt wilkie <maphew@gmail.com>
* fix(list): suppress truncation hint in --json mode + lock-in label filter tests (be-acnquj)
Filter logic for --label/--label-any/--label-pattern/--title-contains was
already correct in tree (BuildIssueFilterClauses handles each case), so the
bug PM observed was a stale-binary artifact. To prevent regression, add a
unit test in TestListLabelFiltersAcnquj that exercises every acceptance
criterion:
AC#1 -l X returns ONLY beads with label X
AC#2 --label-any A,B (OR semantics)
AC#3 --label-pattern glob
AC#4 --title-contains case-insensitive
AC#5 -l NONEXISTENT returns empty
AC#6 AND/OR composition with multiple flags
For AC#7, gate printTruncationHint on jsonOutput so the trailing
"Showing N issues; more results matched..." line is suppressed in
--json mode. TestPrintTruncationHintJSONSuppression exercises both paths.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(filters): wire LabelPattern/LabelRegex through SQL builder (be-ucslk4)
Both fields had been on IssueFilter and set by the cobra layer for
`bd list`, but BuildIssueFilterClauses never consumed them — so
--label-pattern and --label-regex silently returned the full result
set instead of filtering. This was the live regression in be-ucslk4
(every agent's intake hook saw the entire open queue).
Fix:
- LabelPattern: convert glob (* / ?) to a SQL LIKE pattern, escape
literal %/_/| with ESCAPE '|', and AND-join an `id IN (SELECT
issue_id FROM <labels-table> WHERE label LIKE ? ESCAPE '|')`
subquery — same shape as the existing single-label clause.
- LabelRegex: pass through verbatim to a `label REGEXP ?` subquery.
- Helper globToLikePattern is unit-tested for stars, question marks,
literal wildcards, and the escape char itself.
Tests:
- filters_test.go: TestBuildIssueFilterClauses_LabelPattern (issues +
wisps tables), TestBuildIssueFilterClauses_LabelRegex,
TestGlobToLikePattern table test. These run without Dolt — they
pin the SQL emission and arg shape so the regression cannot recur.
- list_embedded_test.go: strengthened the existing label_pattern
subtest with negative-case assertions (feature/chore must NOT
match `back*`). The prior assertion only checked positive
inclusion, so it would pass even when the filter was a no-op.
Verified end-to-end on live city: --label-pattern, --label-regex,
--label, --label-any, --title-contains all return the correct counts
after the fix; trailing 'Showing N issues; more results matched...'
hint stays off stdout under --json.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: release gate PASS for be-ucslk4-dolt-ship (be-qd2vmt)
* docs(regression): mark BUG-28 label-pattern filter as fixed (PR #3971)
TestDiscovery_LabelPatternFilterDeadCode's assertions already described the
correct (filtered) behavior, so no assertion changes were needed — it now
passes against the candidate binary where it previously failed and
documented the dead-code bug. Update the test docstring and the DISCOVERY.md
BUG-28 entry/status table/index list to reflect the fix landing in this PR
rather than describing an open bug.
Agent-Signature: claude-sonnet-medium on behalf of matt wilkie
* fix(filters): dedupe globToLikePattern, pin test against live impl
TestGlobToLikePattern was pinning a byte-identical but unreachable copy of
globToLikePattern in internal/storage/issueops/filters.go — the production
caller is internal/storage/sqlbuild/filter.go:325 via BuildIssueFilterClauses.
An escaping regression in the sqlbuild copy (%, _, | handling) could have
shipped unseen since only the dead copy was tested.
Delete the issueops copy (and its now-unused "strings" import) and move
TestGlobToLikePattern into internal/storage/sqlbuild, in-package, so it
exercises the function BuildIssueFilterClauses actually calls.
Flagged by cross-vendor paired review (claude-opus + codex-gpt-5.6-sol) on
PR #3971.
Agent-Signature: claude-sonnet-medium on behalf of matt wilkie
* test(list): add store-level --label-regex coverage
The label REGEXP ? path was previously pinned only at the clause-string
level (TestBuildIssueFilterClauses_LabelRegex); no committed test exercised
it end-to-end against the embedded store, though a reviewer's ad-hoc probe
had confirmed it works. Add a label_regex subtest beside the existing
label_pattern case in TestEmbeddedList, following the same build-tag/env
gating (BEADS_TEST_EMBEDDED_DOLT=1), covering both a single-label regex and
an alternation across unrelated labels to confirm REGEXP semantics (not just
substring/glob matching).
Flagged by cross-vendor paired review (claude-opus + codex-gpt-5.6-sol) on
PR #3971.
Agent-Signature: claude-sonnet-medium on behalf of matt wilkie
* chore: drop contributor release-gate artifact from PR
release-gates/be-ucslk4-dolt-ship-gate.md is a contributor-process artifact
that doesn't belong in the upstream tree.
Flagged by cross-vendor paired review (claude-opus + codex-gpt-5.6-sol) on
PR #3971.
Agent-Signature: claude-sonnet-medium on behalf of matt wilkie
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: matt wilkie <maphew@gmail.com>
* feat(metadata): MergeMetadata — atomic single-key metadata merge
SlotSet did a read-modify-write across TWO transactions: GetIssue (tx 1),
metadata[key]=value in memory, then UpdateIssue (tx 2). Two concurrent SlotSet
calls — even on DIFFERENT keys — both read the same base metadata and each
wrote back its whole blob, so the second clobbered the first's key. SlotClear
had the same bug. Add MergeMetadata, which does the read-modify-write inside
ONE transaction (so a concurrent conflict is retried and re-reads), stores a
JSON value (nested objects/arrays, not just strings), and reimplement SlotSet
and SlotClear on top of it so they inherit the atomicity.
- issueops.MergeMetadataInTx / DeleteMetadataInTx: read the metadata (routed
issues/wisps; missing issue -> ErrNotFound), merge/delete the one key, and
write the whole object back THROUGH UpdateIssueInTx — so the operation keeps
everything the old SlotSet got from UpdateIssue (the EventUpdated history
event with actor attribution, the configured metadata-schema validation, and
updated_at), now atomic. The read and write share the caller's transaction,
so a concurrent merge of a different key is retried and re-read, never
clobbered.
- Storage.MergeMetadata implemented on DoltStore (perm withRetryTx +
DOLT_ADD(issues,events) + DOLT_COMMIT; wisp path no commit) and
EmbeddedDoltStore (withConn); forwarded on InstrumentedStorage; auto-promoted
on HookFiringStore; no-op on the configStore mock. SlotSet/SlotClear rebuilt
on it (a string value marshals to a JSON string, byte-compatible with the
historical rewrite).
- Cross-backend conformance covers MergeMetadata + atomic SlotClear; the
8-goroutine concurrent-no-clobber test proves the B1 fix on real Dolt, and
a test asserts the EventUpdated event and schema validation are preserved.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(concurrency): expose a per-row version on Issue reads (RowVersion)
The engine's internal row_lock column — a random non-zero int64 the engine
rewrites on every status/ownership-mutating write and on the generic update
path — was not surfaced on the public types.Issue. Consumers that wanted a
fine-grained optimistic-concurrency token had only updated_at, which is stored
at second granularity, so two same-second writes were indistinguishable. Expose
row_lock read-only as types.Issue.RowVersion so a caller can tell same-second
writes apart.
- types.Issue gains RowVersion int64 (json:"-": a Go-only concurrency token,
never on the CLI/export JSON wire — it is opaque and equality-only). Added
row_lock to the canonical sqlbuild.IssueBaseColumns and a matching scan target
in issueops.ScanIssueFrom; both engine write stacks, wisps, and the counts /
dependents parallel scans share those, so the field hydrates everywhere from a
single-point change. Read-only — no CAS/write behavior (that is a follow-up).
- Doc is precise about coverage: RowVersion changes on claim/close/unclaim and
the generic update path; it does NOT change on some direct-UPDATE paths
(restore, compaction text), which bump updated_at — so a complete change key
combines RowVersion with updated_at, status, and labels. A created row is
already non-zero (create stamps row_lock); 0 only appears on legacy rows
backfilled by migration 0054's DEFAULT 0.
- Tests: RowVersion hydrates on read and on the list path, changes on a mutating
write, distinguishes two same-second writes (identical updated_at, distinct
RowVersion), and never appears on any JSON surface.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(deps): return a typed error on dependency type-conflict
Adding a dependency between a pair that already has an edge of a different type
is a deterministic rejection, but the two engine write paths disagreed on how
they surfaced it: one returned a typed *DependencyTypeConflictError, the other a
plain fmt.Errorf string. So a caller could errors.As the conflict on one path
but had to string-match the message on the other. Make both paths return the
same typed error, and re-export the two dependency-conflict types on the public
beads package so `bd` (and the library's own call sites) classify by errors.As
instead of parsing message text.
- issueops.AddDependencyInTx now returns *domain.DependencyTypeConflictError for
the type-conflict case (byte-identical message — the struct's Error() is the
exact former string, so no string-matcher changes). The hierarchy/cross-type
case already returned *domain.DependencyHierarchyConflictError on both paths;
self-dependency and cycle are already typed sentinels.
- beads.go re-exports DependencyTypeConflictError and
DependencyHierarchyConflictError as type aliases, so errors.As against the
public type matches the value the engine returns.
- Tests assert errors.As + the four fields + the byte-identical message on both
write paths (permanent issues->issues and the wisp-source BeginTx/Commit seam),
and lock the re-exports; the deterministic conflict is returned immediately
(never retried as a transient serialization error).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(deps): emit dependency_added / dependency_removed events
`bd dep add` and `bd dep remove` recorded no event, so the events feed never
surfaced dependency changes even though the event types (types.EventDependencyAdded
/ EventDependencyRemoved) have existed since the original SQLite backend, which
emitted them on every add/remove. The emission was dropped when that backend was
removed for the Dolt-only migration and never ported to the current write paths.
Restore it on both Dolt write plumbings, matching the original shape (an events
row on the source issue: "Added dependency: <src> <type> <target>" /
"Removed dependency on <target>").
- issueops.AddDependencyInTx / RemoveDependencyInTx record the event via
RecordEventInTable on the source's event table (wisp-routed), on the genuine
add/remove only — the idempotent same-type re-add and the no-op remove of a
missing edge record nothing.
- The event is committed with the edge: DoltStore.AddDependency/RemoveDependency
DOLT_ADD `events`, and the transaction-path (RunInTransaction / batch /
graph-apply) methods mark the source's event table dirty (events or wisp_events)
so StageAndCommit commits it — without this the event row would dangle in the
working set.
- Emission is gated to the explicit dep-add/remove verb on both plumbings: the
proxied-server repo only records when the use-case sets DepInsertOpts.EmitEvent,
which create-with-deps (implicit parent-child / --deps / waits-for, via a direct
repo Insert) does not — so `bd create --parent` produces the same history on
either backend (the embedded create path via PersistDependencies likewise emits
nothing).
- Tests on both plumbings: add/remove emit exactly once and commit (verified via
`events AS OF 'HEAD'`), idempotent re-add and no-op remove emit nothing, wisp
sources route to wisp_events, and create-with-deps emits no dependency_added.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(close): optional ExpectedVersion CAS on CloseIssueChecked
CloseIssueChecked guards a close on is_blocked in-transaction, but a caller that
read an issue and then closes it has no way to say "only if it hasn't changed
since I read it" — a lost-update window. Add an optional compare-and-swap on the
row's version (the RowVersion / row_lock token): when the caller supplies an
ExpectedVersion, the close proceeds only if the row still has that version, else
it refuses with a typed ErrVersionMismatch. The version read and the close share
one transaction, so it is a true CAS with no read-then-write gap.
- storage.ErrVersionMismatch (re-exported as beads.ErrVersionMismatch) and
CloseIssueOptions.ExpectedVersion *int64 (nil disables the check; a pointer so
nil "no check" is distinct from "require version 0").
- issueops.CheckVersionInTx reads row_lock (wisp-routed; ErrNotFound on a missing
row) and returns ErrVersionMismatch on divergence. CloseIssueCheckedInTx runs
it FIRST — before the is_blocked guard and before the Force short-circuit, so
Force bypasses only the guard, never the CAS (the version check is an
orthogonal precondition). A mismatch returns before any write, so the tx rolls
back leaving the issue open with no `closed` event (atomic refuse).
- The CAS has two limbs: the read-side check catches a writer that committed
before the close began, and on the retry-wrapped permanent path a commit-time
row_lock conflict is replayed by withRetryTx so the re-read refuses.
- Tests on both stores: match closes, stale refuses atomically (still open, zero
closed events), a committed concurrent write invalidates a captured version,
nil is unchanged behavior, Force does not bypass, missing id → ErrNotFound,
wisp sources route to the wisps table, and an already-closed re-close with the
post-close version stays idempotent (Unchanged).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs(close): document RowVersion CAS coverage boundary on ExpectedVersion
Both adoption reviewers flagged that the public ExpectedVersion godoc and the
shared CloseIssueCheckedInTx doc could be misread as a full-row "unchanged"
check. RowVersion (row_lock) only tracks lifecycle/ownership writes
(status/assignee/started_at), so concurrent label, dependency, rename, or
is_blocked writes leave it untouched and are intentionally outside this CAS
boundary. Document that on both sites, grounded in the freshRowLock invariant.
Doc-only; no behavior change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* refactor(cli): bd close delegates to the engine's guarded close
The embedded `bd close` path ran its own is_blocked pre-check and then closed in
a separate call — a read-then-write TOCTOU that duplicated a guard the engine
provides atomically. The verb now builds CloseIssueOptions and delegates to
CloseIssueChecked, which runs the guard and the close in ONE transaction; the
CLI's duplicated guard is deleted. --force maps to Options.Force; a blocked
close refuses with the blockers named and the --force hint.
Behavior-preserving on purpose (verified against the previous binary):
- The engine guard now uses the exact historical CLI predicate — refuse only on
a LIVE direct blocker (blocked && len(blockers) > 0), not on the bare
denormalized is_blocked column. A transitively-blocked child (is_blocked
inherited from a blocked parent, zero direct blockers) still closes without
--force, and a stale is_blocked with since-closed blockers self-heals, exactly
as before.
- An already-closed issue stays an idempotent success: it still appears in the
--json array and the text report (same output shape), still exits 0, but no
longer produces a spurious closed->closed audit entry, a no-op commit, or the
real-close side effects (molecule auto-close, newly-unblocked, claim-next).
Tests cover: direct blocker refuses atomically (still open) and closes with
--force; transitively-blocked and stale-is_blocked beads close without --force;
already-closed emits in --json alone and in a mixed batch; idempotent exit 0 —
on the engine (both stores) and through the bd binary.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(update): UpdateIssueChecked — optional ExpectedVersion CAS on the update
UpdateIssue applies a field-map update with no optimistic-concurrency option, so
a caller that wants "update only if unchanged since I read it" had to
read-then-write — a lost-update window. Add UpdateIssueChecked: when the caller
supplies an ExpectedVersion (the RowVersion / row_lock token), the version read
and the update share ONE transaction, refusing with the typed ErrVersionMismatch
if the row has moved — a true compare-and-swap. Nil disables the check and is
byte-identical to UpdateIssue, which is left untouched on the hot path.
- storage.UpdateIssueOptions{ExpectedVersion *int64} (aliased as
beads.UpdateIssueOptions) + Storage.UpdateIssueChecked, mirroring the
CloseIssueChecked pattern: CheckVersionInTx runs first inside the same
transaction on every route — the permanent withRetryTx path, the wisp path,
AND the demote route (an update carrying no_history/wisp routes through the
demote flow; a pure demoteToWispInTx extraction lets the check compose
atomically with the row move — verified byte-identical to the old
DemoteToWisp).
- Implemented on DoltStore and EmbeddedDoltStore; InstrumentedStorage wraps it;
HookFiringStore fires on_update only on success (never on a refused update).
- Tests on both stores: match updates and bumps RowVersion; stale refuses
atomically (field unchanged, zero updated events); a committed concurrent
write invalidates a captured version; nil behaves exactly like UpdateIssue;
wisp match/stale; demote-route match (migrates + applies) and stale (still in
issues, unchanged); missing id → ErrNotFound; the hook decorator fires once on
success and never on refusal.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* refactor(cli): proxied bd close delegates to a library checked close
The proxied-server `bd close` path duplicated the close guard in the CLI:
it queried blockers via the dependency use-case, refused with its own message,
and then closed in a separate use-case call. Move the guard into the library —
IssueUseCase gains CloseIssueChecked / CloseWispChecked, which run the same
live-direct-blocker predicate (refuse only on blocked && len(blockers) > 0)
and then the untouched unchecked close — and thin the CLI verb to a single
delegated call. Both `bd close` paths now enforce the guard in the library and
emit the byte-identical refusal: the same storage.ErrCloseBlocked sentinel
("cannot close blocked issue: <id> is blocked by [...]") plus the
"(use --force to override)" hint.
- Guard and close run on the one pinned unit-of-work connection (the whole
close batch is a single transaction), and the guard is read-only and refuses
before any write — a refused id leaves the shared batch transaction clean,
and an all-refused batch skips the commit entirely, exactly as before.
- The unchecked CloseIssue / CloseWisp are untouched: internal closes (molecule
auto-close, gate closes, bd todo done) intentionally stay unguarded.
- Behavior-parity preserved: guard ordering (validate → epic-child → gate →
blocked), exit codes, JSON/batch shape, already-closed handling, audit fields,
and commit-message contents are unchanged; a transitively-blocked bead
(is_blocked with no direct open blocker) still closes without --force, and
--force still bypasses. The guard-failure diagnostic now uses the embedded
path's generic wording (further convergence; nothing matched the old text).
- Tests: use-case level on real Dolt (direct blocker refuses with blockers
named + still open, transitive-only closes, force closes, already-closed
parity, wisp refuse/force) plus the proxied CLI integration suite.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(review): cross-backend dependency-event + RowVersion parity
Maintainer review fixups for PR #4911 (adopt-pr review loop):
- RowVersion: the proxied/domain create (insertIssueRow) and generic Update
paths never stamped or rewrote row_lock, so an issue written through the
proxied-server backend read back RowVersion 0 on create and unchanged on
update -- a stale CAS token that violated the types.Issue.RowVersion
contract on that backend. Stamp a fresh non-zero row_lock on insert (and the
duplicate-key rewrite) and append RowLockClause() to the generic update,
mirroring the classic issueops insert/update invariant. Adds domain/db
regression tests proving CreateIssue/CreateWisp are non-zero and
UpdateIssue/UpdateWisp change it.
- Dependency events: embedded issueops AddDependencyInTx/RemoveDependencyInTx
recorded history unconditionally, so structural create-with-deps
(bd create --parent/--deps/--waits-for) and reparent (bd update --parent)
emitted dependency_added/removed on embedded but were silent on the proxied
backend, diverging issue history for identical commands. Gate the embedded
emit on EmitEvent and thread it through AddDependencyWithOptions /
RemoveDependencyWithOptions on both the store and transaction interfaces:
the plain AddDependency/RemoveDependency are the no-event structural default
(create-with-deps, reparent), while the explicit dep verbs (bd dep add/remove,
bd link, bd relate/unrelate) pass EmitEvent -- matching the proxied
DepInsertOpts.EmitEvent gate. DoltStore stages the events table only when an
event was actually written (GH#2455). Corrects the false
"parity with PersistDependencies" comments and adds symmetric embedded/proxied
dep-event coverage for create-with-parent/deps and structural removal.
- Retain iteration-1 fixups: heal molecules on already-closed re-close,
idempotent proxied checked-close, and documented public Storage growth.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(storage): drop always-constant event param from fireDependencyHookByID (unparam)
golangci-lint (latest, v2.12.2 in CI) unparam flags fireDependencyHookByID:
its `event` parameter always receives hooks.EventUpdate. The parameter was
already effectively constant before this PR (both base call sites passed
EventUpdate); this PR adds two more call sites, all EventUpdate. Remove the
dead parameter and hardcode hooks.EventUpdate at the single runner.Run call.
All four call sites pass hooks.EventUpdate, so behavior is unchanged; go
build, go vet, and a scoped golangci-lint run pass clean.
Maintainer fixup during adoption finalize (PR #4911).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Test User <test@test.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Eddie the Engineer <ci@beads.test>
PR #4232 changes toJSONValue() to always store --set-metadata values as
JSON strings (no more type inference), fixing GH#4146. Two test surfaces
outside PR CI still asserted the old inferred-number/bool behavior:
- cmd/bd/update_proxied_integration_test.go: update_set_metadata subtest
expected got["score"] == float64(99); now expects the string "99".
- tests/oracle-a: the update_set_metadata_raw_scalars DIVERGENCE PIN
comment and the deep-tier catalog entry update_set_metadata_incremental
(scenarios/enumerated.json) documented the old coercion rules. Both are
documentation only (PROVENANCE.md: "notes/pins are documentation the
runner ignores" for the differential harness), so updating the text is
the complete fix - there is no separate pin-regeneration step for these
fields.
Agent-Signature: claude-fable-5-high on behalf of maphew
- beads-release formula: drop the snapshot-docs step (ran the deleted
scripts/snapshot-release-docs.sh on the critical needs-chain); stamp-
changelog now needs update-vendorhash
- update-versions.sh: remove the mangled --skip-docs/docs-snapshot logic
and garbled usage text left by mid-line deletions
- pre-push hook: drop the snapshot-script remediation hint
- release.yml: collapse the prerelease branch; BEADS_REQUIRE_RELEASE_DOCS
has no consumer since check-docs-version.sh was deleted
- RELEASING.md / scripts/docs.md: describe the current pipeline (no
--versioned, no website/ outputs, no check-docs-version.sh)
- docs-mintlify.yml: paths filter now includes engdocs/** and the curated
root markdown files the docsync guard validates
- docs-render-check.sh: pin mint@4.2.687, fail closed when mint dies
without producing a broken-links report, parse report lines only, drop
dead extract_page_links(), fix the stale jq requirement; mint.sh pins
the same version
- nightly.yml: remove the deleted website measurement suite option
- CODEOWNERS: init-safety ADR gate follows the file to engdocs/adr/
- beads-docs skill: align with settled decision 6 — no pointer stubs,
moved pages get docs.json redirects; bd's printed paths are fixed at
the source
- CHANGELOG (edited line), FEDERATION-SETUP, README, examples, oracle-a,
.buildflags, gh-issue-to-pr formula: retarget moved-file references;
anchor the build/ gitignore pattern
Adds a second, opt-in tier to Oracle A: the enumerated catalog
(`tests/oracle-a/harness/scenarios/enumerated.json` — 523 entries, 501
deterministic) that sweeps the wider bd CLI surface as data. The curated set
stays the fast default (~2-7 min); `ORACLE_CATALOG=1` pulls in the catalog for a
deep run (~10-15 min).
- `catalog()` now loads `scenarios/enumerated.json` (harness-relative), and
`scoreboard` gates it on `ORACLE_CATALOG` — symmetric with `capture_golden` —
so a default run scores exactly the curated set with no no-golden noise.
- `run-oracle-a.sh` exports `ORACLE_CATALOG` through to both the capture and score
steps (only when non-empty; the tools treat any set value as "on").
- Floor assertion reworked. The old per-scenario "every create must exit 0 with an
id" check false-positived on the catalog's intentional error-path scenarios
(invalid priority/type, missing title, unknown flag, ...), whose creates SHOULD
exit non-zero, and aborted before scoring. It now aggregates: the reference must
produce >= 1 successful create (proving bd can init + create a workspace);
per-scenario error behavior is validated by the ref-vs-candidate diff, not the
floor.
Verified (bd-vs-bd on origin/main d23ba38f8): deep-tier IN-SCOPE 323/323 PASS, 0
divergences; fast tier remains 44/44. The 45 out-of-scope failures are
informational only (build-stamp / human-output deltas that always vary between two
builds — the in-scope predicate excludes them, e.g. the non-deterministic
`version --json` scenarios).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Oracle A is a black-box differential conformance rig for `bd`. It builds `bd`
from the merge-base with origin/main (REFERENCE, "before") and from the working
tree (CANDIDATE, "after"), runs a curated set of CLI contract scenarios against
both as real processes, and diffs every step — exit code, stderr, and JSON-aware
stdout — with volatile values (timestamps / UUIDs / actor / email) normalized.
Zero in-scope divergences is the gate: green means the change altered no
user-visible bd behavior on the covered surface.
The rig is purely additive and treats bd as a black box — it needs only cargo,
go, and a CGO toolchain, and works against any bd tree. It is useful for
reviewing any refactor (storage seam, serialization, output plumbing), not just
one feature.
Layout (all under tests/oracle-a/):
- run-oracle-a.sh — orchestrator: builds reference + candidate bd in isolated
worktrees, builds the harness, captures goldens from the
reference, scores the candidate, sets exit status.
- harness/ — a self-contained Rust conformance harness (MIT OR
Apache-2.0): capture_golden + scoreboard binaries over a
curated scenario set with JSON-aware, order-aware diffing.
- README.md — how to run, and the explicit what-green-does /
does-not-prove boundary.
Extracted from #4601, where it was used to prove the SQL backends byte-identical
to the Dolt reference; it stands on its own as a general regression gate.
Verified: the main-vs-main leak test is green — 44/44 in-scope scenarios, 0
divergences — on origin/main d23ba38f8.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(ready): honor filter.ExcludeTypes in GetReadyWorkInTx (GH#3397)
The --exclude-type CLI flag was silently ignored by bd ready. The CLI
correctly populated filter.ExcludeTypes, and the type's godoc promised
that values are "Appended to the default exclusion list", but the
no-Type branch of GetReadyWorkInTx built the NOT IN clause from the
hardcoded defaults only.
Merge user-supplied ExcludeTypes into the default exclusion list (with
dedup against defaults and empties) before building the placeholders.
This matches the pattern already used by issueops/filters.go and
dolt/queries.go for bd list.
Fixes GH#3397.
* fix(ready): --parent returns transitive descendants, not direct children only (GH#3396)
The SQL clause in GetReadyWorkInTx's ParentID branch was a one-hop join
against the parent-child dependency table, so only direct children
surfaced. The --parent help text in cmd/bd/ready.go:672 and the
WorkFilter.ParentID godoc (internal/types/types.go:1295) both promise
"descendants (recursive)".
Add a BFS helper GetDescendantIDsInTx alongside GetChildrenOfIssuesInTx
in blocked.go — BFS rather than a recursive CTE because the existing
children helper already iterates across both dependencies and
wisp_dependencies tables, and composing that inside a single CTE gets
ugly. The visited set breaks cycles and a depth cap (default 100,
matching the cycle-detection CTE elsewhere in issueops) guards against
malformed data.
Rewrite the ParentID branch in GetReadyWorkInTx to resolve descendants
via the new helper and OR that with the prior dotted-ID prefix match
(for implicit-parent IDs with no explicit parent-child dep), preserving
the original semantics for dotted IDs.
MoleculeID is deliberately left as one-hop — its inline comment
explicitly scopes it to "direct children" unlike ParentID.
Fixes GH#3396.
* Improve ready and list UX regressions (bd-main-typ)
* fix(list): make --ready flag use blocker-aware GetReadyWork semantics (GH#3478)
bd list --ready previously only filtered by status=open, showing issues
that bd ready correctly excluded as blocked. Now both commands use the
same GetReadyWork path, ensuring consistent results.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Add list ready blocker regression coverage (bd-qo1)
* Fix ready list review regressions
---------
Co-authored-by: Daniel Jasiński <daniel.jasinski@gmail.com>
Co-authored-by: kev <kglynn@pryoninc.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Removed bare first-party go install .../cmd/bd@latest guidance from docs,
website docs, plugin/npm docs, examples, and doctor hints.
- Standardized on:
- CGO_ENABLED=0 go install ... for server-mode only
- CGO_ENABLED=1 GOFLAGS=-tags=gms_pure_go go install ... for embedded-
capable
- Added scripts/check-go-install-guidance.sh and wired it into CI.
- Updated default.nix to use gms_pure_go instead of ICU flags.
Validation passed locally:
- make test
- golangci-lint run --build-tags=gms_pure_go ./...
- ./scripts/check-go-install-guidance.sh
- ./scripts/check-build-tags.sh
- go test -tags gms_pure_go ./cmd/bd/doctor
- doc flag check
* ci: install dolt binary on Linux and macOS test runners
Install dolt via the official install.sh on Linux and via Homebrew on
macOS so the main test job can exercise the ~24 test gates that
previously silently skipped on every PR when dolt was absent from PATH.
Matches the installation pattern already used by nightly.yml.
Docker-testcontainer gates (testDoltServerPort == 0 skips) remain
skipped — a known GitHub Actions hang documented in
scripts/repro-dolt-hang/INCIDENT-REPORT.md and nightly.yml:37-41
prevents enabling testcontainers here.
* test: require dolt binary under GITHUB_ACTIONS
Add testutil.RequireDoltBinary: skips when the dolt CLI is absent
locally but fails the test under GITHUB_ACTIONS. Replace bare
exec.LookPath("dolt") skip-gates with the helper so ~24 tests that
previously fell through silently in CI now run — and hard-fail if
the CI workflow ever drops the dolt install step.
tests/regression/regression_test.go uses an inline variant because
its gate lives in TestMain, and internal/remotecache/cache_test.go
duplicates the helper inline to avoid an import cycle
(testutil -> doltutil -> remotecache).
* fix(ci): drop ICU linkage from Linux/macOS test jobs (bd-sz5, GH#3506)
Align the CI test matrix with how we ship: all Go build/test invocations
now use -tags gms_pure_go, matching the Windows job, goreleaser, and the
install scripts. Remove libicu-dev / icu4c installs and CGO_* env setup
from ubuntu-latest and macos-latest jobs in ci.yml, plus nightly,
migration-test, and cross-version-smoke workflows.
Upstream dolthub/go-mysql-server#3506 confirmed -tags=gms_pure_go is the
sanctioned escape hatch; testing an ICU-linked config nobody installs was
wasting CI minutes and producing spurious duplicate-rpath / malformed
LC_DYSYMTAB linker warnings on macOS.
Update docs/ICU-POLICY.md to reflect that the CI matrix no longer
intentionally omits the tag; scripts/test-cgo.sh remains as the local
developer tool for exercising the ICU code path on demand.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(ci): add -tags gms_pure_go to test-helper go build shell-outs (bd-sz5)
Addresses review feedback on 7b36ab653. Several integration tests shell
out to `go build ./cmd/bd` (or `go build .`) from TestMain / t.Helper
setup functions. The outer `go test -tags 'integration gms_pure_go'`
tag does not propagate into these subprocesses, so the inner builds were
still trying to link ICU and failing with
`unicode/uregex.h: No such file or directory` in the nightly workflow.
Repo-wide audit of `exec.Command("go", "build", ...)` test helpers:
- internal/beads/beads_hash_multiclone_test.go (reviewer's cite)
- tests/regression/regression_test.go
- cmd/bd/protocol/helpers_test.go
- cmd/bd/doctor/dolt_e2e_test.go
- cmd/bd/{scripttest,import_prefix,explicit_db_nodb,init_embedded,
main,init,cli_fast,shared_server_integration,doctor_repair,
dolt_autostart_lifecycle_integration}_test.go
All 15 call sites now pass `-tags gms_pure_go`. `cmd/bd/preflight.go`
is production code (`bd preflight` user command), not a test helper,
and is intentionally left as-is.
Also narrow docs/ICU-POLICY.md "Common Mistakes" #3 -- libicu-dev is
needed only for local on-demand testing via scripts/test-cgo.sh, not
for CI test workflows (which no longer exercise the ICU path).
Verified: `go test -tags 'integration gms_pure_go' -run '^$' ./...`
passes cleanly from the worktree root (previously failed in
internal/beads).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(preflight): add -tags gms_pure_go to test/lint shell-outs (bd-sz5)
preflight is a beads-maintainer pre-PR tool. On dev machines without
ICU dev libraries installed, `bd preflight --check` was failing at the
`go test -short ./...` step with the same `unicode/uregex.h` error we
fixed in nightly CI (bd13871bd).
Apply the gms_pure_go tag consistently:
- runTestCheck: `go test -tags gms_pure_go -short ./...`
- runLintCheck: `golangci-lint run --build-tags=gms_pure_go ./...`
- Update the user-visible Command labels to match
- Update the static checklist printed by `bd preflight` (no --check)
so copy-pasted commands work on no-ICU machines
Matches the tag golangci-lint is now passed in CI, keeping local and
CI runs consistent.
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove all BEADS_NO_DAEMON env var handling from test files (dead code
since daemon removal in v0.50.0), delete stopRepoDaemon() and daemon
file guards from test setup, remove no-daemon config key from tests,
and update daemon→server wording in docs and comments.
37 files changed, -193 lines net.
Co-Authored-By: davetashner <davetashner@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Migrate 12 TestMain files to use EnsureDoltContainerForTestMain/TerminateDoltContainer
instead of the removed StartTestDoltServer/TestDoltServer API.
Replace testServer.IsCrashed()/CrashError() crash detection with standalone
testutil.DoltContainerCrashed()/DoltContainerCrashError() in 6 test files.
(bd-m7sy)
conditional-blocks was declared as AffectsReadyWork() but never included
in the computeBlockedIDs() SQL query, so conditionally-blocked issues
silently appeared in bd ready. Add conditional-blocks to both the
readiness and blocked-list SQL queries, matching blocks semantics:
while the precondition is open, the fallback is blocked.
Resolves the gap identified in PR #2026 (Option A).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Set BEADS_TEST_MODE=1 unconditionally in all 9 TestMain functions that
interact with Dolt, before the test server nil check. Previously, test
mode was only set when the test Dolt server started successfully — if it
failed, tests silently connected to production on port 3307 and created
testdb_/beads_* databases that were never cleaned up.
Also:
- Fix doctorTestServerPort() fallback from 3307 (production) to 0
- Add dolt_purge_dropped_databases() to both cleanup functions
- Add isolated test Dolt server to integration test TestMain which had
no server at all, causing bd init subprocess to hit production
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: beads/crew/lydia <steve.yegge@gmail.com>
bd init --prefix was creating databases named beads_<prefix> (e.g.,
beads_sky, beads_gt). Convention should use the rig name directly as
the database name. This aligns with gastown doltserver.go which
already uses just the rig name.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/polecats/onyx
Rig: beads
Role: polecats
- Use full FNV hex hash instead of % 100000 for database prefixes,
eliminating collision risk in parallel test runs
- Unify prefix strategy: discovery_test.go now uses FNV hash of
workspace dir (matching regression_test.go) instead of rand.Intn
- Add --all to snapshot() bd list call so closed issues are captured,
matching old bd export behavior
- Log warning when bd show returns unparseable JSON instead of silently
skipping issues
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
Discovered 5 more seams (BUG-43 through BUG-47):
- BUG-43: update --status deferred without --defer date creates
permanently deferred issue with no way to auto-wake.
- BUG-44: list --status "open,closed" silently returns empty —
comma-separated not parsed, treated as invalid literal.
- BUG-45: list --assignee alice --no-assignee contradictory flags
both applied, result is always-false predicate → empty.
- BUG-46: create --parent <closed-issue> accepted — child appears
in bd ready despite parent being closed (DECISION).
- BUG-47: dep add --type custom accepted by design (protocol test).
Code review: bd sync is deprecated no-op, doctor --fix has
multiple no-op checks.
Test results: 4 FAIL (confirm bugs), 1 PASS (protocol).
Total: 47 bugs catalogued, 36 failing discovery tests, 33 passing
protocol tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
Discovered 4 new seams (BUG-32 through BUG-35):
- BUG-32: bd stale --days -1 silently inverts logic (HIGH)
Negative days makes cutoff = tomorrow, so ALL issues appear stale.
- BUG-33: bd list --sort unknown_field is a silent no-op
Unknown sort fields fall through to default case (compare=0).
- BUG-34: Reparent parent to child creates parent-child cycle
bd update parent --parent child succeeds, both issues now
have parent-child deps pointing at each other.
- BUG-35: bd list --overdue works correctly (protocol test)
Also documents code review findings: createInRig skips prefix
validation, same-prefix rig ambiguity, batch import no UTC.
Test results: 3 FAIL (confirm bugs), 1 PASS (protocol invariant).
Total: 35 bugs catalogued, 26 failing discovery tests, 29 passing
protocol tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
New CLI-testable discoveries (all tests fail, confirming bugs):
- BUG-18: bd count vs bd list disagree on default filtering
- BUG-19: bare waits-for dep doesn't block readiness
- BUG-20: children of blocked parent not in bd blocked
Code-review-only findings documented in DISCOVERY.md:
- interactions table not cleaned on delete (orphaned records)
- PromoteFromEphemeral() non-atomic (silent data loss on crash)
- RunInTransaction() last-writer-wins on concurrent same-field updates
Updated DISCOVERY.md with all session 3 findings (BUG-16 through BUG-20).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
External blockers (external:project:capability) are silently ignored by
computeBlockedIDs() because they're not in the local activeIDs map. This
means issues with external blocking deps appear in bd ready and can be
closed without close guard intervention.
conditional-blocks deps are declared as AffectsReadyWork() in types.go
but the SQL in computeBlockedIDs() only queries WHERE type IN ('blocks',
'waits-for'), so conditional-blocks are never evaluated.
Both are DECISION-class: maintainer must decide whether these should gate
readiness or remain advisory.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
The regression test harness set only BEADS_DOLT_PORT (used by
applyConfigDefaults as a fallback), but main.go reads
BEADS_DOLT_SERVER_PORT via configfile.GetDoltServerPort() before
applyConfigDefaults runs. This caused all tests to silently connect
to the production Dolt server (port 3307) instead of the isolated
test server, producing "issue_prefix config is missing" errors for
every test.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
Update DISCOVERY.md with Phase 1-3 results:
- Session log entry for snapshot harness + full parity run
- BUG-1 and BUG-6 marked RESOLVED in test harness
- New BUG-15: labels missing from dependent sub-objects
- Detailed test infrastructure notes for snapshot harness
- Parity run results table (95+ PASS, 10 known bug FAIL,
3 new finding FAIL, 10 SKIP)
- BEADS_TEST_MODE bypass documentation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
Phase 2 normalization fixes discovered from first full regression run:
- Use unique prefix per workspace for Dolt database isolation
(beads_t<hash> instead of shared beads_test)
- Strip closed_at, close_reason from dep/dependent sub-objects
- Canonicalize parent field (raw issue ID → ISSUE-N)
- Handle dependents array same as dependencies (volatile fields,
dependency_type→type rename, ID canonicalization, sorting)
Results: 83 pass → 95+ pass (normalization-only failures eliminated)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
The bd export command was removed from main, breaking all 85 regression
tests. This replaces the export-based approach with a snapshot() method
that uses bd list --json + bd show --json to capture workspace state.
Changes:
- Add BEADS_TEST_MODE=1 to runEnv() for Dolt test isolation
- Implement snapshot() method: list all issues, show each, emit JSONL
- Rewrite export() to translate old flags and delegate to snapshot()
- Update compareExports() to call snapshot() directly
- Add normalization for show-vs-export field differences:
- Strip content_hash, events (show-only fields)
- Rename dependency_type → type in deps
- Strip thread_id, created_by from deps
- Handle metadata "{}" vs nil
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
Without BEADS_TEST_MODE=1, applyConfigDefaults() uses the shared "beads"
database instead of deriving unique testdb_<hash> names from temp paths.
This caused tracker tests to see 400+ pre-existing issues from prior runs.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/polecats/quartz
Rig: beads
Role: polecats
Jim Wordelman