Commit Graph

27 Commits

Author SHA1 Message Date
Wendy Breiding (She/Her) d1a55cc5fd Enhance csharp-refactoring skill documentation and tests
- Updated the skill description to clarify usage and restrictions for refactoring requests.
- Added new test cases for preserving serialized contracts in CustomerProfile.
- Introduced CustomerProfile class to support new test scenarios.
2026-09-15 09:18:35 -07:00
Abhitej John d450573372 Scope ConfigReader grader to its class
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8c45529b-2515-483d-9e51-e6c0b7cb6852
2026-09-15 09:18:35 -07:00
Wendy Breiding c797c40c25 Refactor ConfigReader body extraction method
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-09-15 09:18:35 -07:00
Wendy Breiding 31290d2917 Add file-contains check for Shipped.txt
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-09-15 09:18:35 -07:00
Abhitej John 040d33f282 Remove redundant refactoring eval checks
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8c45529b-2515-483d-9e51-e6c0b7cb6852
2026-09-15 09:18:35 -07:00
Abhitej John a9b8c41fa8 Add refactoring dormancy coverage
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8c45529b-2515-483d-9e51-e6c0b7cb6852
2026-09-15 09:18:35 -07:00
Abhitej John e03bcfbb1f Harden csharp refactoring eval graders
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8c45529b-2515-483d-9e51-e6c0b7cb6852
2026-09-15 09:18:35 -07:00
Abhitej John 5c80132e15 Fix csharp refactoring eval fixtures
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8c45529b-2515-483d-9e51-e6c0b7cb6852
2026-09-15 09:18:35 -07:00
Wendy Breiding (She/Her) 0f4fa510a0 Refactor Coupons class methods for clarity and consistency 2026-09-15 09:18:35 -07:00
Wendy Breiding aa64dbacd5 Update eval.yaml to include CollisionExamples.cs
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-09-15 09:18:35 -07:00
Wendy Breiding 6034e9ad11 Fix stdout_contains syntax in eval.yaml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-09-15 09:18:35 -07:00
Wendy Breiding db427d3b14 Update test configuration to check for 'Passed!' output
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-09-15 09:18:35 -07:00
Wendy Breiding (She/Her) 61ae0e116d Refactor graders in eval.yaml to improve consolidation checks for ConfigReader 2026-09-15 09:18:34 -07:00
Wendy Breiding 60193311fd Update Coupons.g.cs.template inclusion in project file
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-09-15 09:18:34 -07:00
Wendy Breiding 598a59d700 Rename AppSettingsHelper.ParseIntSetting to ParseIntegerSetting
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-09-15 09:18:34 -07:00
Abhitej John f4376065f3 Strengthen refactoring skill evaluations
Add powered, fixture-backed evals with public API, multi-targeting,
generated-code, and friend-assembly coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8c45529b-2515-483d-9e51-e6c0b7cb6852
2026-09-15 09:18:34 -07:00
Abhitej John 671c94f556 Fix eval grader config: file-contains/file-not-contains use 'value' not 'substring'
The Vally file-contains and file-not-contains graders require the config key
'value' (per the schema and all main eval.yaml files); 'substring' is rejected
with [invalid-grader-config]. Verified with `vally lint --eval-spec`: both evals
now lint with 0 errors, matching main's passing evals (only the benign
scoring-defaults + config-deprecation warnings that main evals also emit).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3c9f9823-7f2f-4f7d-9d1b-f2b9e7a20c60
2026-09-15 09:18:34 -07:00
Abhitej John 2bb7e36a59 Migrate csharp-refactoring and dotnet-breaking-changes evals to the Vally harness schema
Adapts both eval.yaml files from the legacy scenarios/assertions format to
the stimuli/graders/config schema introduced by #877 (Migrate LLM evals to
the Vally harness). Prompts and rubrics are preserved verbatim; assertions
map 1:1 to graders (file_contains->file-contains, run_command_and_assert->
run-command, output_matches->output-matches) and copy_test_files->
environment.files. Validated with `vally experiment run --dry-run`: both evals
now resolve and match the experiment filter (previously matched none).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3c9f9823-7f2f-4f7d-9d1b-f2b9e7a20c60
2026-09-15 09:18:34 -07:00
Abhitej John 003eb76a2d Drop LangVersion=latest from Billing fixtures for reproducibility
Rely on the SDK-default language version per pinned TFMs (net8.0;net10.0) so fixture compile behavior does not drift with the installed SDK. Both fixtures build clean (0 warnings/errors) without it. Addresses reviewer feedback.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 3c9f9823-7f2f-4f7d-9d1b-f2b9e7a20c60
2026-09-15 09:18:34 -07:00
Abhitej John 7900815c85 Add eval tests for csharp-refactoring and dotnet-breaking-changes skills
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-15 09:18:34 -07:00
Wendy Breiding (She/Her) 6eb6660dbb Refactor csharp-refactoring skill documentation and evaluation tests for clarity and consistency 2026-09-15 09:18:34 -07:00
Wendy Breiding (She/Her) a7af3486a7 Refactor csharp-refactoring documentation and evaluation tests for clarity and consistency 2026-09-15 09:18:34 -07:00
Wendy Breiding 7ba34bdafc Update regex pattern for output matching in eval.yaml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-09-15 09:18:33 -07:00
Abhitej John 7ae020cfbe Fix eval grader config: file-contains/file-not-contains use 'value' not 'substring'
The Vally file-contains and file-not-contains graders require the config key
'value' (per the schema and all main eval.yaml files); 'substring' is rejected
with [invalid-grader-config]. Verified with `vally lint --eval-spec`: both evals
now lint with 0 errors, matching main's passing evals (only the benign
scoring-defaults + config-deprecation warnings that main evals also emit).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3c9f9823-7f2f-4f7d-9d1b-f2b9e7a20c60
2026-09-15 09:18:33 -07:00
Abhitej John ef9e8d3379 Migrate csharp-refactoring and dotnet-breaking-changes evals to the Vally harness schema
Adapts both eval.yaml files from the legacy scenarios/assertions format to
the stimuli/graders/config schema introduced by #877 (Migrate LLM evals to
the Vally harness). Prompts and rubrics are preserved verbatim; assertions
map 1:1 to graders (file_contains->file-contains, run_command_and_assert->
run-command, output_matches->output-matches) and copy_test_files->
environment.files. Validated with `vally experiment run --dry-run`: both evals
now resolve and match the experiment filter (previously matched none).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3c9f9823-7f2f-4f7d-9d1b-f2b9e7a20c60
2026-09-15 09:18:33 -07:00
Abhitej John 674b386169 Drop LangVersion=latest from Billing fixtures for reproducibility
Rely on the SDK-default language version per pinned TFMs (net8.0;net10.0) so fixture compile behavior does not drift with the installed SDK. Both fixtures build clean (0 warnings/errors) without it. Addresses reviewer feedback.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 3c9f9823-7f2f-4f7d-9d1b-f2b9e7a20c60
2026-09-15 09:18:33 -07:00
Abhitej John 2c44302182 Add eval tests for csharp-refactoring and dotnet-breaking-changes skills
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-15 09:18:33 -07:00