Follow-up to the audit of this directory. Five claims were false; each is corrected
IN PLACE per claudedocs/README.md rather than silently edited out.
1. services-a-m-parameterised-client-analysis.md — "`model.findUnique` resolves to
`dbRead` in the service source directly" is FALSE on the path these tests drive,
and it cost a red batch: six tests across two files, all "expected null not to be
null", fifteen sites corrected to dbWrite. `resolveBlockInstance` takes its client
as a parameter and uses that local throughout; the `dbRead` spelling cited sits in
a function the tests never call. This is the highest-value correction in the set —
the document is cited three times by the handover, and the handover's own lesson is
that a table right 95% of the time is more dangerous than one obviously rough.
2. services-a-m-handover.md status line — 🔴 MY REGRESSION, introduced by #4280.
It named `perf/test-mock-migration-services-a-m` as "the reference". That is the
STALE remote this same document's "Landing state" section warns about: it predates
the rebase, its history diverges, and it still sits at 19e95f05b5. The status line
pointed a successor at the one branch the body says not to trust — added by the very
change whose purpose was making status claims checkable.
3. Same doc — "2 hold-outs remaining" is now 0 and "the seeding fix has not landed"
is now landed; both closed by #4281.
4. notifications-test-coverage-audit — the top three ranked gaps have all been closed
by five behavioural suites. Reframed from "NOT VERIFIED" to superseded, and kept
explicitly for its METHOD (blast-radius ranking, the fake-PoolClient recorder, the
assert-on-behaviour-not-strings critique) rather than its status.
5. typecheck-tests-gap §3 — "that import cannot resolve at runtime either" is wrong.
At the doc's own measurement commit the import was already `import type`, so it is
erased at transpile. The suite does execute zero tests, but because of a deliberate
`describe.skipIf` on KYSELY_PARITY_DATABASE_URL. The section's headline finding is
untouched.
Also repoints README.md's correction exemplar: it named runner-scouting, which does
not use a `(corrected …)` status line — its corrections live in a body blockquote.
Every citation here was verified before commit, and two of my own did not survive it:
"closed by #4293" was written of a PR that is still OPEN, and commit `632a3da432` —
which the handover names as its reference — does not resolve in this repository at
all, its branch having been deleted. Replaced with #3973's squash commit 533640662d,
which does resolve, and the dead SHA is now called out rather than repeated.
* style(claudedocs): apply Prettier to the existing docs
These files predate any formatting pass and none of them were Prettier-clean
(.md is not in .prettierignore, so the repo's own config already governs them).
Formatting is split out into its own commit so the status-line changes that
follow are readable as a diff rather than buried in reflowed emphasis markers
and realigned table separators.
No prose was changed. Reproduce with: npx prettier --write 'claudedocs/*.md'
* docs(claudedocs): give each doc a status line naming what it was true at
An audit of this directory got 6 of 11 statuses wrong, all in one direction: it
read each doc's self-reported status instead of re-checking the repo, so anything
that had moved since its doc was written stayed on the list unmoved.
Adds claudedocs/README.md stating the convention -- a doc asserting an outcome
names the commit or PR the claim was true at, so the status can be re-verified
rather than re-trusted -- and sweeps all 11 docs. Four statuses had changed:
- rca-appblocks-component-suite-flake: member #2 was fixed by #3654 the same day
the doc was written and still said (NOT fixed)
- typecheck-tests-gap: merged by #3868/#4189, but NOT wired -- nothing invokes
the gate, so it fires on nothing while reading as done
- turbopack-chunk-hash-collision: 'Next: 16.3.0' read as a blocker; the repo is
already on ^16.3.1, which re-rolls the collision without fixing it
- rca-readtime-metric-privacy-cpu: fix shipped as #3331, never stated
Corrections are made in place rather than silently edited out. Formatting was
split into the preceding commit so this diff is only the substance.
Zachary Lowden