skills/civitai__civitai
1
0
Fork 0
mirror of https://github.com/civitai/civitai.git synced 2026-09-20 22:08:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(apps): tighten (d)`s note — (a)/(b) do catch a WRONG added link

Browse Source 
The topic sentence said (a) and (b) "structurally cannot see an ADDITION",
then immediately qualified it to the case that matters. The unqualified half
was broader than the truth: (a) does catch an invented route, and (b) a store
route drawn with the wrong glyph. What they cannot see is an addition that is
itself well-formed — a route SUB_NAV_LINKS already carries, under that row`s
own icon — which is the gap (d) exists for. Says that now.

Comment-only. vitest --project unit <this file> -> 8 passed; eslint 0;
prettier clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzWdpMmKwGdvb2K3eSua8h
This commit is contained in:
ZacxDev
2026-09-07 00:15:14 -05:00
parent 684be6cc8f
commit 136fffd647
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/AppBlocks/__tests__/chromeNavAlignsWithSubNav.test.ts
+7 -6
View File
@@ -471,12 +471,13 @@ describe('the app-block chrome platform nav agrees with the store subnav', () =>
// (d) 🔴 THE LEDGER — the SET of routes the chrome links to, owned outright, so this
// fails when it GROWS or SHRINKS.
//
// (a) and (b) are PER-LINK and structurally cannot see an ADDITION: a new item
// pointing at a route `SUB_NAV_LINKS` already carries, wearing that row's own glyph,
// satisfies both. Nor does anything else here close the gap — the `expected glyphs`
// test enumerates the PLATFORM-NAV slice only, and (c) enumerates the two
// `/apps/installed` LABELS only. So an item added to the ⋮ overflow was invisible to
// every assertion in this file. Measured: adding `<ChromeSurfaceItem
// (a) and (b) are PER-LINK, so they catch an addition only when the added link is
// itself wrong — an invented route, or the store's route under the wrong glyph. A new
// item pointing at a route `SUB_NAV_LINKS` already carries, wearing that row's own
// glyph, satisfies both and is invisible to them. Nor does anything else here close
// the gap — the `expected glyphs` test enumerates the PLATFORM-NAV slice only, and (c)
// enumerates the two `/apps/installed` LABELS only. So an item added to the ⋮ overflow
// was invisible to every assertion in this file. Measured: adding `<ChromeSurfaceItem
// href="/apps/get-started" leftSection={<IconCode …/>}>Build apps</ChromeSurfaceItem>`
// to the overflow passed all 8 tests.
//