skills/chromedevtools__chrome-devtools-mcp
1
0
Fork 0
mirror of https://github.com/ChromeDevTools/chrome-devtools-mcp.git synced 2026-09-14 19:45:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: honor background when new_page uses isolatedContext (#2658)

Browse Source 
Fixes #2657

## Summary

- `BrowserContext.newPage()` in Puppeteer 25.9 supports the `background`
option, so pass it through in the isolated-context branch of
`McpContext.newPage()` instead of dropping it.
- Add a real-browser regression test asserting the original page keeps
focus when `new_page` is called with both `background: true` and
`isolatedContext`.

## Testing

- `npm run typecheck`
- `npm run test:no-build tests/tools/pages.test.ts`
- prettier + eslint pass
This commit is contained in:
baishiwen9
2026-09-04 09:12:37 +00:00
committed by GitHub
parent fc6a000856
commit f215c82d3f
2 changed files with 33 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/McpContext.ts
+1 -1
View File
@@ -344,7 +344,7 @@ export class McpContext implements Context {
ctx = await this.browser.createBrowserContext();
this.#isolatedContexts.set(isolatedContextName, ctx);
}
page = await ctx.newPage();
page = await ctx.newPage({background});
} else {
page = await this.browser.newPage({background});
}
tests/tools/pages.test.ts
+32
View File
@@ -430,6 +430,38 @@ describe('pages', () => {
});
});
it('keeps focus when background is true with isolatedContext', async () => {
await withMcpContext(async (response, context) => {
const originalPage = context.getPageById(1);
assert.strictEqual(originalPage, context.getSelectedMcpPage());
// Ensure original page has focus
await originalPage.pptrPage.bringToFront();
assert.strictEqual(
await originalPage.pptrPage.evaluate(() => document.hasFocus()),
true,
);
await newPage().handler(
{
params: {
url: 'data:text/html,<html></html>',
background: true,
isolatedContext: 'session-a',
},
},
response,
context,
);
// New page should be selected but original should retain focus
const mcpPage = context.getSelectedMcpPage();
assert.strictEqual(mcpPage.isolatedContextName, 'session-a');
assert.strictEqual(
await originalPage.pptrPage.evaluate(() => document.hasFocus()),
true,
);
assert.ok(response.includePages);
});
});
it('reuses the same context for the same isolatedContext name', async () => {
await withMcpContext(async (response, context) => {
await newPage().handler(