mirror of
https://github.com/boshu2/agentops.git
synced 2026-09-14 15:08:13 +08:00
Bo
937d6c8269
## What Add Codex-native `bulk-reader` and `code-writer` roles pinned to `gpt-5.6-luna`, opt-in role/config installation, and an opt-in native `PreToolUse` Bash adapter for the shared read-budget guard. Source-owned guidance and role files ship through the existing generated Codex bundle; the menu stays at 34 skills. The installed Codex 0.154 runtime can refuse covered shell calls before execution. The adapter enforces that predicate; slice discipline, target-only writes and receipt-only replies are role instructions, not an output filter or per-file sandbox. Native exact-definition hook trust remains required. ## Why Follow-up to #1137 and its [fresh author-distinct review](https://github.com/boshu2/agentops/pull/1137#issuecomment-5648513520). Correct the unverified statement that Codex has no refusal-capable hooks and provide real native delegation without subprocess model execution. This branch incorporates the isolated fixes in #1139 and targets main; land the repairs first. The fixes PR contains no Codex-native changes. Work and original acceptance are recorded in private BD `age-z25n`; `bd context --json` resolves the existing private Dolt store. [Design and live evidence](https://github.com/boshu2/agentops/blob/codex/context-budget-native/docs/design/codex-context-budget.md) records the runtime/config contracts, exact available model identifiers and published comparable rates, source paths, invocation, transcripts, accounting and limits. ## How I tested Current head: `40edb5f216b71bfa659627dca10fc0a9e04c1821`. Fresh author-distinct review: **Job2 native PASS; combined subject FAIL**. Reviewer context `01a09778-bef6-7883-880b-6764fdd783b9`, observed `gpt-6-astra`/ultra, authored no candidate code. All 52 changed paths have identical start/end manifests (SHA-256 `b1f13ca731658bc699838189f928535a386ab6de6b381b0419bb0f7ebdd88cdc`); acceptance `not_checked: []`. The native repeated-refusal naming finding is fixed and independently reproduced as resolved. Local final checks pass. [Hosted Validate CI](https://github.com/boshu2/agentops/actions/runs/34722978404) remains pending at this update; no merge is performed. Real Claude Opus follow-up closes plugin-name resolution, inherited hook invocation, complete reader coverage and observed parent/child content separation. **It also finds a remaining Claude writer failure:** two of three final workers ran their supplied check twice; a direct receipt used Markdown fences. This combined PR does not claim a full Claude writer PASS. Details, excluded failed attempts and exact identities are in the design note. - `./cli/bin/ao gate check --scope range:origin/main..HEAD`: 33 passed; the earlier unchanged registry run `./cli/bin/ao gate check --full` passed **73 gates** at `90c8b31ee` (historical receipt). `bash scripts/regen-all.sh --check`: all 11 checks passed. - Door9, hookless cold-start, doc-hook drift, shellcheck on five changed shell files, and Node syntax checks on both workflows plus the native config editor passed. - A7 Bats suites plus workflow and all native suites: **223 passed, zero skipped**. All **21 documentation-reference tests** and the strict full-document reference scan also pass after clarifying the native hook-manager terminology. - `bash tests/run-all.sh`: **10 passed, 0 failed, 1 skipped** (optional OL directory absent). This is the default static tier. - `bash scripts/validate-codex-install-bundle.sh`: passed, **34 skill packages**. Changelogs are identical; diff check clean. - Live registered reader: parent `01a09776-004f-79a0-af85-c75b472a1e68` used only spawn/wait; child `01a09776-3c38-7281-b582-01fef5101f17` was natively identified as bulk-reader/Luna/low. Six separate slices covered 1,772 lines without truncation; parent received five findings and coverage only. - Live registered writer: parent `01a09771-8908-7a00-b101-919b558cf8c1` used only spawn/wait; child `01a09771-bbbf-7232-add4-cc9ec55ad759` was code-writer/Luna/medium. Required reference, seven-line Bats target, receipt only, child check passed; coordinating parent independently ran Bats successfully without reading the target. - Live hook: native parent `01a09769-14d2-7c22-9b7d-50847de07c90`, final turn `01a09771-25f2-7830-830b-498d7ca1945e`, refused a 400-line cat before execution and allowed a three-line sed slice. Real payload is PreToolUse/Bash/tool_input.command; hashed deny ledger schema verified. An explicit session hook was trusted in `/hooks` for this proof. - Credentials-free native config/read and hooks/list probes verify personal and ordinary project discovery. Codex 0.154 reads linked-worktree project hooks from the primary checkout; `--project` now rejects linked worktrees before writing, with a real Git regression. Known failed: Claude writer check-once behavior and direct receipt fencing. Not checked: arbitrary hosted/MCP read interception; adversarial enforcement of role instructions; other runtime versions/accounts; cost savings, comparative latency or ADR-0002 value-proof clearance. Earlier reader attempts with an overlarge final slice or truncated aggregate output are disclosed and excluded from the successful coverage proof. ## Checklist - [x] `make build && make test` passes (if Go changes) — no Go changes; gate runner built once. - [x] No secrets or credentials in code - [x] Breaking changes documented — opt-in additions; unsupported linked-worktree hook installation refuses before mutation.
69 lines
2.7 KiB
Bash
Executable File
69 lines
2.7 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Opt-in personal/project installation of the source-owned Codex role templates.
|
|
# Runtime-resolved shared library, following repository installer convention.
|
|
# shellcheck disable=SC1091
|
|
source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/preamble.sh"
|
|
|
|
config_dir="${CODEX_HOME:-$HOME/.codex}"
|
|
agent_dir="$config_dir/agents"
|
|
case "${1:-}" in
|
|
'') ;;
|
|
--project) config_dir="$PWD/.codex"; agent_dir="$config_dir/agents"; shift ;;
|
|
--help|-h)
|
|
echo 'Usage: scripts/install-codex-context-agents.sh [--project]'
|
|
printf 'Default: %s. Restart Codex after installation.\n' "$agent_dir"
|
|
exit 0 ;;
|
|
*) echo "Unknown argument: $1" >&2; exit 2 ;;
|
|
esac
|
|
[ "$#" -eq 0 ] || { echo 'Unexpected arguments' >&2; exit 2; }
|
|
|
|
# Consume the same generated bundle shipped by the Codex plugin. Source owners
|
|
# are skills/agent-native/agents/*.toml; scripts/regen-all.sh owns this projection.
|
|
source_dir="$REPO_ROOT/skills-codex/agent-native/agents"
|
|
for role in bulk-reader code-writer; do
|
|
[ -f "$source_dir/$role.toml" ] || {
|
|
echo "Missing generated role $role; run bash scripts/regen-all.sh" >&2; exit 1;
|
|
}
|
|
done
|
|
require_cmd node
|
|
require_cmd codex
|
|
mkdir -p "$agent_dir"
|
|
config_dir="$(cd "$config_dir" && pwd -P)"
|
|
agent_dir="$config_dir/agents"
|
|
stage="$(mktemp -d)"
|
|
trap 'rm -rf "$stage"' EXIT
|
|
chmod 700 "$stage"
|
|
config="$config_dir/config.toml"
|
|
if [ -f "$config" ]; then cp -p "$config" "$stage/config.toml"; fi
|
|
node "$REPO_ROOT/scripts/lib/codex-agent-config.mjs" "$stage" "$agent_dir"
|
|
|
|
for role in bulk-reader code-writer; do
|
|
target="$agent_dir/$role.toml"
|
|
if [ -e "$target" ] || [ -L "$target" ]; then
|
|
if cmp -s "$source_dir/$role.toml" "$target"; then continue; fi
|
|
# Never follow an existing role symlink while replacing its destination.
|
|
backup="$(mktemp "$target.bak.XXXXXX")"
|
|
if ! cp -p "$target" "$backup"; then
|
|
rm -f "$backup"
|
|
echo "Cannot back up $target" >&2; exit 1
|
|
fi
|
|
fi
|
|
staging="$(mktemp "$agent_dir/.${role}.XXXXXX")"
|
|
if ! cp "$source_dir/$role.toml" "$staging" || ! chmod 644 "$staging" || ! mv -f "$staging" "$target"; then
|
|
rm -f "$staging"
|
|
echo "Cannot install $target" >&2; exit 1
|
|
fi
|
|
done
|
|
if ! cmp -s "$stage/config.toml" "$config"; then
|
|
if [ -e "$config" ] || [ -L "$config" ]; then
|
|
backup="$(mktemp "$config.bak.XXXXXX")"
|
|
cp -p "$config" "$backup"
|
|
fi
|
|
config_staging="$(mktemp "$config_dir/.config.toml.XXXXXX")"
|
|
cp "$stage/config.toml" "$config_staging"
|
|
chmod 600 "$config_staging"
|
|
mv -f "$config_staging" "$config"
|
|
fi
|
|
printf 'Installed bulk-reader and code-writer in %s. Restart Codex to discover them.\n' "$agent_dir"
|
|
printf 'Roles use gpt-5.6-luna. The read-budget hook is a separate opt-in installation.\n'
|