mirror of
https://github.com/boshu2/agentops.git
synced 2026-09-14 15:08:13 +08:00
62cc3b6ee0e66d6e3952c1f37ca8a0c3d715cfbb
18 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Bo
|
62cc3b6ee0 |
Clear the operations-layer alignment residuals (#1054)
Closes out the six residual items #1051 disclosed: terminology residue on non-authority surfaces, the eval command-surface fixture that failed when executed (#{3,4} -> #{3,5}), the vacuous retrieval-quality canary and the nightly job that ran it, the consumer-free dream config block and its exclusive helpers, the remaining knowledge-shaped writers moved to the scratch tier, and the MEMORY.md consumer audit. bin/ralph still resumes legacy .agents/ralph/ checkpoints so the documented backwards-compat contract holds without a migration; both paths and the outside-both refusal are now tested. Fresh author-distinct validation returned PASS with empty not_checked, after an earlier revision failed on a dangling nightly invoker and a back-compat test regression that were fixed and independently re-verified. Test-Removal-Reason: the dream config subsystem was deleted with its tests (operations-layer residuals) |
||
|
Bo
|
7265fda1b1 |
chore(test): migrate redundant os.Setenv to t.Setenv; lower isolation ratchet 22->12 (ag-k38x #bulk-migration-setenv) (#772)
## What Advances the test-isolation ratchet (`scripts/check-test-isolation.sh`, shipped in #699) by driving the `os.Setenv` baseline from **22 → 12**. Pure test-hygiene; no production-code change. `t.Setenv` auto-restores on cleanup **and** fails fast under `t.Parallel` — the raw `os.Setenv` form is the latent-flake landmine the ratchet exists to retire (cf. ag-jfzs). ## Sites migrated (10 eliminated) | File | Δ | How | |---|---|---| | `internal/config/config_test.go` | -6 | Collapse the `origX := os.Getenv(...)` + `defer os.Setenv(... restore)` block into 3× `t.Setenv` | | `internal/goals/measure_test.go` | -1 | Delete the redundant `origPath`/`defer os.Setenv` — the existing `t.Setenv("PATH","")` already auto-restores | | `cmd/ao/rpi_reliability_test.go` | -3 | Delete 3 redundant restore-defers wrapped around existing `t.Setenv` calls | ## The remaining 12 are intentional (not migratable) Documented inline in the ratchet script. They cannot use `t.Setenv`: - **TestMain** (`cmd/ao/main_test.go`, `internal/doctor/doctor_testmain_test.go`) — no `*testing.T` in scope (4) - **String-literal fixtures** (`internal/doctor/fix_cliconfig_test.go`) — `os.Setenv` appears inside generated test-program source, not a real call (2) - **Unset-semantics helpers** (`cmd/ao/handoff_test.go`, `internal/lifecycle/repo_readiness_test.go`, `internal/wiki/locator_test.go`) — these `os.Unsetenv`+restore vars; `t.Setenv` has no unset form (6) ## Verification - `bash scripts/check-test-isolation.sh` → `PASS … os.Setenv=12/12` - `go build ./...` ✓ · `go vet` (touched pkgs) ✓ - `go test ./internal/config/ ./internal/goals/` → 526 passed; touched cmd/ao tests → 3 passed Closes-scenario: ag-k38x#bulk-migration-setenv Bounded-context: BC5-Runtime Evidence: scripts/check-test-isolation.sh PASS 12/12 |
||
|
Bo
|
6bd788d8af |
chore(cli): gofmt sweep — 14 unformatted files (ag-ozac #gofmt-sweep) (#717)
Mechanical `gofmt -w` across `cli/` — fixes the 14 unformatted files surfaced by the **ag-tcf0** Go-cohesion audit. No logic change (diff is whitespace/grouping only; `git diff -w` is ~empty). ## Verification - `gofmt -l cli/` → empty - `go build ./...` → passes - Rebased onto current `origin/main` Closes-scenario: ag-ozac#gofmt-sweep Bounded-context: BC5-Runtime Evidence: cli/internal/eval/types.go |
||
|
Claude
|
1ab6bbb291 |
feat(goals): split summary into code-driven vs runtime-artifact slices
Closes the second half of ONE-TIME REPO FIX #3 from the nightly improvement routine. The `runtime-artifact` tag was already declared on `compile-freshness` and `compile-no-oscillation` in GOALS.md, but the goals runner ignored the tag — both gates fed straight into the headline `score`. Eight nightly digests in a row noted that this inflated morning summaries by ~+8 points whenever Dream had populated .agents/defrag/latest.json (a gitignored artifact that re-flips every run, so its pass propagates to nothing downstream). This change: 1. Extends `SnapshotSummary` with three lanes: - `score` (raw, headline) — unchanged for backward compat - `code_driven_*` — the same calculation restricted to goals without the `runtime-artifact` tag; this is the comparison number the nightly routine uses for fitness deltas - `runtime_artifact_*` — the slice tabulated separately so digests can still surface "RA was 0/8, now 8/8" without it contributing to a code-driven flip 2. Updates `computeSummary` to walk each measurement once and tally into both lanes simultaneously (no extra pass over the slice). 3. Adds a small `isRuntimeArtifact(tags)` predicate, case-insensitive and whitespace-tolerant, anchored to the canonical `runtime-artifact` tag string. 4. Tests cover: mixed corpus produces both Score and CodeDrivenScore correctly; all-runtime-artifact corpus keeps CodeDrivenScore at 0 without dividing-by-zero; the predicate handles nil/empty/Case- sensitivity/whitespace/multi-tag inputs. End-to-end: today's measurement now reports `code_driven_score: 91.43` alongside `score: 92.04`. Going forward the headline comparison goes off the code-driven number and runtime-artifact flips are reported in their own column. Backward-compatible JSON: existing readers that only consume `summary.score` keep working; new fields are additive. |
||
|
Claude
|
1ed5471576 |
feat(goals): SKIP exit code 77 + flywheel-compounding dormant precondition
Closes ONE-TIME REPO FIX #2 from the nightly improvement routine. Goes back to finding f-2026-04-30-002, which the flywheel-compounding gate itself has been pointing at in its FAIL output for the last six runs: "corpus dormant; flywheel-compounding has no signal to evaluate." Two coordinated changes: 1) Goals runner accepts skip-by-exit-code (`cli/internal/goals/measure.go`). Adds the SkipExitCode constant (77, autotools convention) plus an `isSkipExit` predicate. classifyResult is restructured around the ExitError shape so: - exit 0 → pass - context deadline / canceled → skip - exit 77 → skip - any other non-zero → fail Tests cover all three paths plus a parameterized non-77 fail check over exit codes 1, 2, 7, 76, 78, 99 to lock in that SKIP stays opt-in (no accidental skips from generic `set -e` killers). 2) flywheel-compounding gate (`scripts/check-flywheel-compounding.sh`) uses the new contract for the dormant-corpus precondition. When σ=0 AND ρ=0 AND citations_this_period=0 — the *fully dormant* state, distinct from σ=0 with citations elsewhere or ρ=0 with σ>0 — the gate now exits 77 with a SKIP message. The goals runner records that as `skip`, not `fail`, so the gate stops dragging the headline fitness number every nightly. The flywheel-compounding goal flipped from fail (-3 weight) to skip (excluded from numerator + denominator) on this branch's measurement, taking the headline from 89.66% to 92.04% (+2.38 pp) without any contract change. Falls back to the old FAIL diagnostics — including the multi-session verdict surface — once the corpus has any signal at all. The moment any session runs `ao lookup --cite`, the precondition stops firing and the gate measures real flywheel health again. Override available via FLYWHEEL_SKIP_DORMANT=0 for dev iteration. This is the *quarantine-by-precondition* path, preferred over a static `quarantined: true` flag in goals.yaml. Real regressions still surface the moment the corpus has signal; only "no signal at all" returns SKIP. End-to-end verification: - `cli/bin/ao goals measure --goal flywheel-compounding --json` → result="skip", output starts with "SKIP: σ=0 ρ=0 — corpus dormant…" - Full measure: failing=2 (was 3), skipped=1 (was 0), score 92.04% (was 89.66%). |
||
|
Boden Fuller
|
1a2ba1d56a | fix: bound goals measurement runtime | ||
|
Bo
|
5363a6384f |
Nightly 2026-04-30 — 10 productive cycles, 0 goal flips, +2 findings (#187)
* chore(triage): mark 4 stale items + 0 stale packets consumed 2026-04-30
https://claude.ai/code/session_01SoXsYqmcbntjCoLdiET8P9
* chore(evolve): stale-audit + dream-curator-degraded finding (2026-04-30)
Probe-stale rate this run = 66% (2/3 Dream packets), above the 30% MUST-spend
trigger and the 50% finding threshold. One stale-audit cycle spent here.
Marks 2 stale Dream packets consumed in next-work.jsonl:
- dream-df960e173c38bb56 — "Decompose skills/crank/SKILL.md to under 248-line
limit": claim is fictional; check-skill-size.sh thresholds are warn>500
fail>800; crank=660 → WARN, not FAIL. Same packet was probed stale on
nightly/2026-04-29 (see PR #177 digest).
- dream-476e66319e8d18d3 — "Investigate GitHub-only agentops-eval-advisory
failures": already addressed by merged PR #172 (commit
|
||
|
Bo
|
0f8dbee992 |
fix(nightly): ship 5 retrospective code fixes (truncate, standards gate, probed_stale_at, dream-probe, bd-install) (#156)
* fix(goals): preserve diagnostic tail in truncateOutput
Head-only truncation at 500 runes cut the operator hint off the end of
gate output. The 2026-04-26 nightly retrospective showed flywheel-
compounding's "sessions must use 'ao lookup --cite ...'" tail being lost
mid-word for verbose runs.
New shape: when input exceeds 500 runes, keep first 200 + truncation
marker + last 200 runes. Short inputs untouched. Verified against live
ao goals measure --json — six long-output gates (flywheel-proof,
hook-preflight, go-cli-tests, contract-compatibility, install-smoke,
flywheel-lifecycle) now expose both their failure label and their
trailing fix-it.
Source: 2026-04-26 nightly retro task 1.
* feat(ci): add standards-injector reference completeness gate
hooks/standards-injector.sh fails open when a mapped <lang> is missing
its reference file. That's how `.js` lost standards inject for weeks
until the 2026-04-26 nightly caught it. New gate parses the case
statement, asserts every mapped lang has skills/standards/references/
<lang>.md, and runs in pre-push and CI.
Wires:
- scripts/check-standards-injector-completeness.sh (new)
- scripts/pre-push-gate.sh (slot 27b under hook category)
- .github/workflows/validate.yml (parallel job + summary deps)
- tests/scripts/check-standards-injector-completeness.bats (6 cases:
happy path, missing-named, |-alternation, parser-empty, real-repo)
Removing skills/standards/references/javascript.md temporarily makes
the gate FAIL with a clear message; restoring makes it PASS.
Source: 2026-04-26 nightly retro task 2.
* feat(rpi): add probed_stale_at + probed_by + ao rpi mark-probed
When a nightly probes a queue item and finds it stale, the knowledge
dies in the digest — tomorrow's run re-probes the same item. Adds
optional probed_stale_at (RFC3339) and probed_by fields to the v1.3
item schema, the Go round-trip type, the schema-rows acceptance test,
and a new `ao rpi mark-probed --id=... --by=...` subcommand for future
nightlies to write these without hand-editing JSON.
- docs/contracts/next-work.schema.md (Item table)
- cli/internal/rpi/types.go (NextWorkItem fields, omitempty)
- cli/internal/rpi/types_test.go (round-trip + omitempty)
- cli/cmd/ao/rpi_mark_probed.go (new subcommand)
- cli/cmd/ao/rpi_mark_probed_test.go (4 cases)
- cli/docs/COMMANDS.md (regenerated)
- tests/scripts/check-next-work-schema-rows.bats (acceptance case)
validate-next-work-contract-parity.sh stays green.
Source: 2026-04-26 nightly retro task 3.
* fix(overnight): probe Dream packets for staleness before emit
Three nightlies in a row emitted the same two stale packets ("philosophy
doc", "next-work schema v1.3") because no gate verified the cited
surface wasn't already shipped. Curator now runs a 5-second tractability
probe against each candidate's TargetFiles + scripts/ refs in the
morning command before writing it. Conclusively-stale packets are
suppressed; the suppression is recorded as a dream-curator-suppressed
entry on the run summary so operators see what was skipped instead of a
silent gap.
- cli/cmd/ao/overnight.go (overnightSummary.CuratorSuppressed)
- cli/cmd/ao/overnight_packets.go (probeDreamPacketStaleness,
extractScriptsRef, suppression plumbed through
buildDreamMorningPacketPlans return)
- cli/cmd/ao/overnight_packets_test.go (suppression-on-existing-target +
emits-when-inconclusive integration tests)
Source: 2026-04-26 nightly retro task 4.
* chore(scripts): add install-bd.sh installer
bd has been "unavailable" in three consecutive nightly runs. Upstream
(steveyegge/beads) publishes signed cross-platform binaries for
darwin/linux on amd64/arm64. New installer detects the platform,
downloads the matching tarball, installs to ~/.local/bin/bd, and
verifies via `bd version`. Idempotent: short-circuits when the
requested version is already present (use --force to override).
- scripts/install-bd.sh (new, executable)
- tests/scripts/install-bd.bats (4 offline-safe cases)
Verified end-to-end on darwin/arm64: download + extract + verify all
green.
Source: 2026-04-26 nightly retro task 5.
* fix(ci): align bats stub and AGENTS table with new standards-injector gate
PR #156 introduced scripts/check-standards-injector-completeness.sh
without:
- adding a make_stub for it in tests/scripts/pre-push-gate.bats setup;
three pre-push-gate bats tests (404, 414, 415) used a FAKE_REPO that
lacked the new script and the gate fired "missing executable", so
status came back non-zero
- listing it in the AGENTS.md CI table; validate-ci-policy-parity.sh
diffs the table against validate.yml summary.needs and flagged 2
drift groups
Both gates pass locally now.
|
||
|
Boden Fuller
|
ee2af059c9 | test(goals): stabilize skipped timeout cases | ||
|
Boshu2
|
e442a414a8 |
fix(tests): push internal packages to 100% coverage with error-path tests
Add comprehensive error-path tests across all internal packages and cmd/ao. 14 packages now at 100% statement coverage; 4 remaining packages at 98-99% ceiling (provably unreachable defensive code). Key changes: - Add injectable test hooks (getwdFunc, marshalJSON, openFileFunc, etc.) to cover OS-level error branches unreachable on macOS - Cover deferred f.Close() errors, json.Marshal failures on typed structs, filepath.Walk errors, and crypto/rand.Read fallbacks - Add Linux-only build-constrained tests for filepath.Abs double-failure - Fix flaky TestMergeWorktree_UntrackedFileDirtyRepo (100ms -> 5s timeout) - Split ratchet_extra_test.go into per-source test files per convention - Remove duplicate test declarations from prior agent merges |
||
|
Boshu2
|
f2ddcfd900 | fix(release): restore coverage and learning coherence gates | ||
|
Test
|
51cc112b15 |
fix(cli): fix 23 bugs from comprehensive CLI audit
Address 7 HIGH, 11 MEDIUM, and 5 LOW severity bugs found during systematic audit of the ao CLI. All fixes use TDD — failing tests written first, then fixes applied. HIGH fixes: - Signal handler goroutine leak in goals/measure.go (done channel pattern) - Child process map lazy init race in goals/measure.go (eager init) - Windows filelock unguarded type assertion panic (2 files, safe assertion) - Pool chain event records wrong FromStatus (capture before mutation) - Scanner error swallowed in storage/file.go (check scanner.Err()) - Stream parser 64KB alloc per read (reuse buffer) - Context state race in classifyStreamResult (cache Err() result) MEDIUM fixes: - Unbounded stream buffer growth (1MB max line guard) - Pipe close error silently discarded (log via VerbosePrintf) - No-op cancel function on zero timeout (use context.WithCancel) - Pool recordEvent missing Sync (add f.Sync()) - paginate nil vs empty slice inconsistency (always return empty slice) - Worker pool panic causes deadlock (wrap fn in recover) - Nil Source pointer in writeArtifact (nil guard) - Negative/oversized weight parsing (clamp 1-10) - Worktree context not deferred (use defer cancel()) - Merge conflict error silently discarded (acknowledge explicitly) - Sandbox nil meta guard in team lifecycle validation LOW fixes: - Empty steer field accepted (skip if empty after trim) - Dead runID parameter (use blank identifier) - Nil file guard in writeStreamEvent - Env var precedence documented in toolchain.go - Windows filelock duplicate assertion (same fix as HIGH #2) Epic: ag-6bc (8 issues, 1 wave, 8 parallel workers) |
||
|
Boden Fuller
|
d6c4a04389 | evolve: cycle 35 -- go-cli-tests improved | ||
|
Boden Fuller
|
64afb4e98f | fix: bound curate verify smoke path | ||
|
Boden Fuller
|
273e0bd9c3 |
fix: address all 6 post-mortem findings from TDD hardening
Post-mortem council flagged 6 items. All resolved: 1. Clean dead code in measure_test.go — removed longOutput variable, order variable, fixed byte-vs-rune assertion to use len([]rune()) 2. Add goleak for goroutine leak detection — replaces fragile runtime.NumGoroutine + sleep heuristic with deterministic check 3. Assert AntiStars values in goals_init_test.go — not just count 4. Fix ci-local-release.sh invocation: ./scripts/ not bash scripts/ 5. Add MigrateV1ToV2 and killAllChildren package-level tests — previously at 0% coverage in internal/goals 6. Fix goroutine leak in rpi_status.go — same signal.Stop-without-close pattern found by audit of all signal.Notify sites (1/3 leaking) |
||
|
Boden Fuller
|
03c4849795 |
fix(goals): goroutine leak, nil Process guard, and TDD coverage expansion
TDD approach: wrote tests first proving 2 bugs (goroutine leak in runGoals signal handler, nil pointer panic in configureProcGroup Cancel closure), then fixed them. Added 15 new test cases covering detectGates, buildInteractiveGoalFile, directivesFromPillars, and multi-byte rune truncation. Wired check-skill-flag-refs.sh into release gate. Deleted untracked cli/AGENTS.md (redundant with ~/gt/AGENTS.md). |
||
|
Boden Fuller
|
9178f2b052 |
evolve: cycle 32 -- boost goals 97.8%->98.9%, search 95.9%->96.7%
goals: Add LoadHistory scanner error test (line >64KB), add gitSHA error path test (run outside git repo). search: Add BuildIndex deduplicate-terms-per-file test exercising the seen[term] continue path in indexFile. |
||
|
Boden Fuller
|
bed4d5ffcf |
test(rpi): add integration tests for RPI orchestrator, goals, and cmd/ao
Coverage improvements across the three most critical CLI subsystems: - cli/internal/goals/: 15.2% → 94.4% (target 50%, exceeded) - cli/internal/rpi/: 35.0% → 69.1% (target 65%, met) - cli/cmd/ao/: 46.9% → 48.8% (target 65%, partial — entry points need integration harness for further coverage) 14 new test files covering: goals validation/measure/drift/history/ snapshot, RPI worktree lifecycle, supervisor loop, phased engine phase runner, RPI status/cancel/cleanup commands. All existing tests pass, zero regressions. |