mirror of
https://github.com/boshu2/agentops.git
synced 2026-09-14 15:08:13 +08:00
ci(reconcile): wire factory-claim-ledger-strict into summary + AGENTS parity (Wave 1C followup — soc-lmww1)
The Wave 1C commit (82260e97) added the factory-claim-ledger-strict
advisory job to validate.yml but skipped two parity surfaces:
- summary.needs did not list it, so the aggregator never waited for it
and AGENTS↔workflow set-diff parity (validate-ci-policy-parity.sh)
flagged drift.
- AGENTS.md "CI Jobs" + "Advisory Job Triage SLAs" tables had no
matching row, so the validator's blocking/non-blocking set diff
reported the new job as a workflow-only addition.
Fix:
- validate.yml: add factory-claim-ledger-strict to summary.needs and to
the summary echo block. The job stays advisory because of its own
step-level continue-on-error: true.
- AGENTS.md: add it to the prose non-blocking list (line 72) and both
the SLA table and the CI Jobs table — the SLA table sets a 14d
triage SLA and explicitly defers blocking promotion to Wave 1E.
Validated:
- bash scripts/validate-ci-policy-parity.sh -> PASS (46 jobs;
6 non-blocking)
- bash scripts/test-ci-deterministic-gates.sh -> 4/4 pass
- bash tests/integration/test-factory-claim-ledger-ci-job.sh -> 6/6 pass
- bash scripts/check-factory-claim-ledger.sh -> PASS
This commit is contained in:
@@ -1380,7 +1380,7 @@ jobs:
|
||||
echo "File manifests found in evidence — overlap check delegated to file-manifest-overlap job"
|
||||
|
||||
summary:
|
||||
needs: [changes, doc-release-gate, smoke-test, hook-preflight, pre-push-gate-wired, agentops-eval-baseline-audit, standards-injector-completeness, validate-hooks-doc-parity, hook-output-schema-lint, validate-ci-policy-parity, validate-codex-runtime-sections, validate-codex-generated-artifacts, validate-codex-backbone-prompts, validate-codex-override-coverage, validate-codex-rpi-contract, validate-codex-lifecycle-guards, validate-headless-runtime-skills, embedded-sync, cli-docs-parity, registry-check, agentops-contract-canaries, eval-workbench-verify, agentops-eval-advisory, eval-skill-delta, shellcheck, markdownlint, security-scan, security-toolchain-gate, skill-integrity, skill-schema, skill-dependency-check, contract-compatibility-gate, memrl-health, plugin-load-test, retrieval-quality, go-build, windows-smoke, cli-integration, json-flag-consistency, file-manifest-overlap, doctor-check, skill-lint, learning-coherence, bats-tests, check-test-staleness, swarm-evidence]
|
||||
needs: [changes, doc-release-gate, smoke-test, hook-preflight, pre-push-gate-wired, agentops-eval-baseline-audit, standards-injector-completeness, validate-hooks-doc-parity, hook-output-schema-lint, validate-ci-policy-parity, validate-codex-runtime-sections, validate-codex-generated-artifacts, validate-codex-backbone-prompts, validate-codex-override-coverage, validate-codex-rpi-contract, validate-codex-lifecycle-guards, validate-headless-runtime-skills, embedded-sync, cli-docs-parity, registry-check, agentops-contract-canaries, eval-workbench-verify, agentops-eval-advisory, factory-claim-ledger-strict, eval-skill-delta, shellcheck, markdownlint, security-scan, security-toolchain-gate, skill-integrity, skill-schema, skill-dependency-check, contract-compatibility-gate, memrl-health, plugin-load-test, retrieval-quality, go-build, windows-smoke, cli-integration, json-flag-consistency, file-manifest-overlap, doctor-check, skill-lint, learning-coherence, bats-tests, check-test-staleness, swarm-evidence]
|
||||
runs-on: ubuntu-latest
|
||||
if: always()
|
||||
steps:
|
||||
@@ -1409,6 +1409,7 @@ jobs:
|
||||
echo "agentops-contract-canaries: ${{ needs.agentops-contract-canaries.result }}"
|
||||
echo "eval-workbench-verify: ${{ needs.eval-workbench-verify.result }}"
|
||||
echo "agentops-eval-advisory: ${{ needs.agentops-eval-advisory.result }}"
|
||||
echo "factory-claim-ledger-strict: ${{ needs.factory-claim-ledger-strict.result }}"
|
||||
echo "eval-skill-delta: ${{ needs.eval-skill-delta.result }}"
|
||||
echo "shellcheck: ${{ needs.shellcheck.result }}"
|
||||
echo "markdownlint: ${{ needs.markdownlint.result }}"
|
||||
|
||||
@@ -69,7 +69,7 @@ scripts/validate-go-fast.sh # Quick Go validation (build + vet + test)
|
||||
|
||||
## CI Validation — Passing the Pipeline
|
||||
|
||||
All pushes to `main` and PRs run `.github/workflows/validate.yml`. **Run checks locally before pushing.** The summary job gates on all checks except agentops-eval-advisory (non-blocking), security-toolchain-gate (non-blocking), doctor-check (non-blocking), check-test-staleness (non-blocking), and swarm-evidence (non-blocking).
|
||||
All pushes to `main` and PRs run `.github/workflows/validate.yml`. **Run checks locally before pushing.** The summary job gates on all checks except agentops-eval-advisory (non-blocking), security-toolchain-gate (non-blocking), doctor-check (non-blocking), factory-claim-ledger-strict (non-blocking), check-test-staleness (non-blocking), and swarm-evidence (non-blocking).
|
||||
Blocking policy list (must match the validate summary failset): every job in the CI table below except jobs marked `(non-blocking)`, including the seven `validate-codex-*` and `validate-headless-runtime-skills` jobs (split from the previous aggregated `codex-runtime-sections` job, soc-ltp2).
|
||||
|
||||
#### Advisory Job Triage SLAs (post-merge advisory policy, soc-z7qq)
|
||||
@@ -81,6 +81,7 @@ Advisory jobs run on every PR but their failure does NOT block merge. They surfa
|
||||
| **agentops-eval-advisory** | 7d | Release-blocking when stale: a failing eval-advisory older than 7d blocks the next `vX.Y.Z` tag until triaged. |
|
||||
| **security-toolchain-gate** | 14d | Open a `bd` issue with label `ci-advisory`. Network/install flake (item 40) is mitigated by 3-attempt exponential-backoff retry on the install step; only persistent toolchain or scanner regressions count toward the SLA. |
|
||||
| **doctor-check** | 30d | Open a `bd` issue tracking the stale CLI reference; prioritize when the next `cli/cmd/ao/**` PR lands. |
|
||||
| **factory-claim-ledger-strict** | 14d | soc-lmww1: validates `docs/contracts/factory-claim-ledger.json` against source-set anchors. Open a `bd` issue tagged `ci-advisory` when red for >14d; promotion to blocking is a Wave 1E concern. |
|
||||
| **check-test-staleness** | none (info-only) | Read the report; no merge or release impact. Item 33 — drift signal, not a gate. |
|
||||
| **swarm-evidence** | none (info-only) | Read the report; no merge or release impact. Item 34 — informational artifact validation. |
|
||||
|
||||
@@ -246,6 +247,7 @@ This repo has a canonical root worktree. It owns the common `.git` directory and
|
||||
| **embedded-sync** | `cli/embedded/` matches source files in `hooks/`, `lib/`, `skills/` | Editing hooks without running `cd cli && make sync-hooks` |
|
||||
| **eval-skill-delta** | Eval skill-delta CI gate validates skill-on vs skill-off delta infrastructure | Broken delta scorecard, missing harness, or malformed A/B config |
|
||||
| **eval-workbench-verify** | Behavioral eval workbench golden state, task scoring scripts, and suite structure | Broken workbench fixture, failing golden-state tests, or malformed eval suite JSON |
|
||||
| **factory-claim-ledger-strict** | Runs `bash scripts/check-factory-claim-ledger.sh` and emits a structured observation artifact mapping verdict + surfaces_touched per PR (soc-lmww1, Wave 1C) | Non-blocking (`continue-on-error: true`); claim-ledger drift surfaces in observation JSON. Promotion to blocking is the Wave 1E concern documented in-job |
|
||||
| **go-build** | `ao` binary builds; tests pass with `-race`; embedded hooks in sync; Go complexity budget | New function exceeds cyclomatic complexity 25 |
|
||||
| **hook-preflight** | All hooks have kill switches, no unsafe eval, timeouts present | Using `eval` or backtick substitution in hooks |
|
||||
| **hook-output-schema-lint** | Hooks emit only the safely-portable PreToolUse output subset both Claude and Codex CLI accept | Using `hookSpecificOutput.updatedInput` (silently dropped by Codex CLI 0.128.0+) |
|
||||
|
||||
Reference in New Issue
Block a user