2026-04-06 18:06:38 -07:00
|
|
|
import { existsSync, readFileSync, realpathSync, rmSync, statSync } from "node:fs";
|
|
|
|
|
import { dirname, join, resolve } from "node:path";
|
|
|
|
|
import { tmpdir } from "node:os";
|
|
|
|
|
import { spawnSync } from "node:child_process";
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
import { createWorktreePool, type WorktreePool } from "./generated/worktree-pool.js";
|
2026-04-02 19:49:05 +02:00
|
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
|
import type { ExtensionContext } from "@mariozechner/pi-coding-agent";
|
|
|
|
|
import {
|
|
|
|
|
getGitContext,
|
2026-04-06 18:06:38 -07:00
|
|
|
reviewRuntime,
|
2026-04-02 19:49:05 +02:00
|
|
|
runGitDiff,
|
|
|
|
|
startAnnotateServer,
|
|
|
|
|
startPlanReviewServer,
|
|
|
|
|
startReviewServer,
|
|
|
|
|
type DiffType,
|
|
|
|
|
} from "./server.js";
|
|
|
|
|
import { openBrowser } from "./server/network.js";
|
2026-04-06 18:06:38 -07:00
|
|
|
import { parsePRUrl, checkPRAuth, fetchPR } from "./server/pr.js";
|
|
|
|
|
import {
|
|
|
|
|
getMRLabel,
|
|
|
|
|
getMRNumberLabel,
|
|
|
|
|
getDisplayRepo,
|
|
|
|
|
getCliName,
|
|
|
|
|
getCliInstallUrl,
|
|
|
|
|
} from "./generated/pr-provider.js";
|
|
|
|
|
import { parseRemoteUrl } from "./generated/repo.js";
|
|
|
|
|
import { fetchRef, createWorktree, removeWorktree, ensureObjectAvailable } from "./generated/worktree.js";
|
2026-04-10 14:54:21 -07:00
|
|
|
import { loadConfig, resolveDefaultDiffType } from "./generated/config.js";
|
2026-04-02 19:49:05 +02:00
|
|
|
|
|
|
|
|
export type AnnotateMode = "annotate" | "annotate-folder" | "annotate-last";
|
|
|
|
|
export interface PlanReviewDecision {
|
|
|
|
|
approved: boolean;
|
|
|
|
|
feedback?: string;
|
|
|
|
|
savedPath?: string;
|
|
|
|
|
agentSwitch?: string;
|
|
|
|
|
permissionMode?: string;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export interface PlanReviewBrowserSession {
|
|
|
|
|
reviewId: string;
|
|
|
|
|
url: string;
|
|
|
|
|
waitForDecision: () => Promise<PlanReviewDecision>;
|
|
|
|
|
onDecision: (listener: (result: PlanReviewDecision) => void | Promise<void>) => () => void;
|
|
|
|
|
stop: () => void;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
|
|
|
let planHtmlContent = "";
|
|
|
|
|
let reviewHtmlContent = "";
|
|
|
|
|
|
|
|
|
|
try {
|
|
|
|
|
planHtmlContent = readFileSync(resolve(__dirname, "plannotator.html"), "utf-8");
|
|
|
|
|
} catch {
|
|
|
|
|
// built assets unavailable
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
try {
|
|
|
|
|
reviewHtmlContent = readFileSync(resolve(__dirname, "review-editor.html"), "utf-8");
|
|
|
|
|
} catch {
|
|
|
|
|
// built assets unavailable
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function delay(ms: number): Promise<void> {
|
|
|
|
|
return new Promise((resolvePromise) => setTimeout(resolvePromise, ms));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export function hasPlanBrowserHtml(): boolean {
|
|
|
|
|
return Boolean(planHtmlContent);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export function hasReviewBrowserHtml(): boolean {
|
|
|
|
|
return Boolean(reviewHtmlContent);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export function getStartupErrorMessage(err: unknown): string {
|
|
|
|
|
return err instanceof Error ? err.message : "Unknown error";
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
type AssistantTextBlock = { type?: string; text?: string };
|
|
|
|
|
|
|
|
|
|
type AssistantMessageLike = { role?: unknown; content?: unknown };
|
|
|
|
|
|
|
|
|
|
function isAssistantMessage(message: AssistantMessageLike): message is { role: "assistant"; content: AssistantTextBlock[] } {
|
|
|
|
|
return message.role === "assistant" && Array.isArray(message.content);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function getTextContent(message: { content: AssistantTextBlock[] }): string {
|
|
|
|
|
return message.content
|
|
|
|
|
.filter((block): block is { type: "text"; text: string } => block.type === "text")
|
|
|
|
|
.map((block) => block.text)
|
|
|
|
|
.join("\n");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export async function getLastAssistantMessageText(ctx: ExtensionContext): Promise<string | null> {
|
|
|
|
|
const entries = ctx.sessionManager.getEntries();
|
|
|
|
|
for (let i = entries.length - 1; i >= 0; i--) {
|
|
|
|
|
const entry = entries[i] as { type: string; message?: AssistantMessageLike };
|
|
|
|
|
if (entry.type === "message" && entry.message && isAssistantMessage(entry.message)) {
|
|
|
|
|
const text = getTextContent(entry.message);
|
|
|
|
|
if (text.trim()) return text;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function openBrowserForServer(serverUrl: string, ctx: ExtensionContext): void {
|
|
|
|
|
const browserResult = openBrowser(serverUrl);
|
|
|
|
|
if (browserResult.isRemote) {
|
|
|
|
|
ctx.ui.notify(`Remote session. Open manually: ${browserResult.url}`, "info");
|
|
|
|
|
} else if (!browserResult.opened) {
|
|
|
|
|
ctx.ui.notify(`Open this URL to review: ${serverUrl}`, "info");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
async function openBrowserAndWait<T>(
|
|
|
|
|
server: { url: string; stop: () => void },
|
|
|
|
|
ctx: ExtensionContext,
|
|
|
|
|
waitForResult: () => Promise<T>,
|
|
|
|
|
): Promise<T> {
|
|
|
|
|
openBrowserForServer(server.url, ctx);
|
|
|
|
|
|
|
|
|
|
const result = await waitForResult();
|
|
|
|
|
await delay(1500);
|
|
|
|
|
server.stop();
|
|
|
|
|
return result;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export async function startPlanReviewBrowserSession(
|
|
|
|
|
ctx: ExtensionContext,
|
|
|
|
|
planContent: string,
|
|
|
|
|
): Promise<PlanReviewBrowserSession> {
|
|
|
|
|
if (!ctx.hasUI || !planHtmlContent) {
|
|
|
|
|
throw new Error("Plannotator browser review is unavailable in this session.");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const server = await startPlanReviewServer({
|
|
|
|
|
plan: planContent,
|
|
|
|
|
htmlContent: planHtmlContent,
|
|
|
|
|
origin: "pi",
|
|
|
|
|
sharingEnabled: process.env.PLANNOTATOR_SHARE !== "disabled",
|
|
|
|
|
shareBaseUrl: process.env.PLANNOTATOR_SHARE_URL || undefined,
|
|
|
|
|
pasteApiUrl: process.env.PLANNOTATOR_PASTE_URL || undefined,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
openBrowserForServer(server.url, ctx);
|
|
|
|
|
server.onDecision(() => {
|
|
|
|
|
setTimeout(() => server.stop(), 1500);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
return {
|
|
|
|
|
reviewId: server.reviewId,
|
|
|
|
|
url: server.url,
|
|
|
|
|
waitForDecision: server.waitForDecision,
|
|
|
|
|
onDecision: server.onDecision,
|
|
|
|
|
stop: server.stop,
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export async function openPlanReviewBrowser(
|
|
|
|
|
ctx: ExtensionContext,
|
|
|
|
|
planContent: string,
|
|
|
|
|
): Promise<PlanReviewDecision> {
|
|
|
|
|
const session = await startPlanReviewBrowserSession(ctx, planContent);
|
|
|
|
|
return session.waitForDecision();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export async function openCodeReview(
|
|
|
|
|
ctx: ExtensionContext,
|
2026-04-06 18:06:38 -07:00
|
|
|
options: { cwd?: string; defaultBranch?: string; diffType?: DiffType; prUrl?: string } = {},
|
2026-04-10 03:22:01 +01:00
|
|
|
): Promise<{ approved: boolean; feedback?: string; annotations?: unknown[]; agentSwitch?: string; exit?: boolean }> {
|
2026-04-02 19:49:05 +02:00
|
|
|
if (!ctx.hasUI || !reviewHtmlContent) {
|
|
|
|
|
throw new Error("Plannotator code review browser is unavailable in this session.");
|
|
|
|
|
}
|
|
|
|
|
|
2026-04-06 18:06:38 -07:00
|
|
|
const urlArg = options.prUrl;
|
|
|
|
|
const isPRMode = urlArg?.startsWith("http://") || urlArg?.startsWith("https://");
|
|
|
|
|
|
|
|
|
|
let rawPatch: string;
|
|
|
|
|
let gitRef: string;
|
|
|
|
|
let diffError: string | undefined;
|
|
|
|
|
let gitCtx: Awaited<ReturnType<typeof getGitContext>> | undefined;
|
|
|
|
|
let prMetadata: Awaited<ReturnType<typeof fetchPR>>["metadata"] | undefined;
|
|
|
|
|
let diffType: DiffType | undefined;
|
|
|
|
|
let agentCwd: string | undefined;
|
2026-04-23 16:49:25 -07:00
|
|
|
let initialBase: string | undefined;
|
2026-04-06 18:06:38 -07:00
|
|
|
let worktreeCleanup: (() => void | Promise<void>) | undefined;
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
let worktreePool: WorktreePool | undefined;
|
2026-04-06 18:06:38 -07:00
|
|
|
let exitHandler: (() => void) | undefined;
|
|
|
|
|
|
|
|
|
|
if (isPRMode && urlArg) {
|
|
|
|
|
// --- PR Review Mode ---
|
|
|
|
|
const prRef = parsePRUrl(urlArg);
|
|
|
|
|
if (!prRef) {
|
|
|
|
|
throw new Error(
|
|
|
|
|
`Invalid PR/MR URL: ${urlArg}\n` +
|
|
|
|
|
"Supported formats:\n" +
|
|
|
|
|
" GitHub: https://github.com/owner/repo/pull/123\n" +
|
|
|
|
|
" GitLab: https://gitlab.com/group/project/-/merge_requests/42",
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const cliName = getCliName(prRef);
|
|
|
|
|
const cliUrl = getCliInstallUrl(prRef);
|
|
|
|
|
|
|
|
|
|
try {
|
|
|
|
|
await checkPRAuth(prRef);
|
|
|
|
|
} catch (err) {
|
|
|
|
|
const msg = err instanceof Error ? err.message : String(err);
|
|
|
|
|
if (msg.includes("not found") || msg.includes("ENOENT")) {
|
|
|
|
|
throw new Error(`${cliName === "gh" ? "GitHub" : "GitLab"} CLI (${cliName}) is not installed. Install it from ${cliUrl}`);
|
|
|
|
|
}
|
|
|
|
|
throw err;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
console.error(`Fetching ${getMRLabel(prRef)} ${getMRNumberLabel(prRef)} from ${getDisplayRepo(prRef)}...`);
|
|
|
|
|
const pr = await fetchPR(prRef);
|
|
|
|
|
rawPatch = pr.rawPatch;
|
|
|
|
|
gitRef = `${getMRLabel(prRef)} ${getMRNumberLabel(prRef)}`;
|
|
|
|
|
prMetadata = pr.metadata;
|
|
|
|
|
|
|
|
|
|
// Create local worktree for agent file access (--local is the default for PR reviews)
|
|
|
|
|
let localPath: string | undefined;
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
let sessionDir: string | undefined;
|
2026-04-06 18:06:38 -07:00
|
|
|
try {
|
|
|
|
|
const repoDir = options.cwd ?? ctx.cwd;
|
|
|
|
|
const identifier = prMetadata.platform === "github"
|
|
|
|
|
? `${prMetadata.owner}-${prMetadata.repo}-${prMetadata.number}`
|
|
|
|
|
: `${prMetadata.projectPath.replace(/\//g, "-")}-${prMetadata.iid}`;
|
|
|
|
|
const suffix = Math.random().toString(36).slice(2, 8);
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
const prNumber = prMetadata.platform === "github" ? prMetadata.number : prMetadata.iid;
|
|
|
|
|
sessionDir = join(realpathSync(tmpdir()), `plannotator-pr-${identifier}-${suffix}`);
|
|
|
|
|
localPath = join(sessionDir, "pool", `pr-${prNumber}`);
|
2026-04-06 18:06:38 -07:00
|
|
|
const fetchRefStr = prMetadata.platform === "github"
|
|
|
|
|
? `refs/pull/${prMetadata.number}/head`
|
|
|
|
|
: `refs/merge-requests/${prMetadata.iid}/head`;
|
|
|
|
|
|
|
|
|
|
// Validate inputs from platform API to prevent git flag/path injection
|
|
|
|
|
if (prMetadata.baseBranch.includes('..') || prMetadata.baseBranch.startsWith('-')) throw new Error(`Invalid base branch: ${prMetadata.baseBranch}`);
|
|
|
|
|
if (!/^[0-9a-f]{40,64}$/i.test(prMetadata.baseSha)) throw new Error(`Invalid base SHA: ${prMetadata.baseSha}`);
|
|
|
|
|
|
|
|
|
|
// Detect same-repo vs cross-repo (must match both owner/repo AND host)
|
|
|
|
|
let isSameRepo = false;
|
|
|
|
|
try {
|
|
|
|
|
const remoteResult = await reviewRuntime.runGit(["remote", "get-url", "origin"], { cwd: repoDir });
|
|
|
|
|
if (remoteResult.exitCode === 0) {
|
|
|
|
|
const remoteUrl = remoteResult.stdout.trim();
|
|
|
|
|
const currentRepo = parseRemoteUrl(remoteUrl);
|
|
|
|
|
const prRepo = prMetadata.platform === "github"
|
|
|
|
|
? `${prMetadata.owner}/${prMetadata.repo}`
|
|
|
|
|
: prMetadata.projectPath;
|
|
|
|
|
const repoMatches = !!currentRepo && currentRepo.toLowerCase() === prRepo.toLowerCase();
|
|
|
|
|
const sshHost = remoteUrl.match(/^[^@]+@([^:]+):/)?.[1];
|
|
|
|
|
const httpsHost = (() => { try { return new URL(remoteUrl).hostname; } catch { return null; } })();
|
|
|
|
|
const remoteHost = (sshHost || httpsHost || "").toLowerCase();
|
|
|
|
|
const prHost = prMetadata.host.toLowerCase();
|
|
|
|
|
isSameRepo = repoMatches && remoteHost === prHost;
|
|
|
|
|
}
|
|
|
|
|
} catch { /* not in a git repo — cross-repo path */ }
|
|
|
|
|
|
|
|
|
|
if (isSameRepo) {
|
|
|
|
|
// ── Same-repo: fast worktree path ──
|
|
|
|
|
console.error("Fetching PR branch and creating local worktree...");
|
|
|
|
|
await fetchRef(reviewRuntime, prMetadata.baseBranch, { cwd: repoDir });
|
|
|
|
|
await ensureObjectAvailable(reviewRuntime, prMetadata.baseSha, { cwd: repoDir });
|
|
|
|
|
await fetchRef(reviewRuntime, fetchRefStr, { cwd: repoDir });
|
|
|
|
|
|
|
|
|
|
await createWorktree(reviewRuntime, {
|
|
|
|
|
ref: "FETCH_HEAD",
|
|
|
|
|
path: localPath,
|
|
|
|
|
detach: true,
|
|
|
|
|
cwd: repoDir,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const wtRepoDir = repoDir;
|
|
|
|
|
exitHandler = () => {
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
try {
|
|
|
|
|
for (const entry of worktreePool?.entries() ?? []) {
|
|
|
|
|
spawnSync("git", ["worktree", "remove", "--force", entry.path], { cwd: wtRepoDir });
|
|
|
|
|
}
|
|
|
|
|
} catch {}
|
|
|
|
|
if (sessionDir) try { rmSync(sessionDir, { recursive: true, force: true }); } catch {}
|
2026-04-06 18:06:38 -07:00
|
|
|
};
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
worktreeCleanup = async () => {
|
2026-04-06 18:06:38 -07:00
|
|
|
if (exitHandler) { process.removeListener("exit", exitHandler); exitHandler = undefined; }
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
if (worktreePool) await worktreePool.cleanup(reviewRuntime);
|
|
|
|
|
if (sessionDir) try { rmSync(sessionDir, { recursive: true, force: true }); } catch {}
|
2026-04-06 18:06:38 -07:00
|
|
|
};
|
|
|
|
|
process.once("exit", exitHandler);
|
|
|
|
|
} else {
|
|
|
|
|
// ── Cross-repo: shallow clone + fetch PR head ──
|
|
|
|
|
const prRepo = prMetadata.platform === "github"
|
|
|
|
|
? `${prMetadata.owner}/${prMetadata.repo}`
|
|
|
|
|
: prMetadata.projectPath;
|
|
|
|
|
if (/^-/.test(prRepo)) throw new Error(`Invalid repository identifier: ${prRepo}`);
|
|
|
|
|
const cli = prMetadata.platform === "github" ? "gh" : "glab";
|
|
|
|
|
const host = prMetadata.host;
|
|
|
|
|
// gh/glab repo clone doesn't accept --hostname; set GH_HOST/GITLAB_HOST env instead
|
|
|
|
|
const isDefaultHost = host === "github.com" || host === "gitlab.com";
|
|
|
|
|
const cloneEnv = isDefaultHost ? undefined : {
|
|
|
|
|
...process.env,
|
|
|
|
|
...(prMetadata.platform === "github" ? { GH_HOST: host } : { GITLAB_HOST: host }),
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
console.error(`Cloning ${prRepo} (shallow)...`);
|
|
|
|
|
const cloneResult = spawnSync(cli, ["repo", "clone", prRepo, localPath, "--", "--depth=1", "--no-checkout"], { encoding: "utf-8", env: cloneEnv });
|
|
|
|
|
if ((cloneResult.status ?? 1) !== 0) {
|
|
|
|
|
throw new Error(`${cli} repo clone failed: ${(cloneResult.stderr ?? "").trim()}`);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
console.error("Fetching PR branch...");
|
|
|
|
|
const fetchResult = await reviewRuntime.runGit(["fetch", "--depth=200", "origin", fetchRefStr], { cwd: localPath });
|
|
|
|
|
if (fetchResult.exitCode !== 0) throw new Error(`Failed to fetch PR head ref: ${fetchResult.stderr.trim()}`);
|
|
|
|
|
|
|
|
|
|
const checkoutResult = await reviewRuntime.runGit(["checkout", "FETCH_HEAD"], { cwd: localPath });
|
|
|
|
|
if (checkoutResult.exitCode !== 0) {
|
|
|
|
|
throw new Error(`git checkout FETCH_HEAD failed: ${checkoutResult.stderr.trim()}`);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Best-effort: create base refs so agent diffs work
|
|
|
|
|
const baseFetch = await reviewRuntime.runGit(["fetch", "--depth=200", "origin", prMetadata.baseSha], { cwd: localPath });
|
|
|
|
|
if (baseFetch.exitCode !== 0) console.error("Warning: failed to fetch baseSha, agent diffs may be inaccurate");
|
|
|
|
|
await reviewRuntime.runGit(["branch", "--", prMetadata.baseBranch, prMetadata.baseSha], { cwd: localPath });
|
|
|
|
|
await reviewRuntime.runGit(["update-ref", `refs/remotes/origin/${prMetadata.baseBranch}`, prMetadata.baseSha], { cwd: localPath });
|
|
|
|
|
|
|
|
|
|
exitHandler = () => {
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
if (sessionDir) try { rmSync(sessionDir, { recursive: true, force: true }); } catch {}
|
2026-04-06 18:06:38 -07:00
|
|
|
};
|
|
|
|
|
worktreeCleanup = () => {
|
|
|
|
|
if (exitHandler) { process.removeListener("exit", exitHandler); exitHandler = undefined; }
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
if (sessionDir) try { rmSync(sessionDir, { recursive: true, force: true }); } catch {}
|
2026-04-06 18:06:38 -07:00
|
|
|
};
|
|
|
|
|
process.once("exit", exitHandler);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
agentCwd = localPath;
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
worktreePool = createWorktreePool(
|
|
|
|
|
{ sessionDir: sessionDir!, repoDir, isSameRepo },
|
|
|
|
|
{ path: localPath, prUrl: prMetadata.url, number: prNumber, ready: true },
|
|
|
|
|
);
|
2026-04-06 18:06:38 -07:00
|
|
|
console.error(`Local checkout ready at ${localPath}`);
|
|
|
|
|
} catch (err) {
|
|
|
|
|
console.error("Warning: local worktree creation failed, falling back to remote diff");
|
|
|
|
|
console.error(err instanceof Error ? err.message : String(err));
|
|
|
|
|
if (exitHandler) { process.removeListener("exit", exitHandler); exitHandler = undefined; }
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
if (sessionDir) try { rmSync(sessionDir, { recursive: true, force: true }); } catch {}
|
2026-04-06 18:06:38 -07:00
|
|
|
agentCwd = undefined;
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
worktreePool = undefined;
|
2026-04-06 18:06:38 -07:00
|
|
|
worktreeCleanup = undefined;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
// --- Local Review Mode ---
|
|
|
|
|
const cwd = options.cwd ?? ctx.cwd;
|
|
|
|
|
gitCtx = await getGitContext(cwd);
|
|
|
|
|
const defaultBranch = options.defaultBranch ?? gitCtx.defaultBranch;
|
2026-04-10 14:54:21 -07:00
|
|
|
diffType = options.diffType ?? resolveDefaultDiffType(loadConfig());
|
2026-04-06 18:06:38 -07:00
|
|
|
const result = await runGitDiff(diffType, defaultBranch, cwd);
|
|
|
|
|
rawPatch = result.patch;
|
|
|
|
|
gitRef = result.label;
|
|
|
|
|
diffError = result.error;
|
2026-04-23 16:49:25 -07:00
|
|
|
// Remember which base the initial diff was computed against so it can
|
|
|
|
|
// be forwarded to the server below. Only matters when the caller
|
|
|
|
|
// overrode the detected default; otherwise it matches gitCtx already.
|
|
|
|
|
initialBase = defaultBranch;
|
2026-04-06 18:06:38 -07:00
|
|
|
}
|
|
|
|
|
|
2026-04-02 19:49:05 +02:00
|
|
|
const server = await startReviewServer({
|
|
|
|
|
rawPatch,
|
|
|
|
|
gitRef,
|
2026-04-06 18:06:38 -07:00
|
|
|
error: diffError,
|
2026-04-02 19:49:05 +02:00
|
|
|
origin: "pi",
|
|
|
|
|
diffType,
|
|
|
|
|
gitContext: gitCtx,
|
2026-04-23 16:49:25 -07:00
|
|
|
initialBase,
|
2026-04-06 18:06:38 -07:00
|
|
|
prMetadata,
|
|
|
|
|
agentCwd,
|
feat: stacked PR review — PR switching, scope toggling, multi-PR posting (#620)
* feat(shared): add isSameProject, PR stack types, and PR list provider
Extends PRRef/PRMetadata with defaultBranch, PRStackInfo, PRStackTree,
PRStackNode, PRDiffScope, and PRListItem types. Adds isSameProject()
for owner/repo validation on PR switching. Adds fetchPRStack() and
fetchPRList() dispatch functions (GitHub-only for now, GitLab stubs).
Includes 9 new tests for isSameProject covering GitHub, GitLab, and
cross-platform scenarios.
For provenance purposes, this commit was AI assisted.
* feat(shared): add GitHub PR stack tree walking and PR list fetching
Implements fetchGhPRStack() which walks up/down the PR stack via
GraphQL, resolving numbers and titles for each node in the chain.
Collapses queryPRsByHead/queryPRsByBase into a single queryPRsByRef
helper. Adds fetchGhPRList() using gh pr list. Fixes GHE support
by removing hostnameArgs from fetchGhPRList (--repo already handles
GHE). Filters jq "null" string from defaultBranch detection.
For provenance purposes, this commit was AI assisted.
* feat(shared): fetch defaultBranch for GitLab MRs
Queries the project's default_branch via glab API so getPRStackInfo
can detect stacked MRs on GitLab. Best-effort — caught errors fall
back to undefined.
For provenance purposes, this commit was AI assisted.
* feat(shared): add PR stack detection and full-stack diff module
New pr-stack module with:
- getPRStackInfo(): detects stacked PRs from baseBranch vs defaultBranch
- getPRDiffScopeOptions(): generates layer/full-stack scope options
- runPRFullStackDiff(): computes diff from default branch to HEAD
- resolvePRFullStackBaseRef(): resolves origin/main or local main
- checkoutPRHead(): fetches and checks out a PR head in a worktree
- buildMinimalStackTree(): builds UI tree from stack info
Includes 13 tests covering ref resolution, branch fallbacks, and
GitLab ref formats.
For provenance purposes, this commit was AI assisted.
* feat(shared): add worktree pool for per-PR agent isolation
Creates a session-scoped pool of git worktrees — each PR visited
during a stacked review gets its own isolated checkout. Agents run
in their PR's worktree undisturbed by PR switches. Handles
deduplication of concurrent ensure() calls for the same PR.
Includes 11 tests covering caching, cross-repo restrictions, GitLab
ref formats, and cleanup.
For provenance purposes, this commit was AI assisted.
* feat(shared): add diffScope/prUrl to agent jobs, branch diff type
Adds prUrl and diffScope optional fields to AgentJobInfo so agent
findings carry the PR and scope context they were launched under.
Exports new pr-stack and worktree-pool modules from package.json.
Adds 'branch' to DefaultDiffType union for branch diff as default.
For provenance purposes, this commit was AI assisted.
* feat(ui): add PR annotation fields, Popover, and SearchableSelect
Extends CodeAnnotation with prUrl, prNumber, prTitle, prRepo, and
diffScope fields for stacked PR attribution. Adds shared Popover
wrapper around radix-ui. Adds SearchableSelect for filterable
dropdown lists (used by PR selector).
For provenance purposes, this commit was AI assisted.
* feat(ui): add branch diff as default option, new Git settings tab
Adds 'Branch' as a fourth default diff type option in both the
first-run dialog and settings panel. Moves the default diff type
setting from the Display tab to a new Git tab in review mode.
Updates config store validators to accept 'branch'.
For provenance purposes, this commit was AI assisted.
* feat(server): add prUrl/diffScope plumbing to agent jobs and prompts
Threads prUrl and diffScope through the agent job lifecycle so
findings carry the PR and scope they were generated under. Adds
full-stack prompt branch to codex-review and tour-review — when
in full-stack mode, the diff is inlined in the prompt instead of
telling the agent to run git diff. Re-exports isSameProject and
new PR provider functions from server/pr.ts.
For provenance purposes, this commit was AI assisted.
* feat(server): add stacked PR support to Bun review server
Adds PR switching, layer/full-stack scope toggling, PR list caching,
worktree pool integration, and multi-PR platform posting to the Bun
review server. Key additions:
- /api/pr-diff-scope: switch between layer and full-stack diffs
- /api/pr-list: cached PR list for the current repo
- /api/pr-switch: in-place navigation between PRs in a stack
- /api/pr-action: targetPrUrl support for multi-PR posting
- /api/file-content: full-stack branch for hunk expansion
- prSwitchCache/prStackTreeCache for session-scoped caching
- diffScope tagging on agent job completion
- Scope guard: returns 400 on full-stack diff failure instead of
overwriting the working diff with empty content
For provenance purposes, this commit was AI assisted.
* feat(ai): pass cwd to Claude agent SDK for worktree support
Forwards the working directory to the Claude agent provider so
agents run in the correct worktree when reviewing stacked PRs.
For provenance purposes, this commit was AI assisted.
* feat(pi): add stacked PR support to Pi server (Bun parity)
Mirrors all stacked PR features from the Bun server:
- PR switching, scope toggling, PR list, multi-PR posting
- prSwitchCache/prStackTreeCache with initial PR seeding
- diffScope/prUrl plumbing in agent jobs
- Worktree pool creation and lifecycle
- Full-stack file-content resolution matching Bun's guard structure
- targetPrUrl support on /api/pr-action
Hoists worktreePool declaration to outer scope in plannotator-browser
to fix TS18004 scoping error. Updates vendor.sh for new shared modules.
For provenance purposes, this commit was AI assisted.
* feat(hook): create worktree pool for PR review sessions
Creates a worktree pool when opening a PR review with --local,
seeding it with the initial PR's checkout. Integrates pool cleanup
into server shutdown. Passes the pool to startReviewServer for
agent isolation during PR switching.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add hooks for PR stack, context, and annotations
- useAnnotationFactory: stamps prUrl/prNumber/prTitle/prRepo/diffScope
onto annotations, only when viewing a stacked PR
- usePRStack: handles scope selection and PR switching with loading state
- usePRContext: adds URL-change detection to prevent stale-fetch race
when switching PRs (discards in-flight responses for previous PR)
For provenance purposes, this commit was AI assisted.
* feat(review-editor): add stacked PR UI components
- PRSelector: searchable dropdown for switching between PRs in a repo
- PRSwitchOverlay: loading animation during PR switch
- StackedPRLabel: stack tree popover with scope selector and PR navigation
- ReviewSubmissionDialog: multi-PR submission dialog with per-target
status, orphaned findings section with copy-as-markdown, and
partial failure retry
For provenance purposes, this commit was AI assisted.
* feat(review-editor): multi-PR export with heading hierarchy
Updates exportReviewFeedback for multi-PR sessions:
- Groups annotations by prUrl, then by file within each PR
- Uses proper heading hierarchy (## for files, ### for annotations
in multi-PR mode)
- Detects single-PR mismatch (annotations from a different PR than
the current view) and uses annotation-level PR context
- Adds diffScope labels per PR group when present
Includes 5 new tests: multi-PR headings, single-PR mismatch,
diffScope labels, and non-stacked annotation handling.
For provenance purposes, this commit was AI assisted.
* feat(review-editor): integrate stacked PR into sidebar, diff panel, and agents
- ReviewSidebar: groups annotations by PR in multi-PR sessions,
shows PR headers with annotation counts
- ReviewDiffPanel: filters annotations by prUrl and diffScope so
only matching annotations appear in the diff gutter
- ReviewStateContext: adds prDiffScope to shared review state
- ReviewAgentJobDetailPanel: shows diffScope in job detail
- PRSummaryTab: shows stack info in PR summary
- index.css: PR switch shimmer and overlay animations
For provenance purposes, this commit was AI assisted.
* feat(review-editor): wire stacked PR into main review app
Integrates all stacked PR features into the review editor:
- PR stack state management (prStackInfo, prStackTree, prDiffScope)
- applyPRResponse: shared handler for PR switch and scope toggle,
preserves active file index on scope changes
- Multi-PR platform posting via Promise.allSettled with parallel
requests, partial failure retry, and per-target status tracking
- ReviewSubmissionDialog replaces inline dialog JSX
- useAnnotationFactory stamps PR context onto annotations
- keepalive on /api/feedback to survive tab closure
- Proper try/catch/finally on handlePlatformAction
For provenance purposes, this commit was AI assisted.
* docs: add stacked PR review documentation
Updates AGENTS.md, code-review command docs, and AI code review
guide with stacked PR review capabilities.
For provenance purposes, this commit was AI assisted.
* fix(server): stamp prNumber/prTitle/prRepo on agent findings
Agent annotations only had prUrl and diffScope, missing prNumber,
prTitle, and prRepo. When agent findings were the only annotations
for a PR target in the submission dialog, the target rendered as
#0 with no title. Now resolves full PR context from prSwitchCache
at job completion and stamps all five fields. Both Bun and Pi.
For provenance purposes, this commit was AI assisted.
* feat(ui): rename diff options — "Committed" replaces "Branch" / "Current PR Diff"
Consolidates two confusing committed-diff options into one:
- Settings/first-run: "Committed" — "Everything you've committed on this branch"
- Mid-session switcher: "Committed changes" (replaces both "vs main" and "Current PR Diff")
Uses merge-base under the hood (matches GitHub PR behavior). Removes
the two-dot branch diff from the UI — it stays in the runtime DiffType
union for backwards compat. Old "branch" values in config/cookies are
silently upgraded to merge-base.
Git settings tab now uses radio cards with descriptions instead of
a cramped segmented control. First-run dialog descriptions rewritten
in plain language — no git commands.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): rename client-side "PR Diff" labels to "Committed changes"
DiffTypePicker.tsx had a hardcoded "PR Diff" override for merge-base
when the base picker is present. exportFeedback.ts also used "PR Diff"
in export labels. Both now say "Committed changes" to match the
server-side label and settings UI.
For provenance purposes, this commit was AI assisted.
* fix(server): discover stack UI for root PRs targeting the default branch
Root PRs (baseBranch === defaultBranch) were excluded from stack
detection because getPRStackInfo returned null. Now the server
always fetches the stack tree in PR mode. If the tree reveals
descendant PRs, prStackInfo is retroactively set with source
"tree-discovered", enabling the stack UI, scope selector, and
PR navigation from the root of a stack.
Both Bun and Pi servers updated. Adds "tree-discovered" to the
PRStackInfo source union.
For provenance purposes, this commit was AI assisted.
* fix(review-editor): derive diff scope from annotations, not UI state
The export function now reads diffScope from annotations instead of
the prReviewScope parameter. Fixes two issues:
1. Agent job "Copy All" showed the wrong scope when the user switched
between layer/full-stack after launching the agent
2. Mixed-scope annotations produced a confusing "layer, full-stack"
comma-joined label instead of grouping by scope
Extracts renderScopedGroups helper for scope-aware grouping — used
by both single-PR and multi-PR export paths. When annotations share
one scope, it appears in the header. When mixed, annotations are
grouped under ## Layer / ## Full-stack headings.
Includes 4 new tests: uniform scope derivation, mixed scope grouping,
single scope header, and prReviewScope override prevention.
For provenance purposes, this commit was AI assisted.
* fix(server): add tree-discovered stack fallback to pr-switch handler
The initial-load path upgrades prStackInfo for root PRs when the
stack tree reveals descendants, but the pr-switch handler was missing
this logic. The server now sends correct prStackInfo after switching
to a root-of-stack PR. Both Bun and Pi.
Also removes stale prReviewScope dependency from agent job panel's
copyAllText useMemo.
For provenance purposes, this commit was AI assisted.
* fix: extract resolveStackInfo helper, fix stack UI on non-stacked PRs
Extracts the tree-discovered stack fallback into resolveStackInfo()
in pr-stack.ts — eliminates 4 copies of the same logic across Bun
startup, Bun pr-switch, Pi startup, and Pi pr-switch.
Fixes StackedPRLabel showing on every PR: the check now counts
non-default-branch nodes (> 1) instead of all nodes (> 1). Without
this, every PR showed a "Stack (1 PR)" popover because the tree
always has at least [defaultBranch, currentPR].
For provenance purposes, this commit was AI assisted.
* fix(review-editor): don't re-open already-succeeded PR tabs on retry
On partial failure retry, openUrls was pre-seeded with URLs from
previously succeeded targets, causing those PR pages to re-open
in the browser alongside newly succeeded ones. Now starts empty —
only URLs from the current attempt are opened.
For provenance purposes, this commit was AI assisted.
* refactor(review-editor): extract PR session state into usePRSession hook
Consolidates 5 independent useState calls (prMetadata, prStackInfo,
prStackTree, prDiffScope, prDiffScopeOptions) into a single
usePRSession hook with atomic updatePRSession callback.
Replaces two identical 5-line setter blocks (initial load and
applyPRResponse) with single updatePRSession calls. All ~60 consumer
sites unchanged — same variable names via destructuring.
For provenance purposes, this commit was AI assisted.
2026-04-27 22:07:55 -07:00
|
|
|
worktreePool,
|
2026-04-02 19:49:05 +02:00
|
|
|
htmlContent: reviewHtmlContent,
|
|
|
|
|
sharingEnabled: process.env.PLANNOTATOR_SHARE !== "disabled",
|
|
|
|
|
shareBaseUrl: process.env.PLANNOTATOR_SHARE_URL || undefined,
|
2026-04-17 22:21:49 -07:00
|
|
|
pasteApiUrl: process.env.PLANNOTATOR_PASTE_URL || undefined,
|
2026-04-06 18:06:38 -07:00
|
|
|
onCleanup: worktreeCleanup,
|
2026-04-02 19:49:05 +02:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
return openBrowserAndWait(server, ctx, server.waitForDecision);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export async function openMarkdownAnnotation(
|
|
|
|
|
ctx: ExtensionContext,
|
|
|
|
|
filePath: string,
|
|
|
|
|
markdown: string,
|
|
|
|
|
mode: AnnotateMode,
|
|
|
|
|
folderPath?: string,
|
feat(annotate): support HTML files and URL annotation (#545)
* fix(annotate): sanitize dangerous link protocols in markdown renderer
Block javascript:, data:, and vbscript: URLs in InlineMarkdown link
rendering. Links with dangerous protocols render as plain text instead
of clickable anchors. Uses a blocklist approach so existing links with
custom protocols (obsidian://, vscode://, Windows C:\ paths) continue
to work.
For provenance purposes, this commit was AI assisted.
* feat(annotate): add HTML-to-markdown and URL-to-markdown utilities
- html-to-markdown.ts: Turndown wrapper with GFM table rule, strips
script/style/noscript tags
- url-to-markdown.ts: Jina Reader (free, returns markdown) with
fetch+Turndown fallback. Warns on Jina failure, auto-skips Jina for
local/private URLs (localhost, 192.168.*, 10.*, etc.)
- config.ts: add jina setting and resolveUseJina() with priority chain
--no-jina flag > PLANNOTATOR_JINA env > config.json > default true
For provenance purposes, this commit was AI assisted.
* feat(annotate): support HTML files and URLs in annotate command
Extend the annotate subcommand to accept .html/.htm local files
(converted via Turndown) and https:// URLs (fetched via Jina Reader
with fetch+Turndown fallback). URL content is fetched terminal-side
before opening the browser.
Add --no-jina global flag to disable Jina Reader per-invocation.
Add 10MB file size guard for local HTML files.
For provenance purposes, this commit was AI assisted.
* feat(annotate): HTML files in folder browser and on-demand conversion
- Widen file browser glob to include .html/.htm alongside markdown
- handleDoc converts HTML files via Turndown on demand when selected
- hasMarkdownFiles accepts optional extensions param for folder validation
- Add sourceInfo field to annotate server API response
- Add _site/, public/, out/, .docusaurus/, .jekyll-cache/,
storybook-static/ to FILE_BROWSER_EXCLUDED
For provenance purposes, this commit was AI assisted.
* feat(annotate): source attribution badge for HTML/URL annotations
Show a subtle badge in DocBadges displaying the URL hostname or HTML
filename for converted content. Thread sourceInfo from API response
through App → Viewer → DocBadges.
Also update Pi extension to accept HTML-only folders in annotate mode.
For provenance purposes, this commit was AI assisted.
* test: update CLI help text assertion for HTML/URL annotate support
For provenance purposes, this commit was AI assisted.
* fix(annotate): address PR review findings
Security:
- Add project-root containment check for HTML files in /api/doc handler
using exported isWithinProjectRoot() from resolve-file.ts
- Blocks path traversal via absolute paths or ../ escapes
isLocalUrl fixes:
- Add bracketed IPv6 loopback [::1] detection
- Replace hostname.startsWith('10.') with proper IPv4 regex to avoid
matching public hostnames like 10.example.com
Revert Pi extension change:
- Pi server doesn't implement HTML file browsing or conversion yet
- Keep Pi folder validation markdown-only until both implementations
are updated per CLAUDE.md guidelines
Cleanup:
- Remove dead el.children || el.childNodes fallback in table rule
- Extract hostnameOrFallback() helper to @plannotator/shared/project
replacing duplicated try/catch IIFEs in DocBadges and index.ts
For provenance purposes, this commit was AI assisted.
* feat(annotate): Pi extension HTML annotation parity
Bring the Pi extension to full parity with the Bun server for HTML
annotation support:
- Vendor html-to-markdown and url-to-markdown via vendor.sh
- walkMarkdownFiles now scans .html/.htm alongside markdown
- handleDocRequest converts HTML files on-demand via Turndown with
isWithinProjectRoot containment check
- serverAnnotate includes sourceInfo in /api/plan response
- index.ts supports URL detection (Jina Reader + fallback), HTML file
detection with Turndown conversion, folder HTML validation, and 10MB
file size guard
- openMarkdownAnnotation accepts and threads sourceInfo
- Add turndown as a Pi extension dependency
For provenance purposes, this commit was AI assisted.
* fix(pi): Obsidian vault walks stay markdown-only, add try/catch for HTML
- Add extensions param to walkMarkdownFiles (default: HTML-inclusive)
- Obsidian callers pass /\.mdx?$/i to match Bun server behavior
- Add try/catch around HTML file reads in handleDocRequest
For provenance purposes, this commit was AI assisted.
* fix(annotate): address second review — base-block traversal, metadata IP, dead code
Security:
- Add isWithinProjectRoot check to the base-relative block for HTML
files in both Bun and Pi /api/doc handlers. Previously HTML files
served via the base query param bypassed the containment guard.
- Add 169.254.0.0/16 (link-local / cloud metadata) to isLocalUrl
private IP ranges
Cleanup:
- Remove dead hostname === "[::1]" check (WHATWG URL parser strips
brackets; hostname === "::1" already handles it)
- Remove dead parent?.childNodes fallback in table cell() function
For provenance purposes, this commit was AI assisted.
* refactor(annotate): replace custom table rules with turndown-plugin-gfm
Drop ~60 lines of hand-rolled GFM table conversion that had a bug
(tables without explicit <thead> produced invalid GFM). Use the
official turndown-plugin-gfm plugin (24KB) which correctly handles
all table patterns plus adds strikethrough and task list support.
For provenance purposes, this commit was AI assisted.
* fix(annotate): handle all CommonMark backslash escapes in InlineMarkdown
Expand the backslash escape regex to cover all CommonMark-defined
escapable characters (. ) - # > + | { } &), not just the subset
the parser uses for formatting. Fixes literal backslashes appearing
in rendered output for Turndown-escaped content like "1\." → "1.".
For provenance purposes, this commit was AI assisted.
* fix(annotate): prevent SSRF via redirect to private/local URLs
Replace redirect: "follow" with redirect: "manual" in fetchViaTurndown
and validate each redirect hop against isLocalUrl. Blocks attacks where
an external URL redirects to cloud metadata endpoints (169.254.169.254)
or other private IPs. Limits redirect chain to 10 hops.
For provenance purposes, this commit was AI assisted.
* chore: update lockfile for turndown-plugin-gfm in Pi extension
bun install needed to resolve turndown-plugin-gfm in the Pi extension
workspace after adding it to apps/pi-extension/package.json.
For provenance purposes, this commit was AI assisted.
* fix(annotate): switch to @joplin/turndown-plugin-gfm, fix TS errors
Replace unmaintained turndown-plugin-gfm (2017, v1.0.2) with the
actively maintained Joplin fork (2025, v1.0.64, 16KB).
Fix TypeScript errors that broke CI:
- Add @ts-expect-error for untyped @joplin/turndown-plugin-gfm import
- Restructure fetchViaTurndown redirect loop to avoid uninitialized
variable — first fetch before loop, loop only for redirects
For provenance purposes, this commit was AI assisted.
* fix(annotate): use proper declarations.d.ts instead of ts-expect-error
Add declarations.d.ts for @joplin/turndown-plugin-gfm with typed
function signatures, remove the ts-expect-error suppression.
For provenance purposes, this commit was AI assisted.
* fix: explicitly include declarations.d.ts in shared tsconfig
CI's tsc wasn't finding the ambient module declaration with implicit
include. Add explicit include to ensure declarations.d.ts is always
picked up regardless of environment.
For provenance purposes, this commit was AI assisted.
* fix: use ts-expect-error for @joplin/turndown-plugin-gfm types
CI's tsc does not pick up ambient declarations.d.ts files despite
local tsc finding them — likely a module resolution discrepancy
between environments. Revert to @ts-expect-error which passes in
both CI and local typecheck.
For provenance purposes, this commit was AI assisted.
* fix(annotate): body size limit for URL fetches, redirect error, file: protocol
- Add 10MB body size limit to both Jina and fetch+Turndown URL paths,
matching the local HTML file guard. Streams response body and aborts
if limit exceeded.
- Distinguish "Too many redirects" from a genuine 3xx response after
redirect loop exhaustion.
- Add file: to the dangerous protocol blocklist in sanitizeLinkUrl.
For provenance purposes, this commit was AI assisted.
* fix(annotate): HTML folder outside cwd, HTML linked doc navigation
- Remove containment check from base-relative block for HTML files in
both Bun and Pi /api/doc handlers. Matches markdown behavior so HTML
files in annotated folders outside cwd are served correctly.
Standalone block (no base) retains its cwd check as fallback.
- Widen isLocalMd → isLocalDoc to treat .html/.htm links as linked
documents. Clicking [Next](next.html) in a converted page now opens
it via /api/doc with Turndown conversion instead of a new browser tab.
For provenance purposes, this commit was AI assisted.
* fix(annotate): full loopback range, drain redirect bodies, document env vars
- Expand loopback check from just 127.0.0.1 to the full 127.0.0.0/8
range so all loopback addresses skip Jina Reader
- Cancel redirect response body before re-fetching to avoid leaking
TCP connections back to the pool
- Document PLANNOTATOR_JINA and JINA_API_KEY in CLAUDE.md env var table
For provenance purposes, this commit was AI assisted.
* fix(annotate): IPv6 loopback, readBodyWithLimit fallback, env var docs, comments
- Add [::1] back to isLocalUrl — WHATWG URL hostname getter preserves
brackets for IPv6 (verified: Bun and Node both return "[::1]").
Add comment explaining the empirical verification so future reviewers
don't re-flag.
- Fix readBodyWithLimit null-body fallback to still enforce the 10MB
limit via text length check instead of silently falling through.
- Document PLANNOTATOR_JINA and JINA_API_KEY in AGENTS.md env var table
(CLAUDE.md is a symlink to AGENTS.md).
- Add comments to base-relative blocks in both Bun and Pi handleDoc
explaining the intentional lack of containment check (matches
pre-existing markdown behavior, base is set server-side).
For provenance purposes, this commit was AI assisted.
* fix(annotate): block IPv4-mapped IPv6 and private IPv6 ranges in isLocalUrl
Add PRIVATE_IPV6 regex matching bracketed IPv6 private/reserved ranges:
- ::ffff: (IPv4-mapped — embeds private IPv4 as hex, e.g. [::ffff:c0a8:1])
- fe80: (link-local)
- fc00::/7 (unique-local, covers fc00:: through fdff::)
Closes the redirect-SSRF bypass where a public URL redirects to a
private address expressed as IPv4-mapped IPv6, e.g.
http://[::ffff:169.254.169.254]/latest/meta-data/
For provenance purposes, this commit was AI assisted.
* fix(annotate): document IPv6 hostname verification, sourceInfo type, annotate flow
- Expand isLocalUrl comment with full empirical verification table
showing actual hostname getter output for every IPv6 format in both
Bun and Node — prevents false-positive review findings about brackets
- Add sourceInfo to /api/plan response type in App.tsx for type safety
- Update CLAUDE.md annotate flow diagram to reflect HTML/URL/folder
input types
For provenance purposes, this commit was AI assisted.
* fix(annotate): escape \(, cancel response bodies on error, doc sourceInfo
- Add ( to backslash escape regex alongside existing ) — Turndown
emits \( in link-adjacent contexts
- Cancel response body before throwing on !res.ok in both fetchViaJina
and fetchViaTurndown error paths (redirect loop already did this)
- Document sourceInfo field in AGENTS.md annotate server API table
For provenance purposes, this commit was AI assisted.
* fix(annotate): skip base injection for URL annotations, body cleanup
- Skip dirname(filePath) base injection when filePath is a URL in both
Bun and Pi annotate servers. dirname on a URL string produces a
nonsensical filesystem path, causing linked doc clicks to 404.
URL annotations now let links open normally instead.
- Cancel response body before throwing on content-type mismatch and
content-length overflow in fetchViaTurndown/readBodyWithLimit.
- Fix double parseInt in readBodyWithLimit content-length check.
- Correct AGENTS.md flow diagram: OpenCode not yet implemented for
HTML/URL annotation.
For provenance purposes, this commit was AI assisted.
* feat(annotate): OpenCode HTML file and URL annotation support
Add URL detection (Jina Reader + fallback), HTML file detection with
Turndown conversion, 10MB file size guard, and sourceInfo threading
to OpenCode's handleAnnotateCommand. Uses the same shared utilities
as the Bun CLI and Pi extension.
OpenCode uses the Bun server directly (startAnnotateServer from
@plannotator/server/annotate), so no server-side changes needed —
only the command handler routing was missing.
Note: folder annotation mode is not added (OpenCode didn't have it
before this PR for markdown either — separate scope).
For provenance purposes, this commit was AI assisted.
* chore(annotate): update slash command description, align fetch log messages
- OpenCode plannotator-annotate.md description now mentions HTML/URL
- Align fetch progress messages across all three clients: all now show
"(via Jina Reader)" or "(via fetch+Turndown)" consistently
For provenance purposes, this commit was AI assisted.
* fix(annotate): skip conversion for .md URLs, wikilink HTML targets, cleanup
- URLs ending in .md/.mdx are fetched raw — no Jina, no Turndown.
Content is already markdown. Removes text/plain from fetchViaTurndown
content-type whitelist since .md URLs are now short-circuited.
- Wikilink regex widened to preserve .html/.htm targets instead of
appending .md (e.g. [[page.html]] no longer becomes page.html.md)
- Remove redundant existsSync before statSync in OpenCode handler
For provenance purposes, this commit was AI assisted.
* test(annotate): add htmlToMarkdown conversion tests
Tests cover the core conversion utility that all three clients depend on:
- Basic HTML → markdown (headings, paragraphs, links, code blocks)
- Tables with and without <thead> (the GFM plugin bug that was caught)
- Script/style/noscript stripping
- Strikethrough (GFM)
- Empty HTML handling
- Dangerous links preserved (sanitization is in the renderer, not here)
For provenance purposes, this commit was AI assisted.
* fix(annotate): check content-type before treating .md URLs as raw markdown
URLs ending in .md/.mdx (e.g. GitHub's viewer page for README.md)
may return HTML instead of raw markdown. fetchRawText now checks the
response content-type — if the server returns HTML, returns null so
the caller falls through to Jina/Turndown for proper conversion.
For provenance purposes, this commit was AI assisted.
* fix(annotate): add SSRF redirect protection to fetchRawText
fetchRawText (for .md/.mdx URLs) was using default redirect: "follow"
with no isLocalUrl validation on redirect hops — a .md URL redirecting
to 169.254.169.254 would be followed and credentials returned as
"markdown". Now uses redirect: "manual" with per-hop isLocalUrl checks,
matching fetchViaTurndown's SSRF protection.
For provenance purposes, this commit was AI assisted.
2026-04-12 18:56:28 -07:00
|
|
|
sourceInfo?: string,
|
2026-04-27 23:13:52 -07:00
|
|
|
sourceConverted?: boolean,
|
feat(annotate): add --gate, --json, and --silent-approve flags (#570)
Adds an opt-in review gate flow to annotation mode with three composable flags:
- `--gate`: 3-way UX (Approve / Send Annotations / Close)
- `--json`: structured decision output (`{"decision":"approved|annotated|dismissed"}`)
- `--silent-approve`: suppresses plaintext approve marker for naive hooks
Includes shared arg parser, @-reference handling, updated templates across all
harnesses (Claude Code, Copilot, Gemini, OpenCode, Pi), and full documentation.
Closes #570
For provenance purposes, this commit was AI assisted.
2026-04-23 17:40:40 -07:00
|
|
|
gate?: boolean,
|
|
|
|
|
): Promise<{ feedback: string; exit?: boolean; approved?: boolean }> {
|
2026-04-02 19:49:05 +02:00
|
|
|
if (!ctx.hasUI || !planHtmlContent) {
|
|
|
|
|
throw new Error("Plannotator annotation browser is unavailable in this session.");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let resolvedMarkdown = markdown;
|
|
|
|
|
if (!resolvedMarkdown.trim() && existsSync(filePath)) {
|
|
|
|
|
try {
|
|
|
|
|
const fileStat = statSync(filePath);
|
|
|
|
|
if (!fileStat.isDirectory()) {
|
|
|
|
|
resolvedMarkdown = readFileSync(filePath, "utf-8");
|
|
|
|
|
}
|
|
|
|
|
} catch {
|
|
|
|
|
// fall back to provided markdown
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const server = await startAnnotateServer({
|
|
|
|
|
markdown: resolvedMarkdown,
|
|
|
|
|
filePath,
|
|
|
|
|
origin: "pi",
|
|
|
|
|
mode,
|
|
|
|
|
folderPath,
|
feat(annotate): support HTML files and URL annotation (#545)
* fix(annotate): sanitize dangerous link protocols in markdown renderer
Block javascript:, data:, and vbscript: URLs in InlineMarkdown link
rendering. Links with dangerous protocols render as plain text instead
of clickable anchors. Uses a blocklist approach so existing links with
custom protocols (obsidian://, vscode://, Windows C:\ paths) continue
to work.
For provenance purposes, this commit was AI assisted.
* feat(annotate): add HTML-to-markdown and URL-to-markdown utilities
- html-to-markdown.ts: Turndown wrapper with GFM table rule, strips
script/style/noscript tags
- url-to-markdown.ts: Jina Reader (free, returns markdown) with
fetch+Turndown fallback. Warns on Jina failure, auto-skips Jina for
local/private URLs (localhost, 192.168.*, 10.*, etc.)
- config.ts: add jina setting and resolveUseJina() with priority chain
--no-jina flag > PLANNOTATOR_JINA env > config.json > default true
For provenance purposes, this commit was AI assisted.
* feat(annotate): support HTML files and URLs in annotate command
Extend the annotate subcommand to accept .html/.htm local files
(converted via Turndown) and https:// URLs (fetched via Jina Reader
with fetch+Turndown fallback). URL content is fetched terminal-side
before opening the browser.
Add --no-jina global flag to disable Jina Reader per-invocation.
Add 10MB file size guard for local HTML files.
For provenance purposes, this commit was AI assisted.
* feat(annotate): HTML files in folder browser and on-demand conversion
- Widen file browser glob to include .html/.htm alongside markdown
- handleDoc converts HTML files via Turndown on demand when selected
- hasMarkdownFiles accepts optional extensions param for folder validation
- Add sourceInfo field to annotate server API response
- Add _site/, public/, out/, .docusaurus/, .jekyll-cache/,
storybook-static/ to FILE_BROWSER_EXCLUDED
For provenance purposes, this commit was AI assisted.
* feat(annotate): source attribution badge for HTML/URL annotations
Show a subtle badge in DocBadges displaying the URL hostname or HTML
filename for converted content. Thread sourceInfo from API response
through App → Viewer → DocBadges.
Also update Pi extension to accept HTML-only folders in annotate mode.
For provenance purposes, this commit was AI assisted.
* test: update CLI help text assertion for HTML/URL annotate support
For provenance purposes, this commit was AI assisted.
* fix(annotate): address PR review findings
Security:
- Add project-root containment check for HTML files in /api/doc handler
using exported isWithinProjectRoot() from resolve-file.ts
- Blocks path traversal via absolute paths or ../ escapes
isLocalUrl fixes:
- Add bracketed IPv6 loopback [::1] detection
- Replace hostname.startsWith('10.') with proper IPv4 regex to avoid
matching public hostnames like 10.example.com
Revert Pi extension change:
- Pi server doesn't implement HTML file browsing or conversion yet
- Keep Pi folder validation markdown-only until both implementations
are updated per CLAUDE.md guidelines
Cleanup:
- Remove dead el.children || el.childNodes fallback in table rule
- Extract hostnameOrFallback() helper to @plannotator/shared/project
replacing duplicated try/catch IIFEs in DocBadges and index.ts
For provenance purposes, this commit was AI assisted.
* feat(annotate): Pi extension HTML annotation parity
Bring the Pi extension to full parity with the Bun server for HTML
annotation support:
- Vendor html-to-markdown and url-to-markdown via vendor.sh
- walkMarkdownFiles now scans .html/.htm alongside markdown
- handleDocRequest converts HTML files on-demand via Turndown with
isWithinProjectRoot containment check
- serverAnnotate includes sourceInfo in /api/plan response
- index.ts supports URL detection (Jina Reader + fallback), HTML file
detection with Turndown conversion, folder HTML validation, and 10MB
file size guard
- openMarkdownAnnotation accepts and threads sourceInfo
- Add turndown as a Pi extension dependency
For provenance purposes, this commit was AI assisted.
* fix(pi): Obsidian vault walks stay markdown-only, add try/catch for HTML
- Add extensions param to walkMarkdownFiles (default: HTML-inclusive)
- Obsidian callers pass /\.mdx?$/i to match Bun server behavior
- Add try/catch around HTML file reads in handleDocRequest
For provenance purposes, this commit was AI assisted.
* fix(annotate): address second review — base-block traversal, metadata IP, dead code
Security:
- Add isWithinProjectRoot check to the base-relative block for HTML
files in both Bun and Pi /api/doc handlers. Previously HTML files
served via the base query param bypassed the containment guard.
- Add 169.254.0.0/16 (link-local / cloud metadata) to isLocalUrl
private IP ranges
Cleanup:
- Remove dead hostname === "[::1]" check (WHATWG URL parser strips
brackets; hostname === "::1" already handles it)
- Remove dead parent?.childNodes fallback in table cell() function
For provenance purposes, this commit was AI assisted.
* refactor(annotate): replace custom table rules with turndown-plugin-gfm
Drop ~60 lines of hand-rolled GFM table conversion that had a bug
(tables without explicit <thead> produced invalid GFM). Use the
official turndown-plugin-gfm plugin (24KB) which correctly handles
all table patterns plus adds strikethrough and task list support.
For provenance purposes, this commit was AI assisted.
* fix(annotate): handle all CommonMark backslash escapes in InlineMarkdown
Expand the backslash escape regex to cover all CommonMark-defined
escapable characters (. ) - # > + | { } &), not just the subset
the parser uses for formatting. Fixes literal backslashes appearing
in rendered output for Turndown-escaped content like "1\." → "1.".
For provenance purposes, this commit was AI assisted.
* fix(annotate): prevent SSRF via redirect to private/local URLs
Replace redirect: "follow" with redirect: "manual" in fetchViaTurndown
and validate each redirect hop against isLocalUrl. Blocks attacks where
an external URL redirects to cloud metadata endpoints (169.254.169.254)
or other private IPs. Limits redirect chain to 10 hops.
For provenance purposes, this commit was AI assisted.
* chore: update lockfile for turndown-plugin-gfm in Pi extension
bun install needed to resolve turndown-plugin-gfm in the Pi extension
workspace after adding it to apps/pi-extension/package.json.
For provenance purposes, this commit was AI assisted.
* fix(annotate): switch to @joplin/turndown-plugin-gfm, fix TS errors
Replace unmaintained turndown-plugin-gfm (2017, v1.0.2) with the
actively maintained Joplin fork (2025, v1.0.64, 16KB).
Fix TypeScript errors that broke CI:
- Add @ts-expect-error for untyped @joplin/turndown-plugin-gfm import
- Restructure fetchViaTurndown redirect loop to avoid uninitialized
variable — first fetch before loop, loop only for redirects
For provenance purposes, this commit was AI assisted.
* fix(annotate): use proper declarations.d.ts instead of ts-expect-error
Add declarations.d.ts for @joplin/turndown-plugin-gfm with typed
function signatures, remove the ts-expect-error suppression.
For provenance purposes, this commit was AI assisted.
* fix: explicitly include declarations.d.ts in shared tsconfig
CI's tsc wasn't finding the ambient module declaration with implicit
include. Add explicit include to ensure declarations.d.ts is always
picked up regardless of environment.
For provenance purposes, this commit was AI assisted.
* fix: use ts-expect-error for @joplin/turndown-plugin-gfm types
CI's tsc does not pick up ambient declarations.d.ts files despite
local tsc finding them — likely a module resolution discrepancy
between environments. Revert to @ts-expect-error which passes in
both CI and local typecheck.
For provenance purposes, this commit was AI assisted.
* fix(annotate): body size limit for URL fetches, redirect error, file: protocol
- Add 10MB body size limit to both Jina and fetch+Turndown URL paths,
matching the local HTML file guard. Streams response body and aborts
if limit exceeded.
- Distinguish "Too many redirects" from a genuine 3xx response after
redirect loop exhaustion.
- Add file: to the dangerous protocol blocklist in sanitizeLinkUrl.
For provenance purposes, this commit was AI assisted.
* fix(annotate): HTML folder outside cwd, HTML linked doc navigation
- Remove containment check from base-relative block for HTML files in
both Bun and Pi /api/doc handlers. Matches markdown behavior so HTML
files in annotated folders outside cwd are served correctly.
Standalone block (no base) retains its cwd check as fallback.
- Widen isLocalMd → isLocalDoc to treat .html/.htm links as linked
documents. Clicking [Next](next.html) in a converted page now opens
it via /api/doc with Turndown conversion instead of a new browser tab.
For provenance purposes, this commit was AI assisted.
* fix(annotate): full loopback range, drain redirect bodies, document env vars
- Expand loopback check from just 127.0.0.1 to the full 127.0.0.0/8
range so all loopback addresses skip Jina Reader
- Cancel redirect response body before re-fetching to avoid leaking
TCP connections back to the pool
- Document PLANNOTATOR_JINA and JINA_API_KEY in CLAUDE.md env var table
For provenance purposes, this commit was AI assisted.
* fix(annotate): IPv6 loopback, readBodyWithLimit fallback, env var docs, comments
- Add [::1] back to isLocalUrl — WHATWG URL hostname getter preserves
brackets for IPv6 (verified: Bun and Node both return "[::1]").
Add comment explaining the empirical verification so future reviewers
don't re-flag.
- Fix readBodyWithLimit null-body fallback to still enforce the 10MB
limit via text length check instead of silently falling through.
- Document PLANNOTATOR_JINA and JINA_API_KEY in AGENTS.md env var table
(CLAUDE.md is a symlink to AGENTS.md).
- Add comments to base-relative blocks in both Bun and Pi handleDoc
explaining the intentional lack of containment check (matches
pre-existing markdown behavior, base is set server-side).
For provenance purposes, this commit was AI assisted.
* fix(annotate): block IPv4-mapped IPv6 and private IPv6 ranges in isLocalUrl
Add PRIVATE_IPV6 regex matching bracketed IPv6 private/reserved ranges:
- ::ffff: (IPv4-mapped — embeds private IPv4 as hex, e.g. [::ffff:c0a8:1])
- fe80: (link-local)
- fc00::/7 (unique-local, covers fc00:: through fdff::)
Closes the redirect-SSRF bypass where a public URL redirects to a
private address expressed as IPv4-mapped IPv6, e.g.
http://[::ffff:169.254.169.254]/latest/meta-data/
For provenance purposes, this commit was AI assisted.
* fix(annotate): document IPv6 hostname verification, sourceInfo type, annotate flow
- Expand isLocalUrl comment with full empirical verification table
showing actual hostname getter output for every IPv6 format in both
Bun and Node — prevents false-positive review findings about brackets
- Add sourceInfo to /api/plan response type in App.tsx for type safety
- Update CLAUDE.md annotate flow diagram to reflect HTML/URL/folder
input types
For provenance purposes, this commit was AI assisted.
* fix(annotate): escape \(, cancel response bodies on error, doc sourceInfo
- Add ( to backslash escape regex alongside existing ) — Turndown
emits \( in link-adjacent contexts
- Cancel response body before throwing on !res.ok in both fetchViaJina
and fetchViaTurndown error paths (redirect loop already did this)
- Document sourceInfo field in AGENTS.md annotate server API table
For provenance purposes, this commit was AI assisted.
* fix(annotate): skip base injection for URL annotations, body cleanup
- Skip dirname(filePath) base injection when filePath is a URL in both
Bun and Pi annotate servers. dirname on a URL string produces a
nonsensical filesystem path, causing linked doc clicks to 404.
URL annotations now let links open normally instead.
- Cancel response body before throwing on content-type mismatch and
content-length overflow in fetchViaTurndown/readBodyWithLimit.
- Fix double parseInt in readBodyWithLimit content-length check.
- Correct AGENTS.md flow diagram: OpenCode not yet implemented for
HTML/URL annotation.
For provenance purposes, this commit was AI assisted.
* feat(annotate): OpenCode HTML file and URL annotation support
Add URL detection (Jina Reader + fallback), HTML file detection with
Turndown conversion, 10MB file size guard, and sourceInfo threading
to OpenCode's handleAnnotateCommand. Uses the same shared utilities
as the Bun CLI and Pi extension.
OpenCode uses the Bun server directly (startAnnotateServer from
@plannotator/server/annotate), so no server-side changes needed —
only the command handler routing was missing.
Note: folder annotation mode is not added (OpenCode didn't have it
before this PR for markdown either — separate scope).
For provenance purposes, this commit was AI assisted.
* chore(annotate): update slash command description, align fetch log messages
- OpenCode plannotator-annotate.md description now mentions HTML/URL
- Align fetch progress messages across all three clients: all now show
"(via Jina Reader)" or "(via fetch+Turndown)" consistently
For provenance purposes, this commit was AI assisted.
* fix(annotate): skip conversion for .md URLs, wikilink HTML targets, cleanup
- URLs ending in .md/.mdx are fetched raw — no Jina, no Turndown.
Content is already markdown. Removes text/plain from fetchViaTurndown
content-type whitelist since .md URLs are now short-circuited.
- Wikilink regex widened to preserve .html/.htm targets instead of
appending .md (e.g. [[page.html]] no longer becomes page.html.md)
- Remove redundant existsSync before statSync in OpenCode handler
For provenance purposes, this commit was AI assisted.
* test(annotate): add htmlToMarkdown conversion tests
Tests cover the core conversion utility that all three clients depend on:
- Basic HTML → markdown (headings, paragraphs, links, code blocks)
- Tables with and without <thead> (the GFM plugin bug that was caught)
- Script/style/noscript stripping
- Strikethrough (GFM)
- Empty HTML handling
- Dangerous links preserved (sanitization is in the renderer, not here)
For provenance purposes, this commit was AI assisted.
* fix(annotate): check content-type before treating .md URLs as raw markdown
URLs ending in .md/.mdx (e.g. GitHub's viewer page for README.md)
may return HTML instead of raw markdown. fetchRawText now checks the
response content-type — if the server returns HTML, returns null so
the caller falls through to Jina/Turndown for proper conversion.
For provenance purposes, this commit was AI assisted.
* fix(annotate): add SSRF redirect protection to fetchRawText
fetchRawText (for .md/.mdx URLs) was using default redirect: "follow"
with no isLocalUrl validation on redirect hops — a .md URL redirecting
to 169.254.169.254 would be followed and credentials returned as
"markdown". Now uses redirect: "manual" with per-hop isLocalUrl checks,
matching fetchViaTurndown's SSRF protection.
For provenance purposes, this commit was AI assisted.
2026-04-12 18:56:28 -07:00
|
|
|
sourceInfo,
|
2026-04-27 23:13:52 -07:00
|
|
|
sourceConverted,
|
feat(annotate): add --gate, --json, and --silent-approve flags (#570)
Adds an opt-in review gate flow to annotation mode with three composable flags:
- `--gate`: 3-way UX (Approve / Send Annotations / Close)
- `--json`: structured decision output (`{"decision":"approved|annotated|dismissed"}`)
- `--silent-approve`: suppresses plaintext approve marker for naive hooks
Includes shared arg parser, @-reference handling, updated templates across all
harnesses (Claude Code, Copilot, Gemini, OpenCode, Pi), and full documentation.
Closes #570
For provenance purposes, this commit was AI assisted.
2026-04-23 17:40:40 -07:00
|
|
|
gate,
|
2026-04-02 19:49:05 +02:00
|
|
|
htmlContent: planHtmlContent,
|
|
|
|
|
sharingEnabled: process.env.PLANNOTATOR_SHARE !== "disabled",
|
|
|
|
|
shareBaseUrl: process.env.PLANNOTATOR_SHARE_URL || undefined,
|
|
|
|
|
pasteApiUrl: process.env.PLANNOTATOR_PASTE_URL || undefined,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
return openBrowserAndWait(server, ctx, server.waitForDecision);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export async function openLastMessageAnnotation(
|
|
|
|
|
ctx: ExtensionContext,
|
|
|
|
|
lastText: string,
|
feat(annotate): add --gate, --json, and --silent-approve flags (#570)
Adds an opt-in review gate flow to annotation mode with three composable flags:
- `--gate`: 3-way UX (Approve / Send Annotations / Close)
- `--json`: structured decision output (`{"decision":"approved|annotated|dismissed"}`)
- `--silent-approve`: suppresses plaintext approve marker for naive hooks
Includes shared arg parser, @-reference handling, updated templates across all
harnesses (Claude Code, Copilot, Gemini, OpenCode, Pi), and full documentation.
Closes #570
For provenance purposes, this commit was AI assisted.
2026-04-23 17:40:40 -07:00
|
|
|
gate?: boolean,
|
|
|
|
|
): Promise<{ feedback: string; exit?: boolean; approved?: boolean }> {
|
2026-04-27 23:13:52 -07:00
|
|
|
return openMarkdownAnnotation(ctx, "last-message", lastText, "annotate-last", undefined, undefined, undefined, gate);
|
2026-04-02 19:49:05 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export async function openArchiveBrowserAction(
|
|
|
|
|
ctx: ExtensionContext,
|
|
|
|
|
customPlanPath?: string,
|
|
|
|
|
): Promise<{ opened: boolean }> {
|
|
|
|
|
if (!ctx.hasUI || !planHtmlContent) {
|
|
|
|
|
throw new Error("Plannotator archive browser is unavailable in this session.");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const server = await startPlanReviewServer({
|
|
|
|
|
plan: "",
|
|
|
|
|
htmlContent: planHtmlContent,
|
|
|
|
|
origin: "pi",
|
|
|
|
|
mode: "archive",
|
|
|
|
|
customPlanPath,
|
|
|
|
|
sharingEnabled: process.env.PLANNOTATOR_SHARE !== "disabled",
|
|
|
|
|
shareBaseUrl: process.env.PLANNOTATOR_SHARE_URL || undefined,
|
|
|
|
|
pasteApiUrl: process.env.PLANNOTATOR_PASTE_URL || undefined,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
return openBrowserAndWait(server, ctx, async () => {
|
|
|
|
|
if (server.waitForDone) {
|
|
|
|
|
await server.waitForDone();
|
|
|
|
|
}
|
|
|
|
|
return { opened: true };
|
|
|
|
|
});
|
|
|
|
|
}
|