angular__angular

mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00

Files

T

Kristiyan Kostadinov e4fbab9ec8 fix(core): error if detectChanges is called at the wrong time under specific circumstances (#40206 )

Internally we store lifecycle hooks in the format `[index, hook, index, hook]` and when
iterating over them, we check one place ahead to figure out whether we've hit found
a hook or an index. The problem is that the loop is set up to iterate up to `hooks.length`
which means that we may go out of bounds on the last iteration, depending on where
we started. This appears to happen under a specific set of circumstances where a
directive calls `detectChanges` from an input setter while it has `ngOnChanges` and
`ngAfterViewInit` hooks.

These changes resolve the issue by only iterating up to `length - 1` which guarantees that
we can always look one place ahead.

This appears to have regressed some time in version 10.

Fixes #38611.

PR Close #40206

2020-12-22 14:52:12 -08:00

global

build: update license headers to reference Google LLC (#37205 )

2020-05-26 14:26:58 -04:00

schematics

fix(core): migration error if program contains files outside of the project (#39790 )

2020-11-20 12:51:19 -08:00

src

fix(core): error if detectChanges is called at the wrong time under specific circumstances (#40206 )

2020-12-22 14:52:12 -08:00

test

fix(core): error if detectChanges is called at the wrong time under specific circumstances (#40206 )