Dylan Hunn 29bf476bfe refactor(compiler): Generate temporary variable assignments when function calls appear in a safe-access expression. (#50688) ...

The expression `a()?.b` should expand into `(tmp = a()) === null ? null : tmp.b`, in order to avoid calling the function `a()` twice.

This commit modifies the null-safe-expansion algorithm to emit temporary assignments, and provides the reification code to actually generate the declarations, assignments, and reads.

Note also that, with our bottom-up algorithm, there are some tricky cases when a function call exists inside an indexed access, such as `f1()?.[f2()?.a]?.b`. We add some special logic to avoid generating a double-assignment to the temporary storing the result of `f2()`.

Finally, there are opportunities to reuse the same temporary in expressions like `a?.[f()]?.[f()]`. We save this for the next commit.

PR Close #50688

2023-06-29 12:54:23 -07:00

..

integrationtest

refactor(compiler-cli): remove unused integration tests. (#49862)

2023-04-17 14:57:02 +00:00

linker

refactor(compiler): introduce compiler infrastructure for input transforms (#50225)

2023-05-22 14:48:02 +00:00

ngcc

refactor(compiler-cli): add back ngcc as a no-op with a warning (#50045)

2023-04-28 18:18:40 +02:00

private

refactor(compiler-cli): remove unused class decorator downlevel code (#49351)

2023-03-08 17:59:12 +00:00

src

refactor(compiler-cli): remove unused HandlerFlags enum (#50604)

2023-06-20 13:01:48 -07:00

test

refactor(compiler): Generate temporary variable assignments when function calls appear in a safe-access expression. (#50688)

2023-06-29 12:54:23 -07:00

BUILD.bazel

refactor(compiler-cli): add back ngcc as a no-op with a warning (#50045)

2023-04-28 18:18:40 +02:00

esbuild.config.js

…

index.ts

…

package.json

build: update babel dependencies (#50509)

2023-06-21 11:44:59 -07:00

tsconfig-build.json

…

tsconfig.json

…