Jeremy Elbourn 35e45dc894 fix(ivy): prevent errors from views being destroyed twice (#28413) ...

Previously, attempting to destroy a view with listeners more than once
throws an error during event listener cleanup. This happens because
`cleanup` field on the `TView` has already been cleared out by the time
the second destruction runs.

The `destroyed` flag on LView was previously being set in the `destroyLView` function,
but this flag was never _checked_ anywhere in the codebase. This commit
moves _setting_ this flag to the `cleanupView` function, just before
destroy hooks are called. This is necessary because the destroy hooks
can contain arbitrary user code, such as (surprise!) attempting to
destroy the view (again). We also add a check to `destroyLView` to skip
already-destroyed views. This prevents the cleanup code path from running twice.

PR Close #28413

2019-01-30 20:39:55 -05:00

..

src

fix(ivy): prevent errors from views being destroyed twice (#28413)

2019-01-30 20:39:55 -05:00

test

fix(ivy): prevent errors from views being destroyed twice (#28413)

2019-01-30 20:39:55 -05:00

testing

fix(ivy): TestBed should tolerate synchronous use of compileComponents (#28350)

2019-01-28 11:59:40 -08:00

BUILD.bazel

build: run offline_compiler_test using bazel (#28191)

2019-01-28 20:07:22 -08:00

index.ts

…

package.json

fix(core): Remove static dependency from @angular/core to @angular/compiler (#26734)

2018-10-31 14:15:06 -04:00

PACKAGE.md

docs: add package doc files (#26047)

2018-10-05 15:42:14 -07:00

public_api.ts

…

rollup.config.js

feat(ivy): first steps towards JIT compilation (#23833)

2018-05-21 19:13:50 -04:00

tsconfig-build.json

feat(ivy): implement TestBed (#25369)

2018-08-14 11:58:47 -07:00