skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build(docs-infra): remove dependency on FontAwesome (#27250)

Browse Source 
We were only using two FontAwesome icons (`link` and `twitter`). The
twitter icon is already available as an SVG (used in the topbar) and a
similar link icon is available via 'Material Icons', which we are
already brining in.

This commit removes the dependency on FontAwesome and uses the available
icons instead.

_Before:_
![contributor-info-before](https://user-images.githubusercontent.com/8604205/49089076-61b90680-f263-11e8-8c5f-c52d332e6e64.png)

_After:_
![contributor-info-after](https://user-images.githubusercontent.com/8604205/49089075-61b90680-f263-11e8-9785-b8df15aaacd3.png)

PR Close #27250
This commit is contained in:
George Kalpakas
2018-11-27 16:26:24 +02:00
committed by Igor Minar
parent 271fcb0f3e
commit fa0c65efe5
5 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
aio/src/app/custom-elements/contributor/contributor-list.module.ts
+2 -1
View File
@@ -1,12 +1,13 @@
import { NgModule, Type } from '@angular/core';
import { CommonModule } from '@angular/common';
import { MatIconModule } from '@angular/material/icon';
import { ContributorListComponent } from './contributor-list.component';
import { ContributorService } from './contributor.service';
import { ContributorComponent } from './contributor.component';
import { WithCustomElementComponent } from '../element-registry';
@NgModule({
imports: [ CommonModule ],
imports: [ CommonModule, MatIconModule ],
declarations: [ ContributorListComponent, ContributorComponent ],
entryComponents: [ ContributorListComponent ],
providers: [ ContributorService ]
aio/src/app/custom-elements/contributor/contributor.component.ts
+5 -5
View File
@@ -13,16 +13,16 @@ import { CONTENT_URL_PREFIX } from 'app/documents/document.service';
<div class="contributor-image" [style.background-image]="'url('+pictureBase+(person.picture || noPicture)+')'">
<div class="contributor-info">
<a *ngIf="person.bio" mat-button>
<a *ngIf="person.bio" mat-button class="info-item">
View Bio
</a>
<a *ngIf="person.twitter" mat-button class="icon"
<a *ngIf="person.twitter" mat-icon-button class="info-item icon"
href="https://twitter.com/{{person.twitter}}" target="_blank" (click)="$event.stopPropagation()">
<span class="fa fa-twitter fa-2x"></span>
<mat-icon svgIcon="logos:twitter"></mat-icon>
</a>
<a *ngIf="person.website" mat-button class="icon"
<a *ngIf="person.website" mat-icon-button class="info-item icon"
href="{{person.website}}" target="_blank" (click)="$event.stopPropagation()">
<span class="fa fa-link fa-2x"></span>
<mat-icon class="link-icon">link</mat-icon>
</a>
</div>
</div>