From f9731eec93effa50929eb9178af113fce9ee3ea6 Mon Sep 17 00:00:00 2001 From: Charles Lyding <19598772+clydin@users.noreply.github.com> Date: Sun, 10 Dec 2023 18:45:31 -0500 Subject: [PATCH] build: remove unneeded graceful-fs package and resolution workaround (#53487) The `graceful-fs` package itself is unused within the repository code and can be removed. The resolution workaround is no longer required for any direct or transitive dependency based on the issue referenced via #28213. PR Close #53487 --- package.json | 7 ++----- yarn.lock | 7 ++++++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index cbecc231a93..a469d13a85c 100644 --- a/package.json +++ b/package.json @@ -106,7 +106,6 @@ "d3": "^7.0.0", "diff": "^5.0.0", "domino": "https://github.com/angular/domino.git#9e7881d2ac1e5977cefbc557f935931ec23f6658", - "graceful-fs": "4.2.11", "hammerjs": "~2.0.8", "http-server": "^14.0.0", "jasmine": "~5.1.0", @@ -193,11 +192,9 @@ "vrsource-tslint-rules": "6.0.0", "xregexp": "^5.1.1" }, - "// 4": "Overwrite graceful-fs to a version that does not rely on the 'natives' package. This fixes gulp for >= 10.13, more information: #28213", - "// 5": "Ensure that transitive dependencies on `https-proxy-agent` are at minimum v5 as older versions patch NodeJS directly, breaking tools like webdriver which is used by the karma-sauce-launcher as an example.", - "// 6": "Ensure that a single instance of the `saucelabs` package is used. Protractor and the Karma sauce launcher pull this package as dependency. A single instance allows for e.g. easier patching in the Karma config.", + "// 3": "Ensure that transitive dependencies on `https-proxy-agent` are at minimum v5 as older versions patch NodeJS directly, breaking tools like webdriver which is used by the karma-sauce-launcher as an example.", + "// 4": "Ensure that a single instance of the `saucelabs` package is used. Protractor and the Karma sauce launcher pull this package as dependency. A single instance allows for e.g. easier patching in the Karma config.", "resolutions": { - "**/graceful-fs": "4.2.11", "**/https-proxy-agent": "7.0.2", "**/saucelabs": "7.4.0" } diff --git a/yarn.lock b/yarn.lock index d29afdfe7a2..f0f8a390555 100644 --- a/yarn.lock +++ b/yarn.lock @@ -9131,7 +9131,12 @@ got@^11.0.2, got@^11.8.6: p-cancelable "^2.0.0" responselike "^2.0.0" -graceful-fs@4.2.10, graceful-fs@4.2.11, graceful-fs@^4.0.0, graceful-fs@^4.1.11, graceful-fs@^4.1.2, graceful-fs@^4.1.6, graceful-fs@^4.1.9, graceful-fs@^4.2.0, graceful-fs@^4.2.10, graceful-fs@^4.2.4, graceful-fs@^4.2.6, graceful-fs@^4.2.9: +graceful-fs@4.2.10: + version "4.2.10" + resolved "https://registry.yarnpkg.com/graceful-fs/-/graceful-fs-4.2.10.tgz#147d3a006da4ca3ce14728c7aefc287c367d7a6c" + integrity sha512-9ByhssR2fPVsNZj478qUUbKfmL0+t5BDVyjShtyZZLiK7ZDAArFFfopyOTj0M05wE2tJPisA4iTnnXl2YoPvOA== + +graceful-fs@^4.0.0, graceful-fs@^4.1.11, graceful-fs@^4.1.2, graceful-fs@^4.1.6, graceful-fs@^4.1.9, graceful-fs@^4.2.0, graceful-fs@^4.2.10, graceful-fs@^4.2.4, graceful-fs@^4.2.6, graceful-fs@^4.2.9: version "4.2.11" resolved "https://registry.yarnpkg.com/graceful-fs/-/graceful-fs-4.2.11.tgz#4183e4e8bf08bb6e05bbb2f7d2e0c8f712ca40e3" integrity sha512-RbJ5/jmFcNNCcDV5o9eTnBLJ/HszWV0P73bc+Ff4nS/rJj+YaS6IGyiOL0VoBYX+l1Wrl3k63h/KrH+nhJ0XvQ==