From f0708b463927b08ef162e9cda2a73d33955ebb1b Mon Sep 17 00:00:00 2001
From: Paul Gschwendtner <paulgschwendtner@gmail.com>
Date: Wed, 23 Jan 2019 20:17:40 +0100
Subject: [PATCH] build: add missing bazel action names (#14910)

In order to have proper action names when running bazel, we should add progress messages for all custom rules. Currently Bazel always uses the first input as action name, but this is *very* confusing since failures lead to the input file, instead of the associated Bazel action.

Note that this is not really a progress_message, but it is consistent with native bazel actions (e.g. `StarlarkAction`)
---
 tools/dgeni/index.bzl                | 1 +
 tools/highlight-files/index.bzl      | 1 +
 tools/markdown-to-html/index.bzl     | 1 +
 tools/package-docs-content/index.bzl | 1 +
 tools/sass_bundle.bzl                | 1 +
 5 files changed, 5 insertions(+)

diff --git a/tools/dgeni/index.bzl b/tools/dgeni/index.bzl
index 9fc0177f759..7c19b1e03a9 100644
--- a/tools/dgeni/index.bzl
+++ b/tools/dgeni/index.bzl
@@ -60,6 +60,7 @@ def _dgeni_api_docs(ctx):
     executable = ctx.executable._dgeni_bin,
     outputs = expected_outputs,
     arguments = [args],
+    progress_message = "Dgeni (%s)" % (output_dir_path),
   )
 
   return DefaultInfo(files = depset(expected_outputs))
diff --git a/tools/highlight-files/index.bzl b/tools/highlight-files/index.bzl
index a0fa7d0146a..e2e111ffb0e 100644
--- a/tools/highlight-files/index.bzl
+++ b/tools/highlight-files/index.bzl
@@ -59,6 +59,7 @@ def _highlight_files(ctx):
     executable = ctx.executable._highlight_files,
     outputs = expected_outputs,
     arguments = [args],
+    progress_message = "HighlightFiles",
   )
 
   return DefaultInfo(files = depset(expected_outputs))
diff --git a/tools/markdown-to-html/index.bzl b/tools/markdown-to-html/index.bzl
index 7b3ac16fd8b..c7dd99957d6 100644
--- a/tools/markdown-to-html/index.bzl
+++ b/tools/markdown-to-html/index.bzl
@@ -47,6 +47,7 @@ def _markdown_to_html(ctx):
     executable = ctx.executable._transform_markdown,
     outputs = expected_outputs,
     arguments = [args],
+    progress_message = "MarkdownToHtml",
   )
 
   return DefaultInfo(files = depset(expected_outputs))
diff --git a/tools/package-docs-content/index.bzl b/tools/package-docs-content/index.bzl
index 9472b3e4281..1bf2ae5934d 100644
--- a/tools/package-docs-content/index.bzl
+++ b/tools/package-docs-content/index.bzl
@@ -53,6 +53,7 @@ def _package_docs_content(ctx):
     executable = ctx.executable._packager,
     outputs = expected_outputs,
     arguments = [args],
+    progress_message = "PackageDocsContent",
   )
 
   return DefaultInfo(files = depset(expected_outputs))
diff --git a/tools/sass_bundle.bzl b/tools/sass_bundle.bzl
index a705ebec3ab..07de4bcd86e 100644
--- a/tools/sass_bundle.bzl
+++ b/tools/sass_bundle.bzl
@@ -24,6 +24,7 @@ def _sass_bundle(ctx):
     executable = ctx.executable._sass_bundle,
     outputs = [ctx.outputs.output_name],
     arguments = [args],
+    progress_message = "SassBundle (%s)" % ctx.attr.output_name,
   )
 
   output_depset = depset([ctx.outputs.output_name])