skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: minor improvements to build script output (#33823)

Browse Source 
- Move "Building packages" log above actual work (computing targets).
- Print corrent script name (`build-ivy-npm-packages.sh` would claim to
  be `build-packages-dist.sh`).
- Make logs of different operations a little more consistent.

PR Close #33823
This commit is contained in:
George Kalpakas
2019-11-14 09:28:29 +02:00
committed by Alex Rickabaugh
parent 9935aa43ad
commit e25b256aa4
2 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/package-builder.sh
+11 -10
View File
@@ -16,15 +16,11 @@ set -u -e -o pipefail
cd "$(dirname "$0")"
# basedir is the workspace root
readonly base_dir=$(pwd)/..
readonly bazel_bin=$(yarn run -s bazel info bazel-bin)
readonly base_dir="$(realpath "$(pwd)/..")"
readonly bazel_bin="$(yarn run -s bazel info bazel-bin)"
readonly script_path="$0"
function buildTargetPackages() {
# List of targets to build, e.g. core, common, compiler, etc. Note that we want to
# remove all carriage return ("\r") characters form the query output because otherwise
# the carriage return is part of the bazel target name and bazel will complain.
targets=$(yarn run -s bazel query --output=label 'attr("tags", "\[.*release-with-framework.*\]", //packages/...) intersect kind(".*_package", //packages/...)' | tr -d "\r")
# Path to the output directory into which we copy the npm packages.
dest_path="$1"
@@ -35,11 +31,16 @@ function buildTargetPackages() {
desc="$3"
echo "##################################"
echo "scripts/build-packages-dist.sh:"
echo " building @angular/* npm packages"
echo " mode: ${desc}"
echo "${script_path}:"
echo " Building @angular/* npm packages"
echo " Mode: ${desc}"
echo "##################################"
# List of targets to build, e.g. core, common, compiler, etc. Note that we want to
# remove all carriage return ("\r") characters form the query output because otherwise
# the carriage return is part of the bazel target name and bazel will complain.
targets=$(yarn run -s bazel query --output=label 'attr("tags", "\[.*release-with-framework.*\]", //packages/...) intersect kind(".*_package", //packages/...)' | tr -d "\r")
# Use --config=release so that snapshot builds get published with embedded version info
echo "$targets" | xargs yarn run -s bazel build --config=release --define=compile=${compile_mode}