From e242d1da14f2b552dc614773f258d38ba7bd91c7 Mon Sep 17 00:00:00 2001 From: Andrew Scott Date: Thu, 22 Jul 2021 12:19:44 -0700 Subject: [PATCH] docs: Add import line to router event example for clarification (#42935) Without the `import {Event} from '@angular/router';`, the filter will not work because the type is understood as the native `Event`. Fixes #42920 PR Close #42935 --- packages/router/src/events.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/router/src/events.ts b/packages/router/src/events.ts index 5dfae647729..427b40570b1 100644 --- a/packages/router/src/events.ts +++ b/packages/router/src/events.ts @@ -27,12 +27,14 @@ export type NavigationTrigger = 'imperative'|'popstate'|'hashchange'; * The following code shows how a class subscribes to router events. * * ```ts + * import {Event, RouterEvent, Router} from '@angular/router'; + * * class MyService { - * constructor(public router: Router, logger: Logger) { + * constructor(public router: Router) { * router.events.pipe( * filter((e: Event): e is RouterEvent => e instanceof RouterEvent) * ).subscribe((e: RouterEvent) => { - * logger.log(e.id, e.url); + * // Do something * }); * } * }