From dfb465637d75bf7ba3a17eecfaf30f3986c3e1b6 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Wed, 21 May 2025 12:00:26 +0000 Subject: [PATCH] build: migrate `packages/elements` to `ng_project` (#61566) Migrates `packages/elements` to `ng_project`. PR Close #61566 --- packages/elements/BUILD.bazel | 11 +++++++---- packages/elements/src/component-factory-strategy.ts | 3 +++ packages/elements/test/BUILD.bazel | 12 +++++++----- 3 files changed, 17 insertions(+), 9 deletions(-) diff --git a/packages/elements/BUILD.bazel b/packages/elements/BUILD.bazel index 0836a094cfc..1943faaff84 100644 --- a/packages/elements/BUILD.bazel +++ b/packages/elements/BUILD.bazel @@ -1,8 +1,9 @@ -load("//tools:defaults.bzl", "api_golden_test_npm_package", "generate_api_docs", "ng_module", "ng_package") +load("//tools:defaults.bzl", "api_golden_test_npm_package", "generate_api_docs", "ng_package") +load("//tools:defaults2.bzl", "ng_project") package(default_visibility = ["//visibility:public"]) -ng_module( +ng_project( name = "elements", srcs = glob( [ @@ -10,10 +11,12 @@ ng_module( "src/**/*.ts", ], ), - deps = [ + interop_deps = [ "//packages/core", "//packages/platform-browser", - "@npm//rxjs", + ], + deps = [ + "//:node_modules/rxjs", ], ) diff --git a/packages/elements/src/component-factory-strategy.ts b/packages/elements/src/component-factory-strategy.ts index 016bd03eeb9..ac34c7e1767 100644 --- a/packages/elements/src/component-factory-strategy.ts +++ b/packages/elements/src/component-factory-strategy.ts @@ -6,6 +6,9 @@ * found in the LICENSE file at https://angular.dev/license */ +// Needed for the global `Zone` ambient types to be available. +import type {} from 'zone.js'; + import { ApplicationRef, ComponentFactory, diff --git a/packages/elements/test/BUILD.bazel b/packages/elements/test/BUILD.bazel index 9350fb9805e..88a7ba8b332 100644 --- a/packages/elements/test/BUILD.bazel +++ b/packages/elements/test/BUILD.bazel @@ -1,18 +1,20 @@ -load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library") +load("//tools:defaults.bzl", "karma_web_test_suite") +load("//tools:defaults2.bzl", "ts_project") -ts_library( +ts_project( name = "test_lib", testonly = True, srcs = glob(["**/*.ts"]), - deps = [ - "//packages:types", + interop_deps = [ "//packages/compiler", "//packages/core", "//packages/core/testing", "//packages/elements", "//packages/platform-browser", "//packages/platform-browser/testing", - "@npm//rxjs", + ], + deps = [ + "//:node_modules/rxjs", ], )