skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(compiler-cli): rename ExtendedTemplateChecker get diagnostics fucntion (#43134)

Browse Source 
Rename `getExtendedTemplateDiagnosticsForComponent` to
`getDiagnosticsForComponent` since it's implied they are extended
diagnostics.

Refs #42966

PR Close #43134
This commit is contained in:
Daniel Trevino
2021-08-23 21:24:54 +00:00
committed by Alex Rickabaugh
parent 68bb13ea0f
commit de215a4b21
4 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/compiler-cli/src/ngtsc/annotations/src/component.ts
+1 -1
View File
@@ -617,7 +617,7 @@ export class ComponentDecoratorHandler implements
extendedTemplateCheck(
component: ts.ClassDeclaration,
extendedTemplateChecker: ExtendedTemplateChecker): ts.Diagnostic[] {
return extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
return extendedTemplateChecker.getDiagnosticsForComponent(component);
}
resolve(
packages/compiler-cli/src/ngtsc/typecheck/extended/api/extended_template_checker.ts
+1 -1
View File
@@ -16,5 +16,5 @@ export interface ExtendedTemplateChecker {
/**
* Run `TemplateCheck`s for a component and return the generated `ts.Diagnostic`s.
*/
getExtendedTemplateDiagnosticsForComponent(component: ts.ClassDeclaration): TemplateDiagnostic[];
getDiagnosticsForComponent(component: ts.ClassDeclaration): TemplateDiagnostic[];
}
packages/compiler-cli/src/ngtsc/typecheck/extended/src/extended_template_checker.ts
+1 -1
View File
@@ -18,7 +18,7 @@ export class ExtendedTemplateCheckerImpl implements ExtendedTemplateChecker {
private readonly typeChecker: ts.TypeChecker,
private readonly templateChecks: TemplateCheck<ErrorCode>[]) {}
getExtendedTemplateDiagnosticsForComponent(component: ts.ClassDeclaration): TemplateDiagnostic[] {
getDiagnosticsForComponent(component: ts.ClassDeclaration): TemplateDiagnostic[] {
const template = this.templateTypeChecker.getTemplate(component);
// Skip checks if component has no template. This can happen if the user writes a
// `@Component()` but doesn't add the template, could happen in the language service
packages/compiler-cli/src/ngtsc/typecheck/extended/test/template_checks/invalid_banana_in_box/spec.ts
+4 -5
View File
@@ -30,7 +30,7 @@ runInEachFileSystem(() => {
const component = getClass(sf, 'TestCmp');
const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
templateTypeChecker, program.getTypeChecker(), [new InvalidBananaInBoxCheck()]);
const diags = extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
expect(diags.length).toBe(1);
expect(diags[0].category).toBe(ts.DiagnosticCategory.Warning);
expect(diags[0].code).toBe(ngErrorCode(ErrorCode.INVALID_BANANA_IN_BOX));
@@ -50,7 +50,7 @@ runInEachFileSystem(() => {
const component = getClass(sf, 'TestCmp');
const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
templateTypeChecker, program.getTypeChecker(), [new InvalidBananaInBoxCheck()]);
const diags = extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
expect(diags.length).toBe(0);
});
@@ -68,8 +68,7 @@ runInEachFileSystem(() => {
const component = getClass(sf, 'TestCmp');
const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
templateTypeChecker, program.getTypeChecker(), [new InvalidBananaInBoxCheck()]);
const diags =
extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
expect(diags.length).toBe(0);
});
@@ -91,7 +90,7 @@ runInEachFileSystem(() => {
const component = getClass(sf, 'TestCmp');
const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
templateTypeChecker, program.getTypeChecker(), [new InvalidBananaInBoxCheck()]);
const diags = extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
expect(diags.length).toBe(2);
expect(diags[0].category).toBe(ts.DiagnosticCategory.Warning);
expect(diags[0].code).toBe(ngErrorCode(ErrorCode.INVALID_BANANA_IN_BOX));