From db155e455e29a2b8cf23f706de68cab165b1d759 Mon Sep 17 00:00:00 2001 From: Jeremy Elbourn Date: Mon, 3 Dec 2018 13:41:25 -0800 Subject: [PATCH] chore: tweak wording for changelog message in stage-release script (#14374) Also add a newline to the written package.json --- tools/release/stage-release.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/release/stage-release.ts b/tools/release/stage-release.ts index 10347e5409d..a01cfe3ece6 100644 --- a/tools/release/stage-release.ts +++ b/tools/release/stage-release.ts @@ -110,8 +110,8 @@ class StageReleaseTask { console.log(); console.log(green(` ✓ Updated the changelog in ` + `"${bold(CHANGELOG_FILE_NAME)}"`)); - console.log(yellow(` ⚠ You can also make other unrelated modifications. After the ` + - `changes have been made, just continue here.`)); + console.log(yellow(` ⚠ Please review CHANGELOG.md and ensure that the log contains only ` + + `changes that apply to the public library release. When done, proceed to the prompt below.`)); console.log(); const {shouldContinue} = await prompt<{shouldContinue: boolean}>({ @@ -175,7 +175,7 @@ class StageReleaseTask { /** Updates the version of the project package.json and writes the changes to disk. */ private updatePackageJsonVersion(newVersionName: string) { const newPackageJson = {...this.packageJson, version: newVersionName}; - writeFileSync(this.packageJsonPath, JSON.stringify(newPackageJson, null, 2)); + writeFileSync(this.packageJsonPath, JSON.stringify(newPackageJson, null, 2) + '\n'); } /** Verifies that the latest commit of the current branch is passing all Github statuses. */