From d41dedb85b809f67907dd2ee153d92b589553a40 Mon Sep 17 00:00:00 2001 From: JimMorrison723 Date: Thu, 27 Jan 2022 19:56:40 +0100 Subject: [PATCH] fix(devtools): highlighter should only show the hovered component's name (#44863) The used children property on a HTMLCollection does not contain text elements. Because of this, the highlighter overlay text never got fully cleared. PR Close #44863 --- devtools/projects/ng-devtools-backend/src/lib/highlighter.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/devtools/projects/ng-devtools-backend/src/lib/highlighter.ts b/devtools/projects/ng-devtools-backend/src/lib/highlighter.ts index f63c17f26a0..2b984b8084e 100644 --- a/devtools/projects/ng-devtools-backend/src/lib/highlighter.ts +++ b/devtools/projects/ng-devtools-backend/src/lib/highlighter.ts @@ -131,10 +131,7 @@ function showOverlay( overlay.style.top = ~~top + 'px'; overlay.style.left = ~~left + 'px'; - while (overlayContent.children.length) { - const {children} = overlayContent; - overlayContent.removeChild(children[children.length - 1]); - } + overlayContent.replaceChildren(); content.forEach((child) => overlayContent.appendChild(child));