From cca335dc40d3bc562a91a8c2efe831738c972545 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Tue, 13 Dec 2022 20:36:24 +0000 Subject: [PATCH] refactor: update `packages/router` tests to be compatible with ESM (#48538) The ESM js files need to be referenced, and the router tests rely on `async/await` with change detection- so a special rule is required that downlevels `async/await` to generators (similar to the Angular CLI) PR Close #48538 --- packages/router/test/BUILD.bazel | 10 ++++++---- packages/router/upgrade/test/BUILD.bazel | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/router/test/BUILD.bazel b/packages/router/test/BUILD.bazel index 845342e02b6..de2a978bba8 100644 --- a/packages/router/test/BUILD.bazel +++ b/packages/router/test/BUILD.bazel @@ -1,15 +1,15 @@ -load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library") +load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library", "zone_compatible_jasmine_node_test") load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test") circular_dependency_test( name = "circular_deps_test", - entry_point = "angular/packages/router/index.js", + entry_point = "angular/packages/router/index.mjs", deps = ["//packages/router"], ) circular_dependency_test( name = "testing_circular_deps_test", - entry_point = "angular/packages/router/testing/index.js", + entry_point = "angular/packages/router/testing/index.mjs", deps = ["//packages/router/testing"], ) @@ -34,7 +34,9 @@ ts_library( ], ) -jasmine_node_test( +# Tests rely on `async/await` for change detection. +# This syntax needs to be downleveled until ZoneJS supports it. +zone_compatible_jasmine_node_test( name = "test", bootstrap = ["//tools/testing:node"], deps = [ diff --git a/packages/router/upgrade/test/BUILD.bazel b/packages/router/upgrade/test/BUILD.bazel index 8576d6276bf..b220351849c 100644 --- a/packages/router/upgrade/test/BUILD.bazel +++ b/packages/router/upgrade/test/BUILD.bazel @@ -3,7 +3,7 @@ load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test") circular_dependency_test( name = "circular_deps_test", - entry_point = "angular/packages/router/upgrade/index.js", + entry_point = "angular/packages/router/upgrade/index.mjs", deps = ["//packages/router/upgrade"], )