skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(focus-monitor): mark event listeners as passive (#13532)

Browse Source
This commit is contained in:
Paul Gschwendtner
2018-10-19 17:13:33 +02:00
committed by Joey Perrott
parent b5a0b168ee
commit bfc00a005e
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cdk/a11y/focus-monitor/focus-monitor.ts
+13 -6
View File
@@ -241,21 +241,28 @@ export class FocusMonitor implements OnDestroy {
this._windowFocusTimeoutId = setTimeout(() => this._windowFocused = false); this._windowFocusTimeoutId = setTimeout(() => this._windowFocused = false);
}; };
// Event listener options that enable capturing and also mark the the listener as passive
// if the browser supports it.
const captureEventListenerOptions = supportsPassiveEventListeners() ?
{passive: true, capture: true} : true;
// Note: we listen to events in the capture phase so we can detect them even if the user stops // Note: we listen to events in the capture phase so we can detect them even if the user stops
// propagation. // propagation.
this._ngZone.runOutsideAngular(() => { this._ngZone.runOutsideAngular(() => {
document.addEventListener('keydown', documentKeydownListener, true); document.addEventListener('keydown', documentKeydownListener, captureEventListenerOptions);
document.addEventListener('mousedown', documentMousedownListener, true); document.addEventListener('mousedown', documentMousedownListener,
captureEventListenerOptions);
document.addEventListener('touchstart', documentTouchstartListener, document.addEventListener('touchstart', documentTouchstartListener,
supportsPassiveEventListeners() ? ({passive: true, capture: true} as any) : true); captureEventListenerOptions);
window.addEventListener('focus', windowFocusListener); window.addEventListener('focus', windowFocusListener);
}); });
this._unregisterGlobalListeners = () => { this._unregisterGlobalListeners = () => {
document.removeEventListener('keydown', documentKeydownListener, true); document.removeEventListener('keydown', documentKeydownListener, captureEventListenerOptions);
document.removeEventListener('mousedown', documentMousedownListener, true); document.removeEventListener('mousedown', documentMousedownListener,
captureEventListenerOptions);
document.removeEventListener('touchstart', documentTouchstartListener, document.removeEventListener('touchstart', documentTouchstartListener,
supportsPassiveEventListeners() ? ({passive: true, capture: true} as any) : true); captureEventListenerOptions);
window.removeEventListener('focus', windowFocusListener); window.removeEventListener('focus', windowFocusListener);
// Clear timeouts for all potentially pending timeouts to prevent the leaks. // Clear timeouts for all potentially pending timeouts to prevent the leaks.