skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(http): use HttpStatusCode enum in tests (#23548)

Browse Source 
Now that we have introduced human-readable http status codes,
we can use it in our tests to improve clarity.

PR Close #23548
This commit is contained in:
Quentin Focheux
2021-01-26 22:42:04 +01:00
committed by Misko Hevery
parent 6fe3a1de7f
commit baadd109aa
4 changed files with 53 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/common/http/testing/src/request.ts
+3 -3
View File
@@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {HttpErrorResponse, HttpEvent, HttpHeaders, HttpRequest, HttpResponse} from '@angular/common/http';
import {HttpErrorResponse, HttpEvent, HttpHeaders, HttpRequest, HttpResponse, HttpStatusCode} from '@angular/common/http';
import {Observer} from 'rxjs';
/**
@@ -56,10 +56,10 @@ export class TestRequest {
(opts.headers instanceof HttpHeaders) ? opts.headers : new HttpHeaders(opts.headers);
body = _maybeConvertBody(this.request.responseType, body);
let statusText: string|undefined = opts.statusText;
let status: number = opts.status !== undefined ? opts.status : 200;
let status: number = opts.status !== undefined ? opts.status : HttpStatusCode.Ok;
if (opts.status === undefined) {
if (body === null) {
status = 204;
status = HttpStatusCode.NoContent;
statusText = statusText || 'No Content';
} else {
statusText = statusText || 'OK';