From b6d774da420e7f2ec112611eb936f7c4616c2d63 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Mon, 16 Nov 2020 22:18:53 +0200 Subject: [PATCH] docs: fix link to commit in `CHANGELOG.md` (#39704) Currently, the script that is used to generate the `CHANGELOG.md` content uses the first 7 characters of a commit SHA in the generated links. This is problematic when there are multiple commits in the repo (or forks of the repo?) that start with the same 7 characters (which is rare but possible), since GitHub shows a 404 page. This was the case with commit 736e0644b02bc4606a7ae0c974d1b06e993708f6 that is included in the v11.0.0 release notes and happens to start with the same characters as commit 736e064ac80f5e0ed84711694c2ba68809222ffd. This commit fixes the issue by using the full commit SHA in the link for this particular commit. NOTE: The underlying issue should be more generically addressed in the changelog generation tooling. This is being tracked in #39698. PR Close #39704 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b0cf2d5389c..bde74b30699 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -228,7 +228,7 @@ event. ### Code Refactoring -* **compiler:** remove support for TypeScript 3.9 ([#39313](https://github.com/angular/angular/issues/39313)) ([736e064](https://github.com/angular/angular/commit/736e064)) +* **compiler:** remove support for TypeScript 3.9 ([#39313](https://github.com/angular/angular/issues/39313)) ([736e064](https://github.com/angular/angular/commit/736e0644b02bc4606a7ae0c974d1b06e993708f6)) * **router:** adjust type of parameter in `navigateByUrl` and `createUrlTree` to be more accurate ([#38227](https://github.com/angular/angular/issues/38227)) ([e4f4d18](https://github.com/angular/angular/commit/e4f4d18)), closes [#18798](https://github.com/angular/angular/issues/18798)